From: Jani Nikula <jani.nikula@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Michal Wajdeczko <michal.wajdeczko@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v3 3/5] drm/i915: Extend private i915_param_named macro with description
Date: Fri, 15 Sep 2017 14:37:48 +0300 [thread overview]
Message-ID: <87r2v89oqb.fsf@nikula.org> (raw)
In-Reply-To: <150546966753.19729.13529367179638901501@mail.alporthouse.com>
On Fri, 15 Sep 2017, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Quoting Michal Wajdeczko (2017-09-14 16:08:03)
>> We're always specifying description of each module param in
>> separate macro. Let's combine description into our main macro.
>> Started with Coccinelle, followed by minor cleanup.
>>
>> @match1@
>> declarer name MODULE_PARM_DESC;
>> identifier n;
>> constant c;
>> @@
>> (
>> - MODULE_PARM_DESC(n, c);
>> )
>>
>> @fix1 depends on match1@
>> declarer name i915_param_named;
>> declarer name i915_param_named_unsafe;
>> identifier match1.n;
>> constant match1.c;
>> @@
>> (
>> i915_param_named(n, ...
>> + , c
>> );
>> |
>> i915_param_named_unsafe(n, ...
>> + , c
>> );
>> )
>>
>> Suggested-by: Jani Nikula <jani.nikula@intel.com>
>> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
>> Cc: Jani Nikula <jani.nikula@intel.com>
>> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Pushed patches 1-3, undecided for the rest. Thanks for the patches and
review.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-09-15 11:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-14 15:08 [PATCH v3 0/5] drm/i915: Rename global i915 to i915_params Michal Wajdeczko
2017-09-14 15:08 ` [PATCH v3 1/5] drm/i915: Rename lvds_use_ssc modparam to panel_use_ssc Michal Wajdeczko
2017-09-14 15:08 ` [PATCH v3 2/5] drm/i915: Introduce custom variant of module_param_named macro Michal Wajdeczko
2017-09-15 10:00 ` Chris Wilson
2017-09-14 15:08 ` [PATCH v3 3/5] drm/i915: Extend private i915_param_named macro with description Michal Wajdeczko
2017-09-15 10:01 ` Chris Wilson
2017-09-15 11:37 ` Jani Nikula [this message]
2017-09-14 15:08 ` [PATCH v3 4/5] drm/i915: Wrap access to module params into macro Michal Wajdeczko
2017-09-14 15:08 ` [PATCH v3 5/5] drm/i915: Rename global i915 to i915_params Michal Wajdeczko
2017-09-14 15:47 ` ✓ Fi.CI.BAT: success for drm/i915: Rename global i915 to i915_params (rev3) Patchwork
2017-09-14 20:29 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r2v89oqb.fsf@nikula.org \
--to=jani.nikula@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=michal.wajdeczko@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox