intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org, Libin Yang <libin.yang@linux.intel.com>
Subject: Re: drm/i915/audio: m/n value fixes
Date: Wed, 26 Oct 2016 12:41:21 +0300	[thread overview]
Message-ID: <87r373la66.fsf@intel.com> (raw)
In-Reply-To: <20161025153254.GT4617@intel.com>

On Tue, 25 Oct 2016, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Tue, Oct 25, 2016 at 05:54:16PM +0300, Jani Nikula wrote:
>> Remaining patch from https://patchwork.freedesktop.org/series/12754/
>> plus a cleanup.
>
> I'm not feeling like checking bspec for the nuts and bolts details on
> the registers again, but at least the code looks sane to me and the
> M/N values what my test application generates (if I double the values
> for HBR2). Based on that
>
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> for both patches.

And both pushed, thanks for the review.

Libin, Mengdong, please (have someone) do final testing on
drm-intel-nightly to ensure we've got everything covered now.


Thanks,
Jani.


-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2016-10-26  9:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-25 14:54 drm/i915/audio: m/n value fixes Jani Nikula
2016-10-25 14:54 ` [PATCH 1/2] drm/i915/audio: drop extra crtc clock check from HDMI audio N lookup Jani Nikula
2016-10-25 14:54 ` [PATCH 2/2] drm/i915/audio: set proper N/M in modeset Jani Nikula
2016-10-25 15:32 ` drm/i915/audio: m/n value fixes Ville Syrjälä
2016-10-26  9:41   ` Jani Nikula [this message]
2016-10-25 15:46 ` ✗ Fi.CI.BAT: warning for series starting with [1/2] drm/i915/audio: drop extra crtc clock check from HDMI audio N lookup Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r373la66.fsf@intel.com \
    --to=jani.nikula@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=libin.yang@linux.intel.com \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).