* [PATCH] drm/i915/gen9: Remove WaEnableYV12BugFixInHalfSliceChicken7
@ 2016-10-18 11:31 Arkadiusz Hiler
2016-10-18 12:13 ` Mika Kuoppala
2016-10-18 15:09 ` [PATCH v2] " Arkadiusz Hiler
0 siblings, 2 replies; 6+ messages in thread
From: Arkadiusz Hiler @ 2016-10-18 11:31 UTC (permalink / raw)
To: intel-gfx
Dropping WA because it was for early steppings.
It is fixed in newer preproduction and all production revisions.
Cc: Michal Winiarski <michal.winiarski@intel.com>
Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
---
drivers/gpu/drm/i915/intel_ringbuffer.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c
index e107455..32786ba 100644
--- a/drivers/gpu/drm/i915/intel_ringbuffer.c
+++ b/drivers/gpu/drm/i915/intel_ringbuffer.c
@@ -849,10 +849,8 @@ static int gen9_init_workarounds(struct intel_engine_cs *engine)
*/
}
- /* WaEnableYV12BugFixInHalfSliceChicken7:skl,bxt,kbl */
/* WaEnableSamplerGPGPUPreemptionSupport:skl,bxt,kbl */
WA_SET_BIT_MASKED(GEN9_HALF_SLICE_CHICKEN7,
- GEN9_ENABLE_YV12_BUGFIX |
GEN9_ENABLE_GPGPU_PREEMPTION);
/* Wa4x4STCOptimizationDisable:skl,bxt,kbl */
--
2.7.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915/gen9: Remove WaEnableYV12BugFixInHalfSliceChicken7
2016-10-18 11:31 [PATCH] drm/i915/gen9: Remove WaEnableYV12BugFixInHalfSliceChicken7 Arkadiusz Hiler
@ 2016-10-18 12:13 ` Mika Kuoppala
2016-10-18 13:15 ` Mika Kuoppala
2016-10-18 15:09 ` [PATCH v2] " Arkadiusz Hiler
1 sibling, 1 reply; 6+ messages in thread
From: Mika Kuoppala @ 2016-10-18 12:13 UTC (permalink / raw)
To: Arkadiusz Hiler, intel-gfx
Arkadiusz Hiler <arkadiusz.hiler@intel.com> writes:
> Dropping WA because it was for early steppings.
>
> It is fixed in newer preproduction and all production revisions.
>
We have used References tag to point to a relevant document
that has more information. Like for this, it should be:
References: HSD#2126385
From there I did figure out that this should be from skl:C0 onwards.
So based on that, we need this wa still.
-Mika
> Cc: Michal Winiarski <michal.winiarski@intel.com>
> Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
> ---
> drivers/gpu/drm/i915/intel_ringbuffer.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c
> index e107455..32786ba 100644
> --- a/drivers/gpu/drm/i915/intel_ringbuffer.c
> +++ b/drivers/gpu/drm/i915/intel_ringbuffer.c
> @@ -849,10 +849,8 @@ static int gen9_init_workarounds(struct intel_engine_cs *engine)
> */
> }
>
> - /* WaEnableYV12BugFixInHalfSliceChicken7:skl,bxt,kbl */
> /* WaEnableSamplerGPGPUPreemptionSupport:skl,bxt,kbl */
> WA_SET_BIT_MASKED(GEN9_HALF_SLICE_CHICKEN7,
> - GEN9_ENABLE_YV12_BUGFIX |
> GEN9_ENABLE_GPGPU_PREEMPTION);
>
> /* Wa4x4STCOptimizationDisable:skl,bxt,kbl */
> --
> 2.7.4
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915/gen9: Remove WaEnableYV12BugFixInHalfSliceChicken7
2016-10-18 12:13 ` Mika Kuoppala
@ 2016-10-18 13:15 ` Mika Kuoppala
2016-10-18 13:25 ` Chris Wilson
0 siblings, 1 reply; 6+ messages in thread
From: Mika Kuoppala @ 2016-10-18 13:15 UTC (permalink / raw)
To: Arkadiusz Hiler, intel-gfx
Mika Kuoppala <mika.kuoppala@linux.intel.com> writes:
> Arkadiusz Hiler <arkadiusz.hiler@intel.com> writes:
>
>> Dropping WA because it was for early steppings.
>>
>> It is fixed in newer preproduction and all production revisions.
>>
>
> We have used References tag to point to a relevant document
> that has more information. Like for this, it should be:
>
> References: HSD#2126385
>
> From there I did figure out that this should be from skl:C0 onwards.
>
> So based on that, we need this wa still.
I fell victim of out-of-date/conflicting information.
Arkadiusz kindly pointed me to the correct sources and cleared
the confusion. I am convinced we can drop this workaround.
Reviewed-by: Mika Kuoppala <mika.kuoppala@intel.com>
>
> -Mika
>
>
>> Cc: Michal Winiarski <michal.winiarski@intel.com>
>> Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
>> ---
>> drivers/gpu/drm/i915/intel_ringbuffer.c | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c
>> index e107455..32786ba 100644
>> --- a/drivers/gpu/drm/i915/intel_ringbuffer.c
>> +++ b/drivers/gpu/drm/i915/intel_ringbuffer.c
>> @@ -849,10 +849,8 @@ static int gen9_init_workarounds(struct intel_engine_cs *engine)
>> */
>> }
>>
>> - /* WaEnableYV12BugFixInHalfSliceChicken7:skl,bxt,kbl */
>> /* WaEnableSamplerGPGPUPreemptionSupport:skl,bxt,kbl */
>> WA_SET_BIT_MASKED(GEN9_HALF_SLICE_CHICKEN7,
>> - GEN9_ENABLE_YV12_BUGFIX |
>> GEN9_ENABLE_GPGPU_PREEMPTION);
>>
>> /* Wa4x4STCOptimizationDisable:skl,bxt,kbl */
>> --
>> 2.7.4
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915/gen9: Remove WaEnableYV12BugFixInHalfSliceChicken7
2016-10-18 13:15 ` Mika Kuoppala
@ 2016-10-18 13:25 ` Chris Wilson
2016-10-18 14:06 ` Mika Kuoppala
0 siblings, 1 reply; 6+ messages in thread
From: Chris Wilson @ 2016-10-18 13:25 UTC (permalink / raw)
To: Mika Kuoppala; +Cc: intel-gfx
On Tue, Oct 18, 2016 at 04:15:22PM +0300, Mika Kuoppala wrote:
> Mika Kuoppala <mika.kuoppala@linux.intel.com> writes:
>
> > Arkadiusz Hiler <arkadiusz.hiler@intel.com> writes:
> >
> >> Dropping WA because it was for early steppings.
> >>
> >> It is fixed in newer preproduction and all production revisions.
> >>
> >
> > We have used References tag to point to a relevant document
> > that has more information. Like for this, it should be:
> >
> > References: HSD#2126385
> >
> > From there I did figure out that this should be from skl:C0 onwards.
> >
> > So based on that, we need this wa still.
>
> I fell victim of out-of-date/conflicting information.
> Arkadiusz kindly pointed me to the correct sources and cleared
> the confusion. I am convinced we can drop this workaround.
So documentation link / hint to clear the confusion?
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915/gen9: Remove WaEnableYV12BugFixInHalfSliceChicken7
2016-10-18 13:25 ` Chris Wilson
@ 2016-10-18 14:06 ` Mika Kuoppala
0 siblings, 0 replies; 6+ messages in thread
From: Mika Kuoppala @ 2016-10-18 14:06 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
Chris Wilson <chris@chris-wilson.co.uk> writes:
> On Tue, Oct 18, 2016 at 04:15:22PM +0300, Mika Kuoppala wrote:
>> Mika Kuoppala <mika.kuoppala@linux.intel.com> writes:
>>
>> > Arkadiusz Hiler <arkadiusz.hiler@intel.com> writes:
>> >
>> >> Dropping WA because it was for early steppings.
>> >>
>> >> It is fixed in newer preproduction and all production revisions.
>> >>
>> >
>> > We have used References tag to point to a relevant document
>> > that has more information. Like for this, it should be:
>> >
>> > References: HSD#2126385
>> >
>> > From there I did figure out that this should be from skl:C0 onwards.
>> >
>> > So based on that, we need this wa still.
>>
>> I fell victim of out-of-date/conflicting information.
>> Arkadiusz kindly pointed me to the correct sources and cleared
>> the confusion. I am convinced we can drop this workaround.
>
> So documentation link / hint to clear the confusion?
Wa database had FROM_C0 and hsd,bspec has UNTIL_B0.
-Mika
> -Chris
>
> --
> Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] drm/i915/gen9: Remove WaEnableYV12BugFixInHalfSliceChicken7
2016-10-18 11:31 [PATCH] drm/i915/gen9: Remove WaEnableYV12BugFixInHalfSliceChicken7 Arkadiusz Hiler
2016-10-18 12:13 ` Mika Kuoppala
@ 2016-10-18 15:09 ` Arkadiusz Hiler
1 sibling, 0 replies; 6+ messages in thread
From: Arkadiusz Hiler @ 2016-10-18 15:09 UTC (permalink / raw)
To: intel-gfx; +Cc: Mika Kuoppala
Dropping WA because it was for early steppings.
It is fixed in newer preproduction and all production revisions.
v2: add references, updated commit message
References: HSD#2126385, HSD#2131381, BSID#0764
Cc: Mika Kuoppala <mika.kuoppala@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Michal Winiarski <michal.winiarski@intel.com>
Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
---
drivers/gpu/drm/i915/intel_ringbuffer.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c
index e107455..32786ba 100644
--- a/drivers/gpu/drm/i915/intel_ringbuffer.c
+++ b/drivers/gpu/drm/i915/intel_ringbuffer.c
@@ -849,10 +849,8 @@ static int gen9_init_workarounds(struct intel_engine_cs *engine)
*/
}
- /* WaEnableYV12BugFixInHalfSliceChicken7:skl,bxt,kbl */
/* WaEnableSamplerGPGPUPreemptionSupport:skl,bxt,kbl */
WA_SET_BIT_MASKED(GEN9_HALF_SLICE_CHICKEN7,
- GEN9_ENABLE_YV12_BUGFIX |
GEN9_ENABLE_GPGPU_PREEMPTION);
/* Wa4x4STCOptimizationDisable:skl,bxt,kbl */
--
2.7.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-10-18 15:09 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-18 11:31 [PATCH] drm/i915/gen9: Remove WaEnableYV12BugFixInHalfSliceChicken7 Arkadiusz Hiler
2016-10-18 12:13 ` Mika Kuoppala
2016-10-18 13:15 ` Mika Kuoppala
2016-10-18 13:25 ` Chris Wilson
2016-10-18 14:06 ` Mika Kuoppala
2016-10-18 15:09 ` [PATCH v2] " Arkadiusz Hiler
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox