From: Jani Nikula <jani.nikula@linux.intel.com>
To: Dave Gordon <david.s.gordon@intel.com>,
Chris Wilson <chris@chris-wilson.co.uk>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
intel-gfx@lists.freedesktop.org,
Mika Kuoppala <mika.kuoppala@linux.intel.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH 05/18] drm/i915: Move GEM activity tracking into a common struct reservation_object
Date: Thu, 15 Sep 2016 12:55:41 +0300 [thread overview]
Message-ID: <87r38lpjvm.fsf@intel.com> (raw)
In-Reply-To: <bcdfce3e-747c-6227-248a-1c8d8b78513b@intel.com>
On Thu, 15 Sep 2016, Dave Gordon <david.s.gordon@intel.com> wrote:
> On 14/09/16 18:35, Chris Wilson wrote:
>> On Wed, Sep 14, 2016 at 12:44:04PM +0300, Joonas Lahtinen wrote:
>>> On ke, 2016-09-14 at 07:52 +0100, Chris Wilson wrote:
>>>> -static inline bool
>>>> -i915_gem_object_has_active_engine(const struct drm_i915_gem_object *obj,
>>>> - int engine)
>>>> -{
>>>> - return obj->flags & BIT(engine + I915_BO_ACTIVE_SHIFT);
>>>> + return obj->active_count;
>>>
>>> our type is bool, so !!obj->active_count;
>>
>> That's the beauty of using bool, !! is implied on the (bool)integer
>> conversion.
>> -Chris
>
> It's a gcc extension, though, so does it work on clang?
It's in the standard.
"When any scalar value is converted to _Bool, the result is 0 if the
value compares equal to 0; otherwise, the result is 1."
BR,
Jani.
>
> .Dave.
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-09-15 9:55 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-14 6:52 Tracking multiple timelines (full-ppgtt) Chris Wilson
2016-09-14 6:52 ` [PATCH 01/18] drm/i915: Support asynchronous waits on struct fence from i915_gem_request Chris Wilson
2016-09-14 7:37 ` Joonas Lahtinen
2016-09-19 11:26 ` Chris Wilson
2016-09-14 6:52 ` [PATCH 02/18] drm/i915: Allow i915_sw_fence_await_sw_fence() to allocate Chris Wilson
2016-09-14 7:51 ` Joonas Lahtinen
2016-09-14 8:46 ` Chris Wilson
2016-09-14 6:52 ` [PATCH 03/18] drm/i915: Rearrange i915_wait_request() accounting with callers Chris Wilson
2016-09-14 8:47 ` Joonas Lahtinen
2016-09-14 6:52 ` [PATCH 04/18] drm/i915: Remove unused i915_gem_active_wait() in favour of _unlocked() Chris Wilson
2016-09-14 8:48 ` Joonas Lahtinen
2016-09-14 6:52 ` [PATCH 05/18] drm/i915: Move GEM activity tracking into a common struct reservation_object Chris Wilson
2016-09-14 9:44 ` Joonas Lahtinen
2016-09-14 17:35 ` Chris Wilson
2016-09-15 9:38 ` Dave Gordon
2016-09-15 9:55 ` Jani Nikula [this message]
2016-09-16 11:40 ` Chris Wilson
2016-09-14 6:52 ` [PATCH 06/18] drm: Add reference counting to drm_atomic_state Chris Wilson
2016-09-14 6:52 ` [PATCH 07/18] drm/i915: Restore nonblocking awaits for modesetting Chris Wilson
2016-09-19 16:01 ` Joonas Lahtinen
2016-09-14 6:52 ` [PATCH 08/18] drm/i915: Combine seqno + tracking into a global timeline struct Chris Wilson
2016-09-14 15:42 ` Joonas Lahtinen
2016-09-14 6:52 ` [PATCH 09/18] drm/i915: Wait first for submission, before waiting for request completion Chris Wilson
2016-09-19 8:59 ` Joonas Lahtinen
2016-09-14 6:52 ` [PATCH 10/18] drm/i915: Introduce a global_seqno for each request Chris Wilson
2016-09-19 10:36 ` Joonas Lahtinen
2016-09-14 6:52 ` [PATCH 11/18] drm/i915: Record space required for request emission Chris Wilson
2016-09-14 13:30 ` Tvrtko Ursulin
2016-09-14 17:33 ` Chris Wilson
2016-09-15 8:59 ` Tvrtko Ursulin
2016-09-19 10:47 ` Joonas Lahtinen
2016-09-19 11:32 ` Chris Wilson
2016-09-19 16:09 ` Joonas Lahtinen
2016-09-14 6:52 ` [PATCH 12/18] drm/i915: Defer " Chris Wilson
2016-09-19 12:06 ` Joonas Lahtinen
2016-09-14 6:52 ` [PATCH 13/18] drm/i915: Move the global sync optimisation to the timeline Chris Wilson
2016-09-19 13:16 ` Joonas Lahtinen
2016-09-14 6:52 ` [PATCH 14/18] drm/i915: Create a unique name for the context Chris Wilson
2016-09-19 13:23 ` Joonas Lahtinen
2016-09-14 6:52 ` [PATCH 15/18] drm/i915: Reserve space in the global seqno during request allocation Chris Wilson
2016-09-19 13:47 ` Joonas Lahtinen
2016-09-19 15:35 ` Jani Nikula
2016-09-19 16:07 ` Joonas Lahtinen
2016-09-14 6:52 ` [PATCH 16/18] drm/i915: Enable multiple timelines Chris Wilson
2016-09-19 15:52 ` Joonas Lahtinen
2016-10-20 12:49 ` Chris Wilson
2016-10-20 15:25 ` Joonas Lahtinen
2016-09-14 6:52 ` [PATCH 17/18] drm/i915: Enable userspace to opt-out of implicit fencing Chris Wilson
2016-09-14 6:52 ` [PATCH 18/18] drm/i915: Support explicit fencing for execbuf Chris Wilson
2016-09-14 9:16 ` ✗ Fi.CI.BAT: failure for series starting with [01/18] drm/i915: Support asynchronous waits on struct fence from i915_gem_request Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r38lpjvm.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=david.s.gordon@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=joonas.lahtinen@linux.intel.com \
--cc=mika.kuoppala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).