From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/7] drm/i915: Use milliseconds in _wait_for macro
Date: Wed, 18 May 2016 14:07:53 +0300 [thread overview]
Message-ID: <87r3cz62uu.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <20160518110107.GI30479@nuc-i3427.alporthouse.com>
Chris Wilson <chris@chris-wilson.co.uk> writes:
> [ text/plain ]
> On Tue, May 17, 2016 at 06:43:23PM +0300, Mika Kuoppala wrote:
>> Promising 1us accuracy where we timeout using jiffies is
>> misleading. Convert the _wait_for macro to use milliseconds
>> and convert the 2 callsites.
>
> Note this is not about timeout but the the sleep. The timeout here is
> still as inaccurate as ever as it remains jiffie based.
>
Hmm no, the sleep is still in usecs at this stage, unmodified.
-Mika
> (And I have no qualms about the timeout being too high, unless there is
> a specific example that mandates high accuracy.)
> -Chris
>
> --
> Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-05-18 11:10 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-17 15:43 [PATCH 0/7] wait_for and wait_until_reg Mika Kuoppala
2016-05-17 15:43 ` [PATCH 1/7] drm/i915: Remove the wait_for_us macro Mika Kuoppala
2016-05-18 8:14 ` Daniel Vetter
2016-05-17 15:43 ` [PATCH 2/7] drm/i915: Use milliseconds in _wait_for macro Mika Kuoppala
2016-05-18 8:18 ` Daniel Vetter
2016-05-18 11:01 ` Chris Wilson
2016-05-18 11:07 ` Mika Kuoppala [this message]
2016-05-18 11:17 ` Chris Wilson
2016-05-17 15:43 ` [PATCH 3/7] drm/i915: Spin opportunistically in wait_for Mika Kuoppala
2016-05-18 8:20 ` Daniel Vetter
2016-05-18 10:47 ` Chris Wilson
2016-05-18 11:08 ` Mika Kuoppala
2016-05-18 8:46 ` Ville Syrjälä
2016-05-17 15:43 ` [PATCH 4/7] drm/i915: Take longer naps " Mika Kuoppala
2016-05-18 8:28 ` Daniel Vetter
2016-05-17 15:43 ` [PATCH 5/7] drm/i915: Introduce wait_until_reg Mika Kuoppala
2016-05-18 8:33 ` Daniel Vetter
2016-05-17 15:43 ` [PATCH 6/7] drm/i915: Use wait_until_reg macros Mika Kuoppala
2016-05-18 8:40 ` Daniel Vetter
2016-05-17 15:43 ` [PATCH 7/7] drm/i915/debug: Warn when waiting on condition timeouts Mika Kuoppala
2016-05-18 11:16 ` Chris Wilson
2016-05-17 16:54 ` ✗ Ro.CI.BAT: failure for wait_for and wait_until_reg Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r3cz62uu.fsf@gaia.fi.intel.com \
--to=mika.kuoppala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox