From: Jani Nikula <jani.nikula@intel.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: Deepak M <m.deepak@intel.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 11/11] drm/i915/opregion: handle VBT sizes bigger than 6 KB
Date: Wed, 16 Dec 2015 11:37:34 +0200 [thread overview]
Message-ID: <87r3imspi9.fsf@intel.com> (raw)
In-Reply-To: <20151215140249.GF4437@intel.com>
On Tue, 15 Dec 2015, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Mon, Dec 14, 2015 at 04:34:34PM +0200, Ville Syrjälä wrote:
>> On Mon, Dec 14, 2015 at 04:19:50PM +0200, Ville Syrjälä wrote:
>> > On Mon, Dec 14, 2015 at 12:50:55PM +0200, Jani Nikula wrote:
>> > Either I'm blind or you didn't actually add rvda/rvds to struct opregion_asle.
>>
>> Oh I se they went in seprately as
>> c85f6c91ec42 ("drm/i915: add VBT address and size fields to ASLE mailbox struct")
>>
>> OK, so apart from the few minor bikesheds I listed it all looks good to
>> me. For the series
>> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> r-b still holds for the patches with the revised debug prints.
Patches 1-10 pushed to drm-intel-next-queued, thanks for the review. I'm
still holding off pushing patch 11 until I get a Tested-by from Mika,
as I don't have a machine with rvda set.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-12-16 9:38 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-14 10:50 [PATCH 00/11] drm/i915: VBT/opregion refactor to support >6 KB VBT Jani Nikula
2015-12-14 10:50 ` [PATCH 01/11] drm/i915: Add Intel opregion mailbox 5 structure Jani Nikula
2015-12-14 10:50 ` [PATCH 02/11] drm/i915: move "no VBT in opregion" quirk to intel_opregion_setup() Jani Nikula
2015-12-14 10:50 ` [PATCH 03/11] drm/i915/bios: have functions return vbt, not bdb, header pointer Jani Nikula
2015-12-14 10:50 ` [PATCH 04/11] drm/i915/bios: move debug logging about VBT source to intel_parse_bios() Jani Nikula
2015-12-15 11:14 ` [PATCH v2 " Jani Nikula
2015-12-14 10:50 ` [PATCH 05/11] drm/i915/bios: rename intel_parse_bios to intel_bios_init Jani Nikula
2015-12-14 10:50 ` [PATCH 06/11] drm/i915: refactor VBT validation Jani Nikula
2015-12-14 13:41 ` Ville Syrjälä
2015-12-14 14:34 ` Jani Nikula
2015-12-14 14:42 ` Ville Syrjälä
2015-12-15 11:16 ` [PATCH v2 " Jani Nikula
2015-12-14 10:50 ` [PATCH 07/11] drm/i915/opregion: make VBT size limit more strict Jani Nikula
2015-12-14 10:50 ` [PATCH 08/11] drm/i915/opregion: make VBT pointer a const Jani Nikula
2015-12-14 10:50 ` [PATCH 09/11] drm/i915: don't use a temp buffer for opregion debugfs file Jani Nikula
2015-12-14 13:45 ` Ville Syrjälä
2015-12-14 14:38 ` Jani Nikula
2015-12-14 14:45 ` Ville Syrjälä
2015-12-14 10:50 ` [PATCH 10/11] drm/i915/debugfs: add a separate debugfs file for VBT Jani Nikula
2015-12-14 10:57 ` Chris Wilson
2015-12-14 11:06 ` Jani Nikula
2015-12-14 11:29 ` Chris Wilson
2015-12-14 13:20 ` [PATCH v2 " Jani Nikula
2015-12-15 11:17 ` [PATCH v3 " Jani Nikula
2015-12-14 10:50 ` [PATCH 11/11] drm/i915/opregion: handle VBT sizes bigger than 6 KB Jani Nikula
2015-12-14 14:19 ` Ville Syrjälä
2015-12-14 14:34 ` Ville Syrjälä
2015-12-15 14:02 ` Ville Syrjälä
2015-12-16 9:37 ` Jani Nikula [this message]
2015-12-14 14:40 ` Jani Nikula
2015-12-15 11:18 ` [PATCH v2 " Jani Nikula
2015-12-17 7:30 ` [PATCH " Mika Kahola
2015-12-17 9:46 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r3imspi9.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=m.deepak@intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).