From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH v2 2/2] drm/i915: access the PP_ON_DELAYS/PP_OFF_DELAYS regs only pre GEN5 Date: Fri, 04 Sep 2015 11:57:17 +0300 Message-ID: <87r3mezhn6.fsf@intel.com> References: <1441286676-26630-1-git-send-email-imre.deak@intel.com> <1441286676-26630-2-git-send-email-imre.deak@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTP id BD9697A17A for ; Fri, 4 Sep 2015 01:54:10 -0700 (PDT) In-Reply-To: <1441286676-26630-2-git-send-email-imre.deak@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Imre Deak , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCAwMyBTZXAgMjAxNSwgSW1yZSBEZWFrIDxpbXJlLmRlYWtAaW50ZWwuY29tPiB3cm90 ZToKPiBUaGVzZSByZWdpc3RlcnMgZXhpc3Qgb25seSBiZWZvcmUgR0VONSwgc28gY3VycmVudGx5 IHdlIG1heSBhY2Nlc3MKPiB1bmRlZmluZWQgcmVnaXN0ZXJzIG9uIFZMVi9DSFYgYW5kIEJYVC4g QXBwbHkgdGhlIHdvcmthcm91bmQgb25seSBwcmUKPiBHRU41Lgo+Cj4gU2luY2UgdGhlIHdvcmth cm91bmQgaXMgcmVsZXZhbnQgb25seSB3aGVuIExWRFMgaXMgcHJlc2VudCwgZm9yIGNsYXJpdHkK PiBhcHBseSBpdCBvbmx5IGlmIHRoaXMgaXMgdGhlIGNhc2UuCgpGdW4gdGhvdWdodCwgaWYgdGhv c2UgcmVnaXN0ZXJzIGFyZSBpbmRlZWQgMCwgaXQncyBwcm9iYWJseSBzYWZlIHRvCmFzc3VtZSBQ UF9DT05UUk9MIGlzIHRvbywgb3IgYXQgbGVhc3QgZG9lc24ndCBoYXZlIFBBTkVMX1VOTE9DS19S RUdTCnNldC4uLiB3aGljaCBpbiB0dXJuIHdvdWxkIG1lYW4gdGhlIHdyaXRlIGluIGludGVsX3Nl dHVwX2Jpb3MoKSBkaWRuJ3QKZ28gdGhyb3VnaCBhbnl3YXkuIFdpdGggdGhpcyBwYXRjaCwgd2Un bGwgYWN0dWFsbHkgZG8gc29tZXRoaW5nIGFib3V0Cml0LiA6KQoKSmFuaS4KCgoKPgo+IFRoaXMg dHJpZ2dlcmVkIGFuIHVuY2xhaW1lZCByZWdpc3RlciBhY2Nlc3Mgd2FybmluZyBvbiBCWFQuCj4K PiB2MjogKFZpbGxlKQo+IC0gbW92ZSB0aGUgd29ya2Fyb3VuZCB0byB0aGUgTFZEUyBpbml0IGNv ZGUKPiAtIHByaW50IGEgZGVidWcgbm90ZSBhYm91dCB0aGUgd29ya2Fyb3VuZAo+Cj4gU2lnbmVk LW9mZi1ieTogSW1yZSBEZWFrIDxpbXJlLmRlYWtAaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJz L2dwdS9kcm0vaTkxNS9pOTE1X2RtYS5jICAgfCAgMiAtLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9iaW9zLmMgfCAxOCAtLS0tLS0tLS0tLS0tLS0tLS0KPiAgZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfYmlvcy5oIHwgIDEgLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9s dmRzLmMgfCAxMiArKysrKysrKysrKysKPiAgNCBmaWxlcyBjaGFuZ2VkLCAxMiBpbnNlcnRpb25z KCspLCAyMSBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pOTE1X2RtYS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kbWEuYwo+IGluZGV4IGYw ZWFhNmYuLjA2NmEwZWYgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9k bWEuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZG1hLmMKPiBAQCAtOTk3LDgg Kzk5Nyw2IEBAIGludCBpOTE1X2RyaXZlcl9sb2FkKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHVu c2lnbmVkIGxvbmcgZmxhZ3MpCj4gIAlpbnRlbF9zZXR1cF9nbWJ1cyhkZXYpOwo+ICAJaW50ZWxf b3ByZWdpb25fc2V0dXAoZGV2KTsKPiAgCj4gLQlpbnRlbF9zZXR1cF9iaW9zKGRldik7Cj4gLQo+ ICAJaTkxNV9nZW1fbG9hZChkZXYpOwo+ICAKPiAgCS8qIE9uIHRoZSA5NDVHL0dNLCB0aGUgY2hp cHNldCByZXBvcnRzIHRoZSBNU0kgY2FwYWJpbGl0eSBvbiB0aGUKPiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfYmlvcy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfYmlvcy5jCj4gaW5kZXggYjNlNDM3Yi4uYzhhY2MyOSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9iaW9zLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9iaW9zLmMKPiBAQCAtMTM0MCwyMSArMTM0MCwzIEBAIGludGVsX3BhcnNlX2Jpb3Moc3Ry dWN0IGRybV9kZXZpY2UgKmRldikKPiAgCj4gIAlyZXR1cm4gMDsKPiAgfQo+IC0KPiAtLyogRW5z dXJlIHRoYXQgdml0YWwgcmVnaXN0ZXJzIGhhdmUgYmVlbiBpbml0aWFsaXNlZCwgZXZlbiBpZiB0 aGUgQklPUwo+IC0gKiBpcyBhYnNlbnQgb3IganVzdCBmYWlsaW5nIHRvIGRvIGl0cyBqb2IuCj4g LSAqLwo+IC12b2lkIGludGVsX3NldHVwX2Jpb3Moc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiAt ewo+IC0Jc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gZGV2LT5kZXZfcHJpdmF0 ZTsKPiAtCj4gLQkgLyogU2V0IHRoZSBQYW5lbCBQb3dlciBPbi9PZmYgdGltaW5ncyBpZiB1bmlu aXRpYWxpemVkLiAqLwo+IC0JaWYgKCFIQVNfUENIX1NQTElUKGRldikgJiYKPiAtCSAgICBJOTE1 X1JFQUQoUFBfT05fREVMQVlTKSA9PSAwICYmIEk5MTVfUkVBRChQUF9PRkZfREVMQVlTKSA9PSAw KSB7Cj4gLQkJLyogU2V0IFQyIHRvIDQwbXMgYW5kIFQ1IHRvIDIwMG1zICovCj4gLQkJSTkxNV9X UklURShQUF9PTl9ERUxBWVMsIDB4MDE5MDA3ZDApOwo+IC0KPiAtCQkvKiBTZXQgVDMgdG8gMzVt cyBhbmQgVHggdG8gMjAwbXMgKi8KPiAtCQlJOTE1X1dSSVRFKFBQX09GRl9ERUxBWVMsIDB4MDE1 ZTA3ZDApOwo+IC0JfQo+IC19Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2Jpb3MuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Jpb3MuaAo+IGluZGV4IDQ2 Y2Q1YzcuLjFiNzQxN2UgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf Ymlvcy5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfYmlvcy5oCj4gQEAgLTU4 OCw3ICs1ODgsNiBAQCBzdHJ1Y3QgYmRiX3BzciB7Cj4gIAlzdHJ1Y3QgcHNyX3RhYmxlIHBzcl90 YWJsZVsxNl07Cj4gIH0gX19wYWNrZWQ7Cj4gIAo+IC12b2lkIGludGVsX3NldHVwX2Jpb3Moc3Ry dWN0IGRybV9kZXZpY2UgKmRldik7Cj4gIGludCBpbnRlbF9wYXJzZV9iaW9zKHN0cnVjdCBkcm1f ZGV2aWNlICpkZXYpOwo+ICAKPiAgLyoKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfbHZkcy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHZkcy5jCj4gaW5k ZXggYTE2MzA4YS4uMmMyZDFmMCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9sdmRzLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9sdmRzLmMKPiBA QCAtOTg1LDYgKzk4NSwxOCBAQCB2b2lkIGludGVsX2x2ZHNfaW5pdChzdHJ1Y3QgZHJtX2Rldmlj ZSAqZGV2KQo+ICAJCURSTV9ERUJVR19LTVMoIkxWRFMgaXMgbm90IHByZXNlbnQgaW4gVkJULCBi dXQgZW5hYmxlZCBhbnl3YXlcbiIpOwo+ICAJfQo+ICAKPiArCSAvKiBTZXQgdGhlIFBhbmVsIFBv d2VyIE9uL09mZiB0aW1pbmdzIGlmIHVuaW5pdGlhbGl6ZWQuICovCj4gKwlpZiAoSU5URUxfSU5G TyhkZXZfcHJpdiktPmdlbiA8IDUgJiYKPiArCSAgICBJOTE1X1JFQUQoUFBfT05fREVMQVlTKSA9 PSAwICYmIEk5MTVfUkVBRChQUF9PRkZfREVMQVlTKSA9PSAwKSB7Cj4gKwkJLyogU2V0IFQyIHRv IDQwbXMgYW5kIFQ1IHRvIDIwMG1zICovCj4gKwkJSTkxNV9XUklURShQUF9PTl9ERUxBWVMsIDB4 MDE5MDA3ZDApOwo+ICsKPiArCQkvKiBTZXQgVDMgdG8gMzVtcyBhbmQgVHggdG8gMjAwbXMgKi8K PiArCQlJOTE1X1dSSVRFKFBQX09GRl9ERUxBWVMsIDB4MDE1ZTA3ZDApOwo+ICsKPiArCQlEUk1f REVCVUdfS01TKCJQYW5lbCBwb3dlciB0aW1pbmdzIHVuaW5pdGlhbGl6ZWQsIHNldHRpbmcgZGVm YXVsdHNcbiIpOwo+ICsJfQo+ICsKPiAgCWx2ZHNfZW5jb2RlciA9IGt6YWxsb2Moc2l6ZW9mKCps dmRzX2VuY29kZXIpLCBHRlBfS0VSTkVMKTsKPiAgCWlmICghbHZkc19lbmNvZGVyKQo+ICAJCXJl dHVybjsKPiAtLSAKPiAyLjEuNAo+Cj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwo+IGh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9pbnRlbC1nZngKCi0tIApKYW5pIE5pa3VsYSwgSW50ZWwgT3BlbiBTb3VyY2UgVGVj aG5vbG9neSBDZW50ZXIKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1n ZngK