From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH v2 1/3] drm/i915: Don't check modeset state in the hw state force restore path Date: Wed, 17 Jun 2015 15:13:08 +0300 Message-ID: <87r3pa354b.fsf@intel.com> References: <1434444585-25708-1-git-send-email-ander.conselvan.de.oliveira@intel.com> <87twu635iu.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTP id 6FEF56EA63 for ; Wed, 17 Jun 2015 05:11:16 -0700 (PDT) In-Reply-To: <87twu635iu.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: intel-gfx@lists.freedesktop.org Cc: Ander Conselvan de Oliveira List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCAxNyBKdW4gMjAxNSwgSmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGxpbnV4LmludGVs LmNvbT4gd3JvdGU6Cj4gT24gVHVlLCAxNiBKdW4gMjAxNSwgQW5kZXIgQ29uc2VsdmFuIGRlIE9s aXZlaXJhIDxhbmRlci5jb25zZWx2YW4uZGUub2xpdmVpcmFAaW50ZWwuY29tPiB3cm90ZToKPj4g U2luY2UgdGhlIGZvcmNlIHJlc3RvcmUgbG9naWMgd2lsbCByZXN0b3JlIHRoZSBDUlRDcyBzdGF0 ZSBvbmUgYXQgYQo+PiB0aW1lLCBpdCBpcyBwb3NzaWJsZSB0aGF0IHRoZSBzdGF0ZSB3aWxsIGJl IGluY29uc2lzdGVudCB1bnRpbCB0aGUgd2hvbGUKPj4gb3BlcmF0aW9uIGZpbmlzaGVzLiBBIGNh bGwgdG8gaW50ZWxfbW9kZXNldF9jaGVja19zdGF0ZSgpIGlzIGRvbmUgb25jZQo+PiBpdCdzIG92 ZXIsIHNvIGRvbid0IGNoZWNrIHRoZSBzdGF0ZSBtdWx0aXBsZSB0aW1lcyBpbiBiZXR3ZWVuLiBU aGlzCj4+IHJlZ3Jlc3Npb24gd2FzIGludHJvZHVjZWQgaW46Cj4+Cj4+IGNvbW1pdCA3ZjI3MTI2 ZWEzZGI2YWRlODg2ZjE4ZmQzOWNhZjBmZjBjZDFkMzdmCj4+IEF1dGhvcjogSmVzc2UgQmFybmVz IDxqYmFybmVzQHZpcnR1b3VzZ2Vlay5vcmc+Cj4+IERhdGU6ICAgV2VkIE5vdiA1IDE0OjI2OjA2 IDIwMTQgLTA4MDAKPj4KPj4gICAgIGRybS9pOTE1OiBmYWN0b3Igb3V0IGNvbXB1dGVfY29uZmln IGZyb20gX19pbnRlbF9zZXRfbW9kZSB2Mwo+Pgo+PiB2MjogUmVuYW1lIGNoZWNrIHBhcmFtZXRl ciB0byBmb3JjZV9yZXN0b3JlLiAoTWF0dCkKPj4KPj4gQnVnemlsbGE6IGh0dHBzOi8vYnVnemls bGEua2VybmVsLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTQ0MzEKPj4gQ2M6IEplc3NlIEJhcm5lcyA8 amJhcm5lc0B2aXJ0dW91c2dlZWsub3JnPgo+PiBTaWduZWQtb2ZmLWJ5OiBBbmRlciBDb25zZWx2 YW4gZGUgT2xpdmVpcmEgPGFuZGVyLmNvbnNlbHZhbi5kZS5vbGl2ZWlyYUBpbnRlbC5jb20+Cj4+ IFJldmlld2VkLWJ5OiBNYXR0IFJvcGVyIDxtYXR0aGV3LmQucm9wZXJAaW50ZWwuY29tPgo+Cj4g QWxsIHRocmVlIHBhdGNoZXMgYXBwbGllZCB0byBkcm0taW50ZWwtbmV4dC1maXhlcywgYWltaW5n IGZvciB2NC4yIG1lcmdlCj4gd2luZG93LiBUaGFua3MgZm9yIHRoZSBwYXRjaGVzIGFuZCByZXZp ZXcuCj4KPiBGb3IgZHJtLWludGVsLW5pZ2h0bHksIEkgcmVzb2x2ZWQgdGhlIGNvbmZsaWN0cyBi eSBpZ25vcmluZyB0aGVzZQo+IGNoYW5nZXMgYW5kIGZhdm9yaW5nIHdoYXQncyBpbiBkcm0taW50 ZWwtbmV4dC1xdWV1ZWQuIEZpbmdlcnMgY3Jvc3NlZCBJCj4gZGlkbid0IGJvdGNoIGl0IHVwIQoK QWxzbywgZG8gd2UgbmVlZCBzb21lIG9mIHRoZXNlIGluIHY0LjEgb3IgZWFybGllciBhcyB3ZWxs PyBTaG91bGQgd2UKYmFja3BvcnQgb25jZSB0aGVzZSBhcmUgdXBzdHJlYW0/CgpCUiwKSmFuaS4K CgoKCgo+Cj4gQlIsCj4gSmFuaS4KPgo+Cj4KPj4gLS0tCj4+ICBkcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9kaXNwbGF5LmMgfCAyMSArKysrKysrKysrKystLS0tLS0tLS0KPj4gIDEgZmlsZSBj aGFuZ2VkLCAxMiBpbnNlcnRpb25zKCspLCA5IGRlbGV0aW9ucygtKQo+Pgo+PiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfZGlzcGxheS5jCj4+IGluZGV4IDRlM2YzMDIuLmJjZjEwNDEgMTAwNjQ0Cj4+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+PiArKysgYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPj4gQEAgLTg3LDcgKzg3LDggQEAgc3Rh dGljIHZvaWQgaXJvbmxha2VfcGNoX2Nsb2NrX2dldChzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YywK Pj4gIAkJCQkgICBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqcGlwZV9jb25maWcpOwo+PiAgCj4+ ICBzdGF0aWMgaW50IGludGVsX3NldF9tb2RlKHN0cnVjdCBkcm1fY3J0YyAqY3J0YywKPj4gLQkJ CSAgc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlKTsKPj4gKwkJCSAgc3RydWN0IGRybV9h dG9taWNfc3RhdGUgKnN0YXRlLAo+PiArCQkJICBib29sIGZvcmNlX3Jlc3RvcmUpOwo+PiAgc3Rh dGljIGludCBpbnRlbF9mcmFtZWJ1ZmZlcl9pbml0KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4+ ICAJCQkJICBzdHJ1Y3QgaW50ZWxfZnJhbWVidWZmZXIgKmlmYiwKPj4gIAkJCQkgIHN0cnVjdCBk cm1fbW9kZV9mYl9jbWQyICptb2RlX2NtZCwKPj4gQEAgLTEwMDk2LDcgKzEwMDk3LDcgQEAgcmV0 cnk6Cj4+ICAKPj4gIAlkcm1fbW9kZV9jb3B5KCZjcnRjX3N0YXRlLT5iYXNlLm1vZGUsIG1vZGUp Owo+PiAgCj4+IC0JaWYgKGludGVsX3NldF9tb2RlKGNydGMsIHN0YXRlKSkgewo+PiArCWlmIChp bnRlbF9zZXRfbW9kZShjcnRjLCBzdGF0ZSwgdHJ1ZSkpIHsKPj4gIAkJRFJNX0RFQlVHX0tNUygi ZmFpbGVkIHRvIHNldCBtb2RlIG9uIGxvYWQtZGV0ZWN0IHBpcGVcbiIpOwo+PiAgCQlpZiAob2xk LT5yZWxlYXNlX2ZiKQo+PiAgCQkJb2xkLT5yZWxlYXNlX2ZiLT5mdW5jcy0+ZGVzdHJveShvbGQt PnJlbGVhc2VfZmIpOwo+PiBAQCAtMTAxNzAsNyArMTAxNzEsNyBAQCB2b2lkIGludGVsX3JlbGVh c2VfbG9hZF9kZXRlY3RfcGlwZShzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yLAo+PiAg CQlpZiAocmV0KQo+PiAgCQkJZ290byBmYWlsOwo+PiAgCj4+IC0JCXJldCA9IGludGVsX3NldF9t b2RlKGNydGMsIHN0YXRlKTsKPj4gKwkJcmV0ID0gaW50ZWxfc2V0X21vZGUoY3J0Yywgc3RhdGUs IHRydWUpOwo+PiAgCQlpZiAocmV0KQo+PiAgCQkJZ290byBmYWlsOwo+PiAgCj4+IEBAIC0xMjY0 NiwyMCArMTI2NDcsMjIgQEAgc3RhdGljIGludCBfX2ludGVsX3NldF9tb2RlKHN0cnVjdCBkcm1f Y3J0YyAqbW9kZXNldF9jcnRjLAo+PiAgfQo+PiAgCj4+ICBzdGF0aWMgaW50IGludGVsX3NldF9t b2RlX3dpdGhfY29uZmlnKHN0cnVjdCBkcm1fY3J0YyAqY3J0YywKPj4gLQkJCQkgICAgICBzdHJ1 Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqcGlwZV9jb25maWcpCj4+ICsJCQkJICAgICAgc3RydWN0IGlu dGVsX2NydGNfc3RhdGUgKnBpcGVfY29uZmlnLAo+PiArCQkJCSAgICAgIGJvb2wgZm9yY2VfcmVz dG9yZSkKPj4gIHsKPj4gIAlpbnQgcmV0Owo+PiAgCj4+ICAJcmV0ID0gX19pbnRlbF9zZXRfbW9k ZShjcnRjLCBwaXBlX2NvbmZpZyk7Cj4+ICAKPj4gLQlpZiAocmV0ID09IDApCj4+ICsJaWYgKHJl dCA9PSAwICYmIGZvcmNlX3Jlc3RvcmUpCj4+ICAJCWludGVsX21vZGVzZXRfY2hlY2tfc3RhdGUo Y3J0Yy0+ZGV2KTsKPj4gIAo+PiAgCXJldHVybiByZXQ7Cj4+ICB9Cj4+ICAKPj4gIHN0YXRpYyBp bnQgaW50ZWxfc2V0X21vZGUoc3RydWN0IGRybV9jcnRjICpjcnRjLAo+PiAtCQkJICBzdHJ1Y3Qg ZHJtX2F0b21pY19zdGF0ZSAqc3RhdGUpCj4+ICsJCQkgIHN0cnVjdCBkcm1fYXRvbWljX3N0YXRl ICpzdGF0ZSwKPj4gKwkJCSAgYm9vbCBmb3JjZV9yZXN0b3JlKQo+PiAgewo+PiAgCXN0cnVjdCBp bnRlbF9jcnRjX3N0YXRlICpwaXBlX2NvbmZpZzsKPj4gIAlpbnQgcmV0ID0gMDsKPj4gQEAgLTEy NjcwLDcgKzEyNjczLDcgQEAgc3RhdGljIGludCBpbnRlbF9zZXRfbW9kZShzdHJ1Y3QgZHJtX2Ny dGMgKmNydGMsCj4+ICAJCWdvdG8gb3V0Owo+PiAgCX0KPj4gIAo+PiAtCXJldCA9IGludGVsX3Nl dF9tb2RlX3dpdGhfY29uZmlnKGNydGMsIHBpcGVfY29uZmlnKTsKPj4gKwlyZXQgPSBpbnRlbF9z ZXRfbW9kZV93aXRoX2NvbmZpZyhjcnRjLCBwaXBlX2NvbmZpZywgZm9yY2VfcmVzdG9yZSk7Cj4+ ICAJaWYgKHJldCkKPj4gIAkJZ290byBvdXQ7Cj4+ICAKPj4gQEAgLTEyNzQ3LDcgKzEyNzUwLDcg QEAgdm9pZCBpbnRlbF9jcnRjX3Jlc3RvcmVfbW9kZShzdHJ1Y3QgZHJtX2NydGMgKmNydGMpCj4+ ICAJaW50ZWxfbW9kZXNldF9zZXR1cF9wbGFuZV9zdGF0ZShzdGF0ZSwgY3J0YywgJmNydGMtPm1v ZGUsCj4+ICAJCQkJCWNydGMtPnByaW1hcnktPmZiLCBjcnRjLT54LCBjcnRjLT55KTsKPj4gIAo+ PiAtCXJldCA9IGludGVsX3NldF9tb2RlKGNydGMsIHN0YXRlKTsKPj4gKwlyZXQgPSBpbnRlbF9z ZXRfbW9kZShjcnRjLCBzdGF0ZSwgZmFsc2UpOwo+PiAgCWlmIChyZXQpCj4+ICAJCWRybV9hdG9t aWNfc3RhdGVfZnJlZShzdGF0ZSk7Cj4+ICB9Cj4+IEBAIC0xMjk0Nyw3ICsxMjk1MCw3IEBAIHN0 YXRpYyBpbnQgaW50ZWxfY3J0Y19zZXRfY29uZmlnKHN0cnVjdCBkcm1fbW9kZV9zZXQgKnNldCkK Pj4gIAo+PiAgCXByaW1hcnlfcGxhbmVfd2FzX3Zpc2libGUgPSBwcmltYXJ5X3BsYW5lX3Zpc2li bGUoc2V0LT5jcnRjKTsKPj4gIAo+PiAtCXJldCA9IGludGVsX3NldF9tb2RlX3dpdGhfY29uZmln KHNldC0+Y3J0YywgcGlwZV9jb25maWcpOwo+PiArCXJldCA9IGludGVsX3NldF9tb2RlX3dpdGhf Y29uZmlnKHNldC0+Y3J0YywgcGlwZV9jb25maWcsIHRydWUpOwo+PiAgCj4+ICAJaWYgKHJldCA9 PSAwICYmCj4+ICAJICAgIHBpcGVfY29uZmlnLT5iYXNlLmVuYWJsZSAmJgo+PiAtLSAKPj4gMi4x LjAKPj4KPj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K Pj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+PiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCj4+IGh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRl bC1nZngKPgo+IC0tIAo+IEphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5 IENlbnRlcgoKLS0gCkphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5IENl bnRlcgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRl bC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=