[PATCH] drm/i915: Correct the variable holding the value for EOT to write

[PATCH] drm/i915: Correct the variable holding the value for EOT to write

[Shobhit Kumar]

This isuue got introduced in -

commit 24ee0e64909bf7f1953d87d3e1e29d93eafcad73
Author: Gaurav K Singh <gaurav.k.singh@intel.com>
Date:   Fri Dec 5 14:24:21 2014 +0530

    drm/i915: Update the DSI enable path to support dual

Signed-off-by: Shobhit Kumar <shobhit.kumar@intel.com>
---
 drivers/gpu/drm/i915/intel_dsi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_dsi.c b/drivers/gpu/drm/i915/intel_dsi.c
index ef3df5e..6ce9c45 100644
--- a/drivers/gpu/drm/i915/intel_dsi.c
+++ b/drivers/gpu/drm/i915/intel_dsi.c
@@ -855,7 +855,7 @@ static void intel_dsi_prepare(struct intel_encoder *intel_encoder)
 
 
 		/* recovery disables */
-		I915_WRITE(MIPI_EOT_DISABLE(port), val);
+		I915_WRITE(MIPI_EOT_DISABLE(port), tmp);
 
 		/* in terms of low power clock */
 		I915_WRITE(MIPI_INIT_COUNT(port), intel_dsi->init_count);
-- 
2.1.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915: Correct the variable holding the value for EOT to write

[shuang.he]

Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang.he@intel.com)
Task id: 5700
-------------------------------------Summary-------------------------------------
Platform          Delta          drm-intel-nightly          Series Applied
PNV                                  283/283              283/283
ILK                                  319/319              319/319
SNB                                  322/346              322/346
IVB              +2                 382/384              384/384
BYT                                  296/296              296/296
HSW              +1                 425/428              426/428
BDW                 -1              319/333              318/333
-------------------------------------Detailed-------------------------------------
Platform  Test                                drm-intel-nightly          Series Applied
 IVB  igt_gem_pwrite_pread_snooped-pwrite-blt-cpu_mmap-performance      DMESG_WARN(10, M34M21)PASS(10, M4M34)      PASS(1, M34)
 IVB  igt_gem_storedw_batches_loop_normal      DMESG_WARN(7, M34M4M21)PASS(19, M34M4M21)      PASS(1, M34)
 HSW  igt_gem_pwrite_pread_snooped-pwrite-blt-cpu_mmap-performance      DMESG_WARN(2, M40)PASS(24, M40M20)      PASS(1, M40)
*BDW  igt_gem_fence_thrash_bo-write-verify-threaded-none      PASS(2, M30)      DMESG_WARN(1, M30)
Note: You need to pay more attention to line start with '*'
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915: Correct the variable holding the value for EOT to write

[Jani Nikula]

On Tue, 03 Feb 2015, Shobhit Kumar <shobhit.kumar@intel.com> wrote:
> This isuue got introduced in -
>
> commit 24ee0e64909bf7f1953d87d3e1e29d93eafcad73
> Author: Gaurav K Singh <gaurav.k.singh@intel.com>
> Date:   Fri Dec 5 14:24:21 2014 +0530
>
>     drm/i915: Update the DSI enable path to support dual
>
> Signed-off-by: Shobhit Kumar <shobhit.kumar@intel.com>

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

> ---
>  drivers/gpu/drm/i915/intel_dsi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dsi.c b/drivers/gpu/drm/i915/intel_dsi.c
> index ef3df5e..6ce9c45 100644
> --- a/drivers/gpu/drm/i915/intel_dsi.c
> +++ b/drivers/gpu/drm/i915/intel_dsi.c
> @@ -855,7 +855,7 @@ static void intel_dsi_prepare(struct intel_encoder *intel_encoder)
>  
>  
>  		/* recovery disables */
> -		I915_WRITE(MIPI_EOT_DISABLE(port), val);
> +		I915_WRITE(MIPI_EOT_DISABLE(port), tmp);
>  
>  		/* in terms of low power clock */
>  		I915_WRITE(MIPI_INIT_COUNT(port), intel_dsi->init_count);
> -- 
> 2.1.0
>

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915: Correct the variable holding the value for EOT to write

[Daniel Vetter]

On Tue, Feb 03, 2015 at 04:40:42PM +0200, Jani Nikula wrote:
> On Tue, 03 Feb 2015, Shobhit Kumar <shobhit.kumar@intel.com> wrote:
> > This isuue got introduced in -
> >
> > commit 24ee0e64909bf7f1953d87d3e1e29d93eafcad73
> > Author: Gaurav K Singh <gaurav.k.singh@intel.com>
> > Date:   Fri Dec 5 14:24:21 2014 +0530
> >
> >     drm/i915: Update the DSI enable path to support dual
> >
> > Signed-off-by: Shobhit Kumar <shobhit.kumar@intel.com>
> 
> Reviewed-by: Jani Nikula <jani.nikula@intel.com>

Queued for -next, thanks for the patch.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx