From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm/i915: Use BUILD_BUG if possible in the i915 WARN_ON Date: Thu, 11 Dec 2014 10:11:59 +0200 Message-ID: <87r3w68v1s.fsf@intel.com> References: <1418054794-5427-1-git-send-email-daniel.vetter@ffwll.ch> <1418230056-32241-1-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 6C9BE6E7A2 for ; Thu, 11 Dec 2014 00:11:47 -0800 (PST) In-Reply-To: <1418230056-32241-1-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Intel Graphics Development Cc: Daniel Vetter , Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCAxMCBEZWMgMjAxNCwgRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5j aD4gd3JvdGU6Cj4gRmFzdGVyIGZlZWRiYWNrIHRvIGVycm9ycyBpcyBhbHdheXMgYmV0dGVyLiBU aGlzIGlzIGluc3BpcmVkIGJ5IHRoZQo+IGFkZGl0aW9uIHRvIFdBUk5fT05zIHRvIG1hc2svZW5h YmxlIGhlbHBlcnMgZm9yIHJlZ2lzdGVycyB0byBtYWtlIHN1cmUKPiBjYWxsZXJzIGhhdmUgdGhl IGFyZ3VtZW50cyBvcmRlcmVkIGNvcnJlY3RseTogUHJldHR5IG11Y2ggYWx3YXlzIHRoZQo+IGFy Z3VtZW50cyBhcmUgc3RhdGljLgo+Cj4gV2UgdXNlIFdBUk5fT04oMSkgYSBsb3QgaW4gZGVmYXVs dCBzd2l0Y2ggc3RhdGVtZW50cyB0aG91Z2ggd2hlcmUgd2UKPiBzaG91bGQgYWx3YXlzIGhhbmRs ZSBhbGwgY2FzZXMuIFNvIGFkZCBhIG5ldyBtYWNybyBzcGVjaWZpY2FsbHkgZm9yCj4gdGhhdC4K Pgo+IFRoZSBpZGVhIHRvIHVzZSBfX2J1aWx0aW5fY29uc3RhbnRfcCBpcyBmcm9tIENocmlzIFdp bHNvbi4KPgo+IHYyOiBVc2UgdGhlICh7fSkgZ2NjLWlzbSB0byBhdm9pZCB0aGUgc3RhdGljIGlu bGluZSwgc3VnZ2VzdGVkIGJ5Cj4gRGF2ZS4gTXkgZmlyc3QgYXR0ZW1wdCB1c2VkIF9fY29uZCBh cyB0aGUgdGVtcCB2YXIsIHdoaWNoIGlzIHRoZSBzYW1lCj4gdXNlZCBieSBCVUlMRF9CVUdfT04s IGJ1dCB3aXRoIGludmVydGVkIHNlbnNlLiBIaWxhcml0eSBlbnN1ZWQsIHNvCj4gc3ByaW5rbGUg aTkxNSBpbnRvIHRoZSBuYW1lLgo+Cj4gQWxzbyB1c2UgYSB0ZW1wb3JhcnkgdmFyaWFibGUgdG8g b25seSBldmFsdWF0ZSB0aGUgY29uZGl0aW9uIG9uY2UsCj4gc3VnZ2VzdGVkIGJ5IERhbWllbi4K Pgo+IHYzOiBJdCdzIGNyYXp5IGJ1dCBhcHBhcmVudGx5IDMyYml0IGdjYyBjYW4ndCBjb21waWxl IG91dCB0aGUKPiBCVUlMRF9CVUdfT04gaW4gYSBsb3Qgb2YgY2FzZXMgYW5kIGp1c3QgZmFsbHMg b3Zlci4gSSBoYXZlIG5vIGlkZWEKPiB3aHksIGJ1dCB1bnRpbCBjbHVlIGdyb3dzIGp1c3QgZGlz YWJsZSB0aGlzIG5pZnR5IGlkZWEgb24gMzJiaXQKPiBidWlsZHMuIFJlcG9ydGVkIGJ5IDAtZGF5 IGJ1aWxkZXIuCj4KPiB2NDogR290IGl0IGFsbCB3cm9uZywgYXBwYXJlbnRseSBpdHMgdGhlIGdj YyB2ZXJzaW9uLiBXZSBuZWVkIDQuOSsuCj4gTm93IHJlcG9ydGVkIGJ5IEltcmUuCj4KPiB2NTog Q2hyaXMgc3VnZ2VzdGVkIHRvIGFkZCB0aGUgY2FzZSB0byBNSVNTSU5HX0NBU0UgZm9yIHNwZWVk aWVyCj4gZGVidWcuCgpTdGlsbCBmYWlscyBoZXJlLiA6KAoKJCBnY2MgLS12ZXJzaW9uCmdjYyAo RGViaWFuIDQuOS4xLTE5KSA0LjkuMQoKJCBtYWtlCiAgQ0hLICAgICBpbmNsdWRlL2NvbmZpZy9r ZXJuZWwucmVsZWFzZQogIENISyAgICAgaW5jbHVkZS9nZW5lcmF0ZWQvdWFwaS9saW51eC92ZXJz aW9uLmgKICBDSEsgICAgIGluY2x1ZGUvZ2VuZXJhdGVkL3V0c3JlbGVhc2UuaAogIENBTEwgICAg c2NyaXB0cy9jaGVja3N5c2NhbGxzLnNoCiAgQ0hLICAgICBpbmNsdWRlL2dlbmVyYXRlZC9jb21w aWxlLmgKICBDSEsgICAgIGtlcm5lbC9jb25maWdfZGF0YS5oCiAgQ0MgW01dICBkcml2ZXJzL2dw dS9kcm0vaTkxNS9pOTE1X2Rydi5vCkluIGZpbGUgaW5jbHVkZWQgZnJvbSBpbmNsdWRlL2xpbnV4 L2lvcG9ydC5oOjEyOjAsCiAgICAgICAgICAgICAgICAgZnJvbSBpbmNsdWRlL2xpbnV4L2Rldmlj ZS5oOjE2LAogICAgICAgICAgICAgICAgIGZyb20gZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9k cnYuYzozMDoKZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuYzogSW4gZnVuY3Rpb24g4oCY aW50ZWxfZGV0ZWN0X3BjaOKAmToKaW5jbHVkZS9saW51eC9jb21waWxlci5oOjM2MzozODogZXJy b3I6IGNhbGwgdG8g4oCYX19jb21waWxldGltZV9hc3NlcnRfNDc34oCZIGRlY2xhcmVkIHdpdGgg YXR0cmlidXRlIGVycm9yOiBCVUlMRF9CVUdfT04gZmFpbGVkOiBfX2k5MTVfd2Fybl9jb25kCiAg X2NvbXBpbGV0aW1lX2Fzc2VydChjb25kaXRpb24sIG1zZywgX19jb21waWxldGltZV9hc3NlcnRf LCBfX0xJTkVfXykKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBeCmluY2x1 ZGUvbGludXgvY29tcGlsZXIuaDozNDY6NDogbm90ZTogaW4gZGVmaW5pdGlvbiBvZiBtYWNybyDi gJhfX2NvbXBpbGV0aW1lX2Fzc2VydOKAmQogICAgcHJlZml4ICMjIHN1ZmZpeCgpOyAgICBcCiAg ICBeCmluY2x1ZGUvbGludXgvY29tcGlsZXIuaDozNjM6Mjogbm90ZTogaW4gZXhwYW5zaW9uIG9m IG1hY3JvIOKAmF9jb21waWxldGltZV9hc3NlcnTigJkKICBfY29tcGlsZXRpbWVfYXNzZXJ0KGNv bmRpdGlvbiwgbXNnLCBfX2NvbXBpbGV0aW1lX2Fzc2VydF8sIF9fTElORV9fKQogIF4KaW5jbHVk ZS9saW51eC9idWcuaDo1MDozNzogbm90ZTogaW4gZXhwYW5zaW9uIG9mIG1hY3JvIOKAmGNvbXBp bGV0aW1lX2Fzc2VydOKAmQogI2RlZmluZSBCVUlMRF9CVUdfT05fTVNHKGNvbmQsIG1zZykgY29t cGlsZXRpbWVfYXNzZXJ0KCEoY29uZCksIG1zZykKICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIF4KaW5jbHVkZS9saW51eC9idWcuaDo3NDoyOiBub3RlOiBpbiBleHBhbnNpb24g b2YgbWFjcm8g4oCYQlVJTERfQlVHX09OX01TR+KAmQogIEJVSUxEX0JVR19PTl9NU0coY29uZGl0 aW9uLCAiQlVJTERfQlVHX09OIGZhaWxlZDogIiAjY29uZGl0aW9uKQogIF4KZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV9kcnYuaDo2NjozOiBub3RlOiBpbiBleHBhbnNpb24gb2YgbWFjcm8g4oCY QlVJTERfQlVHX09O4oCZCiAgIEJVSUxEX0JVR19PTihfX2k5MTVfd2Fybl9jb25kKTsgXAogICBe CmRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmM6NDc3OjU6IG5vdGU6IGluIGV4cGFuc2lv biBvZiBtYWNybyDigJhXQVJOX09O4oCZCiAgICAgV0FSTl9PTighSVNfSFNXX1VMVChkZXYpKTsK ICAgICBeCmluY2x1ZGUvbGludXgvY29tcGlsZXIuaDozNjM6Mzg6IGVycm9yOiBjYWxsIHRvIOKA mF9fY29tcGlsZXRpbWVfYXNzZXJ0XzQ1NuKAmSBkZWNsYXJlZCB3aXRoIGF0dHJpYnV0ZSBlcnJv cjogQlVJTERfQlVHX09OIGZhaWxlZDogX19pOTE1X3dhcm5fY29uZAogIF9jb21waWxldGltZV9h c3NlcnQoY29uZGl0aW9uLCBtc2csIF9fY29tcGlsZXRpbWVfYXNzZXJ0XywgX19MSU5FX18pCiAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXgppbmNsdWRlL2xpbnV4L2NvbXBp bGVyLmg6MzQ2OjQ6IG5vdGU6IGluIGRlZmluaXRpb24gb2YgbWFjcm8g4oCYX19jb21waWxldGlt ZV9hc3NlcnTigJkKICAgIHByZWZpeCAjIyBzdWZmaXgoKTsgICAgXAogICAgXgppbmNsdWRlL2xp bnV4L2NvbXBpbGVyLmg6MzYzOjI6IG5vdGU6IGluIGV4cGFuc2lvbiBvZiBtYWNybyDigJhfY29t cGlsZXRpbWVfYXNzZXJ04oCZCiAgX2NvbXBpbGV0aW1lX2Fzc2VydChjb25kaXRpb24sIG1zZywg X19jb21waWxldGltZV9hc3NlcnRfLCBfX0xJTkVfXykKICBeCmluY2x1ZGUvbGludXgvYnVnLmg6 NTA6Mzc6IG5vdGU6IGluIGV4cGFuc2lvbiBvZiBtYWNybyDigJhjb21waWxldGltZV9hc3NlcnTi gJkKICNkZWZpbmUgQlVJTERfQlVHX09OX01TRyhjb25kLCBtc2cpIGNvbXBpbGV0aW1lX2Fzc2Vy dCghKGNvbmQpLCBtc2cpCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBeCmlu Y2x1ZGUvbGludXgvYnVnLmg6NzQ6Mjogbm90ZTogaW4gZXhwYW5zaW9uIG9mIG1hY3JvIOKAmEJV SUxEX0JVR19PTl9NU0figJkKICBCVUlMRF9CVUdfT05fTVNHKGNvbmRpdGlvbiwgIkJVSUxEX0JV R19PTiBmYWlsZWQ6ICIgI2NvbmRpdGlvbikKICBeCmRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf ZHJ2Lmg6NjY6Mzogbm90ZTogaW4gZXhwYW5zaW9uIG9mIG1hY3JvIOKAmEJVSUxEX0JVR19PTuKA mQogICBCVUlMRF9CVUdfT04oX19pOTE1X3dhcm5fY29uZCk7IFwKICAgXgpkcml2ZXJzL2dwdS9k cm0vaTkxNS9pOTE1X2Rydi5jOjQ1Njo1OiBub3RlOiBpbiBleHBhbnNpb24gb2YgbWFjcm8g4oCY V0FSTl9PTuKAmQogICAgIFdBUk5fT04oIShJU19HRU42KGRldikgfHwgSVNfSVZZQlJJREdFKGRl dikpKTsKICAgICBeCmluY2x1ZGUvbGludXgvY29tcGlsZXIuaDozNjM6Mzg6IGVycm9yOiBjYWxs IHRvIOKAmF9fY29tcGlsZXRpbWVfYXNzZXJ0XzQ2MeKAmSBkZWNsYXJlZCB3aXRoIGF0dHJpYnV0 ZSBlcnJvcjogQlVJTERfQlVHX09OIGZhaWxlZDogX19pOTE1X3dhcm5fY29uZAogIF9jb21waWxl dGltZV9hc3NlcnQoY29uZGl0aW9uLCBtc2csIF9fY29tcGlsZXRpbWVfYXNzZXJ0XywgX19MSU5F X18pCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXgppbmNsdWRlL2xpbnV4 L2NvbXBpbGVyLmg6MzQ2OjQ6IG5vdGU6IGluIGRlZmluaXRpb24gb2YgbWFjcm8g4oCYX19jb21w aWxldGltZV9hc3NlcnTigJkKICAgIHByZWZpeCAjIyBzdWZmaXgoKTsgICAgXAogICAgXgppbmNs dWRlL2xpbnV4L2NvbXBpbGVyLmg6MzYzOjI6IG5vdGU6IGluIGV4cGFuc2lvbiBvZiBtYWNybyDi gJhfY29tcGlsZXRpbWVfYXNzZXJ04oCZCiAgX2NvbXBpbGV0aW1lX2Fzc2VydChjb25kaXRpb24s IG1zZywgX19jb21waWxldGltZV9hc3NlcnRfLCBfX0xJTkVfXykKICBeCmluY2x1ZGUvbGludXgv YnVnLmg6NTA6Mzc6IG5vdGU6IGluIGV4cGFuc2lvbiBvZiBtYWNybyDigJhjb21waWxldGltZV9h c3NlcnTigJkKICNkZWZpbmUgQlVJTERfQlVHX09OX01TRyhjb25kLCBtc2cpIGNvbXBpbGV0aW1l X2Fzc2VydCghKGNvbmQpLCBtc2cpCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBeCmluY2x1ZGUvbGludXgvYnVnLmg6NzQ6Mjogbm90ZTogaW4gZXhwYW5zaW9uIG9mIG1hY3Jv IOKAmEJVSUxEX0JVR19PTl9NU0figJkKICBCVUlMRF9CVUdfT05fTVNHKGNvbmRpdGlvbiwgIkJV SUxEX0JVR19PTiBmYWlsZWQ6ICIgI2NvbmRpdGlvbikKICBeCmRyaXZlcnMvZ3B1L2RybS9pOTE1 L2k5MTVfZHJ2Lmg6NjY6Mzogbm90ZTogaW4gZXhwYW5zaW9uIG9mIG1hY3JvIOKAmEJVSUxEX0JV R19PTuKAmQogICBCVUlMRF9CVUdfT04oX19pOTE1X3dhcm5fY29uZCk7IFwKICAgXgpkcml2ZXJz L2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5jOjQ2MTo1OiBub3RlOiBpbiBleHBhbnNpb24gb2YgbWFj cm8g4oCYV0FSTl9PTuKAmQogICAgIFdBUk5fT04oIShJU19HRU42KGRldikgfHwgSVNfSVZZQlJJ REdFKGRldikpKTsKICAgICBeCmluY2x1ZGUvbGludXgvY29tcGlsZXIuaDozNjM6Mzg6IGVycm9y OiBjYWxsIHRvIOKAmF9fY29tcGlsZXRpbWVfYXNzZXJ0XzQ2NuKAmSBkZWNsYXJlZCB3aXRoIGF0 dHJpYnV0ZSBlcnJvcjogQlVJTERfQlVHX09OIGZhaWxlZDogX19pOTE1X3dhcm5fY29uZAogIF9j b21waWxldGltZV9hc3NlcnQoY29uZGl0aW9uLCBtc2csIF9fY29tcGlsZXRpbWVfYXNzZXJ0Xywg X19MSU5FX18pCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXgppbmNsdWRl L2xpbnV4L2NvbXBpbGVyLmg6MzQ2OjQ6IG5vdGU6IGluIGRlZmluaXRpb24gb2YgbWFjcm8g4oCY X19jb21waWxldGltZV9hc3NlcnTigJkKICAgIHByZWZpeCAjIyBzdWZmaXgoKTsgICAgXAogICAg XgppbmNsdWRlL2xpbnV4L2NvbXBpbGVyLmg6MzYzOjI6IG5vdGU6IGluIGV4cGFuc2lvbiBvZiBt YWNybyDigJhfY29tcGlsZXRpbWVfYXNzZXJ04oCZCiAgX2NvbXBpbGV0aW1lX2Fzc2VydChjb25k aXRpb24sIG1zZywgX19jb21waWxldGltZV9hc3NlcnRfLCBfX0xJTkVfXykKICBeCmluY2x1ZGUv bGludXgvYnVnLmg6NTA6Mzc6IG5vdGU6IGluIGV4cGFuc2lvbiBvZiBtYWNybyDigJhjb21waWxl dGltZV9hc3NlcnTigJkKICNkZWZpbmUgQlVJTERfQlVHX09OX01TRyhjb25kLCBtc2cpIGNvbXBp bGV0aW1lX2Fzc2VydCghKGNvbmQpLCBtc2cpCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBeCmluY2x1ZGUvbGludXgvYnVnLmg6NzQ6Mjogbm90ZTogaW4gZXhwYW5zaW9uIG9m IG1hY3JvIOKAmEJVSUxEX0JVR19PTl9NU0figJkKICBCVUlMRF9CVUdfT05fTVNHKGNvbmRpdGlv biwgIkJVSUxEX0JVR19PTiBmYWlsZWQ6ICIgI2NvbmRpdGlvbikKICBeCmRyaXZlcnMvZ3B1L2Ry bS9pOTE1L2k5MTVfZHJ2Lmg6NjY6Mzogbm90ZTogaW4gZXhwYW5zaW9uIG9mIG1hY3JvIOKAmEJV SUxEX0JVR19PTuKAmQogICBCVUlMRF9CVUdfT04oX19pOTE1X3dhcm5fY29uZCk7IFwKICAgXgpk cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5jOjQ2Njo1OiBub3RlOiBpbiBleHBhbnNpb24g b2YgbWFjcm8g4oCYV0FSTl9PTuKAmQogICAgIFdBUk5fT04oSVNfSFNXX1VMVChkZXYpKTsKICAg ICBeCnNjcmlwdHMvTWFrZWZpbGUuYnVpbGQ6MjU3OiByZWNpcGUgZm9yIHRhcmdldCAnZHJpdmVy cy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYubycgZmFpbGVkCm1ha2VbNF06ICoqKiBbZHJpdmVycy9n cHUvZHJtL2k5MTUvaTkxNV9kcnYub10gRXJyb3IgMQpzY3JpcHRzL01ha2VmaWxlLmJ1aWxkOjQw MjogcmVjaXBlIGZvciB0YXJnZXQgJ2RyaXZlcnMvZ3B1L2RybS9pOTE1JyBmYWlsZWQKbWFrZVsz XTogKioqIFtkcml2ZXJzL2dwdS9kcm0vaTkxNV0gRXJyb3IgMgpzY3JpcHRzL01ha2VmaWxlLmJ1 aWxkOjQwMjogcmVjaXBlIGZvciB0YXJnZXQgJ2RyaXZlcnMvZ3B1L2RybScgZmFpbGVkCm1ha2Vb Ml06ICoqKiBbZHJpdmVycy9ncHUvZHJtXSBFcnJvciAyCnNjcmlwdHMvTWFrZWZpbGUuYnVpbGQ6 NDAyOiByZWNpcGUgZm9yIHRhcmdldCAnZHJpdmVycy9ncHUnIGZhaWxlZAptYWtlWzFdOiAqKiog W2RyaXZlcnMvZ3B1XSBFcnJvciAyCk1ha2VmaWxlOjkzNzogcmVjaXBlIGZvciB0YXJnZXQgJ2Ry aXZlcnMnIGZhaWxlZAptYWtlOiAqKiogW2RyaXZlcnNdIEVycm9yIDIKCgotLSAKSmFuaSBOaWt1 bGEsIEludGVsIE9wZW4gU291cmNlIFRlY2hub2xvZ3kgQ2VudGVyCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50 ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==