From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jani Nikula <jani.nikula@linux.intel.com>
Subject: Re: [PATCH 30/89] drm/i915/skl: SKL backlight enabling
Date: Wed, 17 Sep 2014 12:09:53 +0300
Message-ID: <87r3zavcim.fsf@intel.com>
References: <1409830075-11139-1-git-send-email-damien.lespiau@intel.com>
 <1409830075-11139-31-git-send-email-damien.lespiau@intel.com>
 <CABVU7+vhMQ3Z4urO-8pUeJJ4JMYU-B9TCasCF1=Vk1QazijbRw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by gabe.freedesktop.org (Postfix) with ESMTP id 83DA66E4DF
 for <intel-gfx@lists.freedesktop.org>; Wed, 17 Sep 2014 02:10:15 -0700 (PDT)
In-Reply-To: <CABVU7+vhMQ3Z4urO-8pUeJJ4JMYU-B9TCasCF1=Vk1QazijbRw@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Rodrigo Vivi <rodrigo.vivi@gmail.com>, Damien Lespiau <damien.lespiau@intel.com>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Wed, 17 Sep 2014, Rodrigo Vivi <rodrigo.vivi@gmail.com> wrote:
> This is wrong.
>
> A skl_enable_backlight must be created setting c8254 propperly without the
> shift 16. Also maybe setting c8354h.

Nope, this is all right for skl/spt, with the small exception that it'll
need the equivalent of [1]. I'll post another version addressing Ville's
comments.

BR,
Jani.


[1] http://mid.gmane.org/87y4tzefmz.fsf@intel.com


>
>
> On Thu, Sep 4, 2014 at 4:26 AM, Damien Lespiau <damien.lespiau@intel.com>
> wrote:
>
>> From: Satheeshakrishna M <satheeshakrishna.m@intel.com>
>>
>> Extending the BDW backlight implementation to SKL.
>>
>> Signed-off-by: Satheeshakrishna M <satheeshakrishna.m@intel.com>
>> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
>> ---
>>  drivers/gpu/drm/i915/intel_panel.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_panel.c
>> b/drivers/gpu/drm/i915/intel_panel.c
>> index 1878447..d69a3cb6 100644
>> --- a/drivers/gpu/drm/i915/intel_panel.c
>> +++ b/drivers/gpu/drm/i915/intel_panel.c
>> @@ -1317,7 +1317,7 @@ void intel_panel_init_backlight_funcs(struct
>> drm_device *dev)
>>  {
>>         struct drm_i915_private *dev_priv = dev->dev_private;
>>
>> -       if (IS_BROADWELL(dev)) {
>> +       if (IS_BROADWELL(dev) || (INTEL_INFO(dev)->gen >= 9)) {
>>                 dev_priv->display.setup_backlight = bdw_setup_backlight;
>>                 dev_priv->display.enable_backlight = bdw_enable_backlight;
>>                 dev_priv->display.disable_backlight =
>> pch_disable_backlight;
>> --
>> 1.8.3.1
>>
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
>>
>
>
>
> -- 
> Rodrigo Vivi
> Blog: http://blog.vivi.eng.br
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Technology Center