From: Jani Nikula <jani.nikula@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Daniel Vetter <daniel.vetter@intel.com>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
stable@vger.kernel.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Fix EIO/wedged handling in gem fault handler
Date: Thu, 04 Sep 2014 14:02:04 +0300 [thread overview]
Message-ID: <87r3zrfy37.fsf@intel.com> (raw)
In-Reply-To: <20140904103125.GI3171@nuc-i3427.alporthouse.com>
On Thu, 04 Sep 2014, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> On Thu, Sep 04, 2014 at 09:36:18AM +0200, Daniel Vetter wrote:
>> In
>>
>> commit 1f83fee08d625f8d0130f9fe5ef7b17c2e022f3c
>> Author: Daniel Vetter <daniel.vetter@ffwll.ch>
>> Date: Thu Nov 15 17:17:22 2012 +0100
>>
>> drm/i915: clear up wedged transitions
>>
>> I've accidentally inverted the EIO/wedged handling in the fault
>> handler: We want to return the EIO as a SIGBUS only if it's not
>> because of the gpu having died, to prevent userspace from unduly
>> dying.
>>
>> In my defence the comment right above is completely misleading, so fix
>> both.
>>
>> v2: Drop the WARN_ON, it's not actually a bug to e.g. receive an -EIO
>> when swap-in fails.
>>
>> v3: Don't remove too much ... oops.
>>
>> Reported-by: Chris Wilson <chris@chris-wilson.co.uk>
>> Cc: Chris Wilson <chris@chris-wilson.co.uk>
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Pushed to drm-intel-fixes, thanks for the patch and review.
BR,
Jani.
> -Chris
>
> --
> Chris Wilson, Intel Open Source Technology Centre
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Technology Center
parent reply other threads:[~2014-09-04 11:02 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20140904103125.GI3171@nuc-i3427.alporthouse.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r3zrfy37.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox