Re: [Intel-gfx] [PATCH] drm/i915: Fix EIO/wedged handling in gem fault handler

Re: [Intel-gfx] [PATCH] drm/i915: Fix EIO/wedged handling in gem fault handler

[Jani Nikula]

On Thu, 04 Sep 2014, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> On Thu, Sep 04, 2014 at 09:36:18AM +0200, Daniel Vetter wrote:
>> In
>> 
>> commit 1f83fee08d625f8d0130f9fe5ef7b17c2e022f3c
>> Author: Daniel Vetter <daniel.vetter@ffwll.ch>
>> Date:   Thu Nov 15 17:17:22 2012 +0100
>> 
>>     drm/i915: clear up wedged transitions
>> 
>> I've accidentally inverted the EIO/wedged handling in the fault
>> handler: We want to return the EIO as a SIGBUS only if it's not
>> because of the gpu having died, to prevent userspace from unduly
>> dying.
>> 
>> In my defence the comment right above is completely misleading, so fix
>> both.
>> 
>> v2: Drop the WARN_ON, it's not actually a bug to e.g. receive an -EIO
>> when swap-in fails.
>> 
>> v3: Don't remove too much ... oops.
>> 
>> Reported-by: Chris Wilson <chris@chris-wilson.co.uk>
>> Cc: Chris Wilson <chris@chris-wilson.co.uk>
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

Pushed to drm-intel-fixes, thanks for the patch and review.

BR,
Jani.


> -Chris
>
> -- 
> Chris Wilson, Intel Open Source Technology Centre
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Technology Center