From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [Intel-gfx] [PATCH] drm/i915: Fix EIO/wedged handling in gem fault handler Date: Thu, 04 Sep 2014 14:02:04 +0300 Message-ID: <87r3zrfy37.fsf@intel.com> References: <1409814683-24470-1-git-send-email-daniel.vetter@ffwll.ch> <1409816178-24849-1-git-send-email-daniel.vetter@ffwll.ch> <20140904103125.GI3171@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: In-Reply-To: <20140904103125.GI3171@nuc-i3427.alporthouse.com> Sender: stable-owner@vger.kernel.org To: Chris Wilson , Daniel Vetter Cc: Daniel Vetter , Intel Graphics Development , stable@vger.kernel.org List-Id: intel-gfx@lists.freedesktop.org On Thu, 04 Sep 2014, Chris Wilson wrote: > On Thu, Sep 04, 2014 at 09:36:18AM +0200, Daniel Vetter wrote: >> In >> >> commit 1f83fee08d625f8d0130f9fe5ef7b17c2e022f3c >> Author: Daniel Vetter >> Date: Thu Nov 15 17:17:22 2012 +0100 >> >> drm/i915: clear up wedged transitions >> >> I've accidentally inverted the EIO/wedged handling in the fault >> handler: We want to return the EIO as a SIGBUS only if it's not >> because of the gpu having died, to prevent userspace from unduly >> dying. >> >> In my defence the comment right above is completely misleading, so fix >> both. >> >> v2: Drop the WARN_ON, it's not actually a bug to e.g. receive an -EIO >> when swap-in fails. >> >> v3: Don't remove too much ... oops. >> >> Reported-by: Chris Wilson >> Cc: Chris Wilson >> Cc: stable@vger.kernel.org >> Signed-off-by: Daniel Vetter > Reviewed-by: Chris Wilson Pushed to drm-intel-fixes, thanks for the patch and review. BR, Jani. > -Chris > > -- > Chris Wilson, Intel Open Source Technology Centre > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Jani Nikula, Intel Open Source Technology Center