From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jani Nikula <jani.nikula@linux.intel.com>
Subject: Re: [PATCH 2/5] drm/i915/dp: Cache EDID for a detection
	cycle
Date: Wed, 03 Sep 2014 13:47:36 +0300
Message-ID: <87r3ztgeuv.fsf@intel.com>
References: <1409684643-1569-1-git-send-email-chris@chris-wilson.co.uk>
 <1409684643-1569-2-git-send-email-chris@chris-wilson.co.uk>
 <87zjehgljm.fsf@intel.com> <20140903085309.GM25238@nuc-i3427.alporthouse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by gabe.freedesktop.org (Postfix) with ESMTP id 4DC486E51A
 for <intel-gfx@lists.freedesktop.org>; Wed,  3 Sep 2014 03:47:39 -0700 (PDT)
In-Reply-To: <20140903085309.GM25238@nuc-i3427.alporthouse.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Wed, 03 Sep 2014, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> On Wed, Sep 03, 2014 at 11:23:09AM +0300, Jani Nikula wrote:
>> On Tue, 02 Sep 2014, Chris Wilson <chris@chris-wilson.co.uk> wrote:
>> > @@ -3819,27 +3819,55 @@ intel_dp_get_edid(struct drm_connector *connector, struct i2c_adapter *adapter)
>> >  			return NULL;
>> >  
>> >  		return drm_edid_duplicate(intel_connector->edid);
>> > -	}
>> > +	} else
>> > +		return drm_get_edid(&intel_connector->base,
>> > +				    &intel_dp->aux.ddc);
>> 
>> Nitpick, I'd like to see braces on all branches if one branch requires
>> them. Also CodingStyle.
>
> It's one instance where CodingStyle doesn't match a dominant pattern in the kernel.
> After all it's a fairly recent addition in 2007 and they haven't won the
> flame war yet.

As I tried to express, it is secondary to me what CodingStyle and
checkpatch.pl say; my personal preference would be to have braces on all
branches if one branch requires them. No use arguing further on
it. Carry on.

BR,
Jani.


> -Chris
>
> -- 
> Chris Wilson, Intel Open Source Technology Centre

-- 
Jani Nikula, Intel Open Source Technology Center