From: Jani Nikula <jani.nikula@linux.intel.com>
To: "Wilde, Martin" <martin.wilde@intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>
Subject: Re: Responsiveness Changes to i915 Driver
Date: Wed, 20 Aug 2014 12:36:50 +0300 [thread overview]
Message-ID: <87r40bmril.fsf@intel.com> (raw)
In-Reply-To: <D0191056.3DC4B%martin.wilde@intel.com>
On Wed, 20 Aug 2014, "Wilde, Martin" <martin.wilde@intel.com> wrote:
> Greetings - after reviewing Chris¹s feedback below and some thought, I
> most likely do not need to add another trace message and the existing
> ³i915_flip_complete² trace message can be used.
>
> Thus the only change requested is to have the T1_T3 value printed out
> during driver init/re-init. Here is the requested change:
>
> diff -rupN src.org/third_party/kernel/3.10/drivers/gpu/drm/i915/intel_dp.c
> src/third_party/kernel/3.10/drivers/gpu/drm/i915/intel_dp.c
> ---
> src.org/third_party/kernel/3.10/drivers/gpu/drm/i915/intel_dp.c 2014-08-14
> 14:24:45.655312785 -0700
> +++ src/third_party/kernel/3.10/drivers/gpu/drm/i915/intel_dp.c 2014-08-14
> 11:57:30.203608374 -0700
> @@ -3528,6 +3528,7 @@ intel_dp_init_panel_power_sequencer(stru
> intel_dp->panel_power_cycle_delay = get_delay(t11_t12);
> #undef get_delay
>
> + printk(KERN_INFO "i915: eDP T3 Value: %d\n",
> intel_dp->panel_power_up_delay);
What's wrong with using the value printed on the next line? This is not
something we'll add INFO level messages for.
BR,
Jani.
> DRM_DEBUG_KMS("panel power up delay %d, power down delay %d, power cycle
> delay %d\n",
> intel_dp->panel_power_up_delay, intel_dp->panel_power_down_delay,
> intel_dp->panel_power_cycle_delay);
>
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2014-08-20 9:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-14 23:52 Responsiveness Changes to i915 Driver Wilde, Martin
2014-08-15 6:26 ` Chris Wilson
2014-08-19 21:33 ` Wilde, Martin
2014-08-20 9:36 ` Jani Nikula [this message]
2014-08-20 18:03 ` Wilde, Martin
2014-08-20 18:12 ` Chris Wilson
2014-08-21 7:26 ` Jani Nikula
2014-08-27 20:33 ` Wilde, Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r40bmril.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=martin.wilde@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox