From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH 1/2] drm/i915: Fix locking for intel_enable_pipe_a() Date: Thu, 14 Aug 2014 17:32:58 +0300 Message-ID: <87r40jp2ed.fsf@intel.com> References: <1407752136-2973-1-git-send-email-ville.syrjala@linux.intel.com> <20140811112956.GM8727@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 788D16E276 for ; Thu, 14 Aug 2014 07:33:05 -0700 (PDT) In-Reply-To: <20140811112956.GM8727@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter , ville.syrjala@linux.intel.com Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCAxMSBBdWcgMjAxNCwgRGFuaWVsIFZldHRlciA8ZGFuaWVsQGZmd2xsLmNoPiB3cm90 ZToKPiBPbiBNb24sIEF1ZyAxMSwgMjAxNCBhdCAwMToxNTozNVBNICswMzAwLCB2aWxsZS5zeXJq YWxhQGxpbnV4LmludGVsLmNvbSB3cm90ZToKPj4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxs ZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPj4gCj4+IGludGVsX2VuYWJsZV9waXBlX2EoKSBn ZXRzIGNhbGxlZCB3aXRoIGFsbCB0aGUgbW9kZXNldCBsb2NrcyBhbHJlYWR5Cj4+IGhlbGQgKGJ5 IGRybV9tb2Rlc2V0X2xvY2tfYWxsKCkpLCBzbyB0cnlpbmcgdG8gZ3JhYiB0aGUgc2FtZQo+PiBs b2NrcyB1c2luZyBhbm90aGVyIGRybV9tb2Rlc2V0X2FjcXVpcmVfY3R4IGlzIGdvaW5nIHRvIGZh aWwgbWlzZXJhYmx5Lgo+PiAKPj4gTW92ZSBtb3N0IG9mIHRoZSBkcm1fbW9kZXNldF9hY3F1aXJl X2N0eCBoYW5kbGluZyAoaW5pdC9kcm9wL2ZpbmkpCj4+IG91dCBmcm9tIGludGVsX3tnZXQscmVs ZWFzZX1fbG9hZF9kZXRlY3RfcGlwZSgpIGludG8gdGhlIGNhbGxlcnMKPj4gKGludGVsX3tjcnQs dHZ9X2RldGVjdCgpKS4gT25seSB0aGUgYWN0dWFsIGxvY2tpbmcgYW5kIGJhY2tvZmYKPj4gaGFu ZGxpbmcgaXMgbGVmdCBpbiBpbnRlbF9nZXRfbG9hZF9kZXRlY3RfcGlwZSgpLiBBbmQgaW4KPj4g aW50ZWxfZW5hYmxlX3BpcGVfYSgpIHdlIGp1c3Qgc2hhcmUgdGhlIG1vZGVfY29uZmlnLmFjcXVp cmVfY3R4IGZyb20KPj4gZHJtX21vZGVzZXRfbG9ja19hbGwoKSB3aGljaCBpcyBhbHJlYWR5IGhv bGRpbmcgYWxsIHRoZSByZWxldmFudCBsb2Nrcy4KPj4gCj4+IEl0J3MgcGVyZmVjdGx5IGxlZ2Fs IHRvIGxvY2sgdGhlIHNhbWUgd3dfbXV0ZXggbXVsdGlwbGUgdGltZXMgdXNpbmcgdGhlCj4+IHNh bWUgd3dfYWNxdWlyZV9jdHguIGRybV9tb2Rlc2V0X2xvY2soKSB3aWxsIGNvbnZlcnQgdGhlIHJl dHVybmVkCj4+IC1FQUxSRUFEWSBpbnRvIDAsIHNvIHRoZSBjYWxsZXIgZG9lc24ndCBuZWVkIHRv IGRvIGFudHloaW5nIHNwZWNpYWwuCj4+IAo+PiBGaXhlcyBhIGhhbmcgb24gcmVzdW1lIG9uIG15 IDgzMC4KPj4gCj4+IFNpZ25lZC1vZmYtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFs YUBsaW51eC5pbnRlbC5jb20+Cj4KPiBSZXZpZXdlZC1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVs LnZldHRlckBmZndsbC5jaD4KPiBDYzogc3RhYmxlQHZnZXIua2VybmVsLm9yZyAoZm9yIDMuMTYp CgpCb3RoIHBhdGNoZXMgcGlja2VkIHVwIGZvciAtZml4ZXMsIHRoYW5rcyBmb3IgdGhlIHBhdGNo ZXMgYW5kIHJldmlldy4KCkJSLApKYW5pLgoKCj4KPj4gLS0tCj4+ICBkcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9jcnQuYyAgICAgfCAgNyArKysrKystCj4+ICBkcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9kaXNwbGF5LmMgfCAyMSArKysrLS0tLS0tLS0tLS0tLS0tLS0KPj4gIGRyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2Rydi5oICAgICB8ICAzICstLQo+PiAgZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfdHYuYyAgICAgIHwgIDcgKysrKysrLQo+PiAgNCBmaWxlcyBjaGFuZ2VkLCAx NyBpbnNlcnRpb25zKCspLCAyMSBkZWxldGlvbnMoLSkKPj4gCj4+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9jcnQuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2NydC5jCj4+IGluZGV4IDJlZmFmOGUuLmU4YWJmY2UgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2NydC5jCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2NydC5jCj4+IEBAIC02OTksMTYgKzY5OSwyMSBAQCBpbnRlbF9jcnRfZGV0ZWN0KHN0cnVj dCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3IsIGJvb2wgZm9yY2UpCj4+ICAJCWdvdG8gb3V0Owo+ PiAgCX0KPj4gIAo+PiArCWRybV9tb2Rlc2V0X2FjcXVpcmVfaW5pdCgmY3R4LCAwKTsKPj4gKwo+ PiAgCS8qIGZvciBwcmUtOTQ1ZyBwbGF0Zm9ybXMgdXNlIGxvYWQgZGV0ZWN0ICovCj4+ICAJaWYg KGludGVsX2dldF9sb2FkX2RldGVjdF9waXBlKGNvbm5lY3RvciwgTlVMTCwgJnRtcCwgJmN0eCkp IHsKPj4gIAkJaWYgKGludGVsX2NydF9kZXRlY3RfZGRjKGNvbm5lY3RvcikpCj4+ICAJCQlzdGF0 dXMgPSBjb25uZWN0b3Jfc3RhdHVzX2Nvbm5lY3RlZDsKPj4gIAkJZWxzZQo+PiAgCQkJc3RhdHVz ID0gaW50ZWxfY3J0X2xvYWRfZGV0ZWN0KGNydCk7Cj4+IC0JCWludGVsX3JlbGVhc2VfbG9hZF9k ZXRlY3RfcGlwZShjb25uZWN0b3IsICZ0bXAsICZjdHgpOwo+PiArCQlpbnRlbF9yZWxlYXNlX2xv YWRfZGV0ZWN0X3BpcGUoY29ubmVjdG9yLCAmdG1wKTsKPj4gIAl9IGVsc2UKPj4gIAkJc3RhdHVz ID0gY29ubmVjdG9yX3N0YXR1c191bmtub3duOwo+PiAgCj4+ICsJZHJtX21vZGVzZXRfZHJvcF9s b2NrcygmY3R4KTsKPj4gKwlkcm1fbW9kZXNldF9hY3F1aXJlX2ZpbmkoJmN0eCk7Cj4+ICsKPj4g IG91dDoKPj4gIAlpbnRlbF9kaXNwbGF5X3Bvd2VyX3B1dChkZXZfcHJpdiwgcG93ZXJfZG9tYWlu KTsKPj4gIAlyZXR1cm4gc3RhdHVzOwo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfZGlzcGxheS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5j Cj4+IGluZGV4IDUxZjQ4ZDkuLjc5NTNiNDYgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9kaXNwbGF5LmMKPj4gQEAgLTg0NDAsOCArODQ0MCw2IEBAIGJvb2wgaW50ZWxfZ2V0X2xvYWRf ZGV0ZWN0X3BpcGUoc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvciwKPj4gIAkJICAgICAg Y29ubmVjdG9yLT5iYXNlLmlkLCBjb25uZWN0b3ItPm5hbWUsCj4+ICAJCSAgICAgIGVuY29kZXIt PmJhc2UuaWQsIGVuY29kZXItPm5hbWUpOwo+PiAgCj4+IC0JZHJtX21vZGVzZXRfYWNxdWlyZV9p bml0KGN0eCwgMCk7Cj4+IC0KPj4gIHJldHJ5Ogo+PiAgCXJldCA9IGRybV9tb2Rlc2V0X2xvY2so JmNvbmZpZy0+Y29ubmVjdGlvbl9tdXRleCwgY3R4KTsKPj4gIAlpZiAocmV0KQo+PiBAQCAtODU1 MiwxNSArODU1MCwxMSBAQCBmYWlsX3VubG9jazoKPj4gIAkJZ290byByZXRyeTsKPj4gIAl9Cj4+ ICAKPj4gLQlkcm1fbW9kZXNldF9kcm9wX2xvY2tzKGN0eCk7Cj4+IC0JZHJtX21vZGVzZXRfYWNx dWlyZV9maW5pKGN0eCk7Cj4+IC0KPj4gIAlyZXR1cm4gZmFsc2U7Cj4+ICB9Cj4+ICAKPj4gIHZv aWQgaW50ZWxfcmVsZWFzZV9sb2FkX2RldGVjdF9waXBlKHN0cnVjdCBkcm1fY29ubmVjdG9yICpj b25uZWN0b3IsCj4+IC0JCQkJICAgIHN0cnVjdCBpbnRlbF9sb2FkX2RldGVjdF9waXBlICpvbGQs Cj4+IC0JCQkJICAgIHN0cnVjdCBkcm1fbW9kZXNldF9hY3F1aXJlX2N0eCAqY3R4KQo+PiArCQkJ CSAgICBzdHJ1Y3QgaW50ZWxfbG9hZF9kZXRlY3RfcGlwZSAqb2xkKQo+PiAgewo+PiAgCXN0cnVj dCBpbnRlbF9lbmNvZGVyICppbnRlbF9lbmNvZGVyID0KPj4gIAkJaW50ZWxfYXR0YWNoZWRfZW5j b2Rlcihjb25uZWN0b3IpOwo+PiBAQCAtODU4NCwxNyArODU3OCwxMiBAQCB2b2lkIGludGVsX3Jl bGVhc2VfbG9hZF9kZXRlY3RfcGlwZShzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yLAo+ PiAgCQkJZHJtX2ZyYW1lYnVmZmVyX3VucmVmZXJlbmNlKG9sZC0+cmVsZWFzZV9mYik7Cj4+ICAJ CX0KPj4gIAo+PiAtCQlnb3RvIHVubG9jazsKPj4gIAkJcmV0dXJuOwo+PiAgCX0KPj4gIAo+PiAg CS8qIFN3aXRjaCBjcnRjIGFuZCBlbmNvZGVyIGJhY2sgb2ZmIGlmIG5lY2Vzc2FyeSAqLwo+PiAg CWlmIChvbGQtPmRwbXNfbW9kZSAhPSBEUk1fTU9ERV9EUE1TX09OKQo+PiAgCQljb25uZWN0b3It PmZ1bmNzLT5kcG1zKGNvbm5lY3Rvciwgb2xkLT5kcG1zX21vZGUpOwo+PiAtCj4+IC11bmxvY2s6 Cj4+IC0JZHJtX21vZGVzZXRfZHJvcF9sb2NrcyhjdHgpOwo+PiAtCWRybV9tb2Rlc2V0X2FjcXVp cmVfZmluaShjdHgpOwo+PiAgfQo+PiAgCj4+ICBzdGF0aWMgaW50IGk5eHhfcGxsX3JlZmNsayhz dHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+PiBAQCAtMTI2NTIsNyArMTI2NDEsNyBAQCBzdGF0aWMg dm9pZCBpbnRlbF9lbmFibGVfcGlwZV9hKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4+ICAJc3Ry dWN0IGludGVsX2Nvbm5lY3RvciAqY29ubmVjdG9yOwo+PiAgCXN0cnVjdCBkcm1fY29ubmVjdG9y ICpjcnQgPSBOVUxMOwo+PiAgCXN0cnVjdCBpbnRlbF9sb2FkX2RldGVjdF9waXBlIGxvYWRfZGV0 ZWN0X3RlbXA7Cj4+IC0Jc3RydWN0IGRybV9tb2Rlc2V0X2FjcXVpcmVfY3R4IGN0eDsKPj4gKwlz dHJ1Y3QgZHJtX21vZGVzZXRfYWNxdWlyZV9jdHggKmN0eCA9IGRldi0+bW9kZV9jb25maWcuYWNx dWlyZV9jdHg7Cj4+ICAKPj4gIAkvKiBXZSBjYW4ndCBqdXN0IHN3aXRjaCBvbiB0aGUgcGlwZSBB LCB3ZSBuZWVkIHRvIHNldCB0aGluZ3MgdXAgd2l0aCBhCj4+ICAJICogcHJvcGVyIG1vZGUgYW5k IG91dHB1dCBjb25maWd1cmF0aW9uLiBBcyBhIGdyb3NzIGhhY2ssIGVuYWJsZSBwaXBlIEEKPj4g QEAgLTEyNjY5LDEwICsxMjY1OCw4IEBAIHN0YXRpYyB2b2lkIGludGVsX2VuYWJsZV9waXBlX2Eo c3RydWN0IGRybV9kZXZpY2UgKmRldikKPj4gIAlpZiAoIWNydCkKPj4gIAkJcmV0dXJuOwo+PiAg Cj4+IC0JaWYgKGludGVsX2dldF9sb2FkX2RldGVjdF9waXBlKGNydCwgTlVMTCwgJmxvYWRfZGV0 ZWN0X3RlbXAsICZjdHgpKQo+PiAtCQlpbnRlbF9yZWxlYXNlX2xvYWRfZGV0ZWN0X3BpcGUoY3J0 LCAmbG9hZF9kZXRlY3RfdGVtcCwgJmN0eCk7Cj4+IC0KPj4gLQo+PiArCWlmIChpbnRlbF9nZXRf bG9hZF9kZXRlY3RfcGlwZShjcnQsIE5VTEwsICZsb2FkX2RldGVjdF90ZW1wLCBjdHgpKQo+PiAr CQlpbnRlbF9yZWxlYXNlX2xvYWRfZGV0ZWN0X3BpcGUoY3J0LCAmbG9hZF9kZXRlY3RfdGVtcCk7 Cj4+ICB9Cj4+ICAKPj4gIHN0YXRpYyBib29sCj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9kcnYuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oCj4+ IGluZGV4IDFiM2QxZDcuLjBkZDIzZjEgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2Rydi5oCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5o Cj4+IEBAIC04MzQsOCArODM0LDcgQEAgYm9vbCBpbnRlbF9nZXRfbG9hZF9kZXRlY3RfcGlwZShz dHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yLAo+PiAgCQkJCXN0cnVjdCBpbnRlbF9sb2Fk X2RldGVjdF9waXBlICpvbGQsCj4+ICAJCQkJc3RydWN0IGRybV9tb2Rlc2V0X2FjcXVpcmVfY3R4 ICpjdHgpOwo+PiAgdm9pZCBpbnRlbF9yZWxlYXNlX2xvYWRfZGV0ZWN0X3BpcGUoc3RydWN0IGRy bV9jb25uZWN0b3IgKmNvbm5lY3RvciwKPj4gLQkJCQkgICAgc3RydWN0IGludGVsX2xvYWRfZGV0 ZWN0X3BpcGUgKm9sZCwKPj4gLQkJCQkgICAgc3RydWN0IGRybV9tb2Rlc2V0X2FjcXVpcmVfY3R4 ICpjdHgpOwo+PiArCQkJCSAgICBzdHJ1Y3QgaW50ZWxfbG9hZF9kZXRlY3RfcGlwZSAqb2xkKTsK Pj4gIGludCBpbnRlbF9waW5fYW5kX2ZlbmNlX2ZiX29iaihzdHJ1Y3QgZHJtX2RldmljZSAqZGV2 LAo+PiAgCQkJICAgICAgIHN0cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0ICpvYmosCj4+ICAJCQkg ICAgICAgc3RydWN0IGludGVsX2VuZ2luZV9jcyAqcGlwZWxpbmVkKTsKPj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3R2LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF90di5jCj4+IGluZGV4IGUyMTFlZWYuLjMyMTg2YTYgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX3R2LmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfdHYuYwo+PiBAQCAtMTMyMywxMSArMTMyMywxNiBAQCBpbnRlbF90dl9kZXRlY3Qoc3Ry dWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvciwgYm9vbCBmb3JjZSkKPj4gIAkJc3RydWN0IGlu dGVsX2xvYWRfZGV0ZWN0X3BpcGUgdG1wOwo+PiAgCQlzdHJ1Y3QgZHJtX21vZGVzZXRfYWNxdWly ZV9jdHggY3R4Owo+PiAgCj4+ICsJCWRybV9tb2Rlc2V0X2FjcXVpcmVfaW5pdCgmY3R4LCAwKTsK Pj4gKwo+PiAgCQlpZiAoaW50ZWxfZ2V0X2xvYWRfZGV0ZWN0X3BpcGUoY29ubmVjdG9yLCAmbW9k ZSwgJnRtcCwgJmN0eCkpIHsKPj4gIAkJCXR5cGUgPSBpbnRlbF90dl9kZXRlY3RfdHlwZShpbnRl bF90diwgY29ubmVjdG9yKTsKPj4gLQkJCWludGVsX3JlbGVhc2VfbG9hZF9kZXRlY3RfcGlwZShj b25uZWN0b3IsICZ0bXAsICZjdHgpOwo+PiArCQkJaW50ZWxfcmVsZWFzZV9sb2FkX2RldGVjdF9w aXBlKGNvbm5lY3RvciwgJnRtcCk7Cj4+ICAJCX0gZWxzZQo+PiAgCQkJcmV0dXJuIGNvbm5lY3Rv cl9zdGF0dXNfdW5rbm93bjsKPj4gKwo+PiArCQlkcm1fbW9kZXNldF9kcm9wX2xvY2tzKCZjdHgp Owo+PiArCQlkcm1fbW9kZXNldF9hY3F1aXJlX2ZpbmkoJmN0eCk7Cj4+ICAJfSBlbHNlCj4+ICAJ CXJldHVybiBjb25uZWN0b3ItPnN0YXR1czsKPj4gIAo+PiAtLSAKPj4gMS44LjUuNQo+PiAKPj4g X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPj4gSW50ZWwt Z2Z4IG1haWxpbmcgbGlzdAo+PiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4+IGh0 dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKPgo+ IC0tIAo+IERhbmllbCBWZXR0ZXIKPiBTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRp b24KPiArNDEgKDApIDc5IDM2NSA1NyA0OCAtIGh0dHA6Ly9ibG9nLmZmd2xsLmNoCj4gX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBJbnRlbC1nZnggbWFp bGluZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKCi0tIApKYW5pIE5p a3VsYSwgSW50ZWwgT3BlbiBTb3VyY2UgVGVjaG5vbG9neSBDZW50ZXIKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJ bnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK