From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm/i915: Drop unecessary casts in i915_irq.c Date: Mon, 12 May 2014 20:36:13 +0300 Message-ID: <87r43yrjaq.fsf@intel.com> References: <1399915104-2470-1-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id EC1B76E92D for ; Mon, 12 May 2014 10:36:49 -0700 (PDT) In-Reply-To: <1399915104-2470-1-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Intel Graphics Development Cc: Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org On Mon, 12 May 2014, Daniel Vetter wrote: > Inspired by a review bikeshed from Jani. > Reviewed-by: Jani Nikula > Cc: Jani Nikula > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/i915/i915_irq.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c > index e5ec3e5ca37c..b10fbde1d5ee 100644 > --- a/drivers/gpu/drm/i915/i915_irq.c > +++ b/drivers/gpu/drm/i915/i915_irq.c > @@ -1668,7 +1668,7 @@ static void i9xx_hpd_irq_handler(struct drm_device *dev) > > static irqreturn_t valleyview_irq_handler(int irq, void *arg) > { > - struct drm_device *dev = (struct drm_device *) arg; > + struct drm_device *dev = arg; > struct drm_i915_private *dev_priv = dev->dev_private; > u32 iir, gt_iir, pm_iir; > irqreturn_t ret = IRQ_NONE; > @@ -1705,7 +1705,7 @@ out: > > static irqreturn_t cherryview_irq_handler(int irq, void *arg) > { > - struct drm_device *dev = (struct drm_device *) arg; > + struct drm_device *dev = arg; > struct drm_i915_private *dev_priv = dev->dev_private; > u32 master_ctl, iir; > irqreturn_t ret = IRQ_NONE; > @@ -2024,7 +2024,7 @@ static void ivb_display_irq_handler(struct drm_device *dev, u32 de_iir) > > static irqreturn_t ironlake_irq_handler(int irq, void *arg) > { > - struct drm_device *dev = (struct drm_device *) arg; > + struct drm_device *dev = arg; > struct drm_i915_private *dev_priv = dev->dev_private; > u32 de_iir, gt_iir, de_ier, sde_ier = 0; > irqreturn_t ret = IRQ_NONE; > @@ -3642,7 +3642,7 @@ static bool i8xx_handle_vblank(struct drm_device *dev, > > static irqreturn_t i8xx_irq_handler(int irq, void *arg) > { > - struct drm_device *dev = (struct drm_device *) arg; > + struct drm_device *dev = arg; > struct drm_i915_private *dev_priv = dev->dev_private; > u16 iir, new_iir; > u32 pipe_stats[2]; > @@ -3827,7 +3827,7 @@ static bool i915_handle_vblank(struct drm_device *dev, > > static irqreturn_t i915_irq_handler(int irq, void *arg) > { > - struct drm_device *dev = (struct drm_device *) arg; > + struct drm_device *dev = arg; > struct drm_i915_private *dev_priv = dev->dev_private; > u32 iir, new_iir, pipe_stats[I915_MAX_PIPES]; > unsigned long irqflags; > @@ -4057,7 +4057,7 @@ static void i915_hpd_irq_setup(struct drm_device *dev) > > static irqreturn_t i965_irq_handler(int irq, void *arg) > { > - struct drm_device *dev = (struct drm_device *) arg; > + struct drm_device *dev = arg; > struct drm_i915_private *dev_priv = dev->dev_private; > u32 iir, new_iir; > u32 pipe_stats[I915_MAX_PIPES]; > -- > 1.9.2 > -- Jani Nikula, Intel Open Source Technology Center