From: Jani Nikula <jani.nikula@linux.intel.com>
To: jeff.mcgee@intel.com, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Restore rps/rc6 on reset
Date: Fri, 01 Nov 2013 12:47:19 +0200 [thread overview]
Message-ID: <87r4b0csaw.fsf@intel.com> (raw)
In-Reply-To: <1383249135-11986-1-git-send-email-jeff.mcgee@intel.com>
On Thu, 31 Oct 2013, jeff.mcgee@intel.com wrote:
> From: Jeff McGee <jeff.mcgee@intel.com>
>
> Hello all,
>
> Posting my first patch to the list. I have tested this fix on Android
> kernel 3.9.1 and only compile-checked on drm-intel-nightly. I have
> reviewed the changes to reset and rps/rc6 stuff and believe there
> should be no hidden gotchas.
>
> As I hope this to be the first of many patches to upstream, I will
> probably need a bleeding-edge kernel dev environment to complement
> my Android testing. Any tips on what to use would be appreciated.
It would be awesome if you could run our -nightly kernels on Android,
but I can understand if that's not feasible (missing upstream drivers
etc.)
Otherwise any distro you feel comfortable working with should be
fine. For a start, the userspace doesn't really have to be bleeding edge
(indeed for the most parts I run vanilla userspace from the distro). You
should always be able to switch to a newer kernel without regressing the
userspace.
> I was instructed to keep the JIRA issue codes on the patch, but have
> to wonder why I don't see any of these in the history. Let me know if
> those shouldn't be there.
Personally I don't think references to internal systems provide much
value, though others may disagree. In any case the commit message has to
be self sufficient without the referenced info. (And no complaints about
that in your patch!)
Keep the patches coming! ;)
HTH,
Jani.
>
> Thanks,
> Jeff
>
> Jeff McGee (1):
> drm/i915: Restore rps/rc6 on reset
>
> drivers/gpu/drm/i915/i915_debugfs.c | 49 +++++++++++++++++++++++++++++++------
> drivers/gpu/drm/i915/i915_drv.c | 11 +++++++++
> drivers/gpu/drm/i915/intel_pm.c | 31 ++++++++++++++++-------
> 3 files changed, 74 insertions(+), 17 deletions(-)
>
> --
> 1.8.4.2
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Technology Center
next prev parent reply other threads:[~2013-11-01 10:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-31 19:52 [PATCH] drm/i915: Restore rps/rc6 on reset jeff.mcgee
2013-10-31 19:52 ` jeff.mcgee
2013-11-04 8:44 ` Daniel Vetter
2013-11-05 20:38 ` Mcgee, Jeff
2013-11-06 19:37 ` Mcgee, Jeff
2014-02-04 17:32 ` [PATCH v2] " jeff.mcgee
2014-02-07 9:25 ` Daniel Vetter
2013-11-01 10:47 ` Jani Nikula [this message]
2013-11-01 11:05 ` [PATCH] " Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r4b0csaw.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jeff.mcgee@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox