From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm/i915: Add breadcrumbs for why the backlight is being set Date: Mon, 14 Oct 2013 11:06:13 +0300 Message-ID: <87r4bo6zuy.fsf@intel.com> References: <1381665391-20083-1-git-send-email-chris@chris-wilson.co.uk> <87y55w70ya.fsf@intel.com> <20131014075424.GA29679@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 73A64E5C80 for ; Mon, 14 Oct 2013 01:04:55 -0700 (PDT) In-Reply-To: <20131014075424.GA29679@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Mon, 14 Oct 2013, Chris Wilson wrote: > On Mon, Oct 14, 2013 at 10:42:37AM +0300, Jani Nikula wrote: >> On Sun, 13 Oct 2013, Chris Wilson wrote: >> > diff --git a/drivers/gpu/drm/i915/intel_opregion.c b/drivers/gpu/drm/i915/intel_opregion.c >> > index 2acf5cae20e4..564da613b278 100644 >> > --- a/drivers/gpu/drm/i915/intel_opregion.c >> > +++ b/drivers/gpu/drm/i915/intel_opregion.c >> > @@ -405,6 +405,7 @@ static u32 asle_set_backlight(struct drm_device *dev, u32 bclp) >> > if (bclp > 255) >> > return ASLC_BACKLIGHT_FAILED; >> > >> > + DRM_DEBUG_KMS("updating opregion backlight %d/255\n", bclp); >> >> Just a few lines earliner we have: >> >> DRM_DEBUG_DRIVER("bclp = 0x%08x\n", bclp); > > Right, I wasn't sure about changing that to suite my purposes - I > guessed that it was intentionally a different debug level pre-validation > for a reason and so added a new message at the debug level as the > messages within the modesetting and backlight operation. Please just change that to suit your needs instead of adding a new one. Jani. > -Chris > > -- > Chris Wilson, Intel Open Source Technology Centre -- Jani Nikula, Intel Open Source Technology Center