From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0CDE4C021A1 for ; Wed, 12 Feb 2025 09:41:24 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9676610E82D; Wed, 12 Feb 2025 09:41:23 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="UO10V3Z0"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by gabe.freedesktop.org (Postfix) with ESMTPS id D79BF10E829; Wed, 12 Feb 2025 09:41:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1739353283; x=1770889283; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=LiEr+TkmBzoD9rbiJziu71a6CN+g9/QGo7Bs/vFHVyc=; b=UO10V3Z0++PvhhVbTKLD+iB6O7GvDD+LHr9265I7uGOPhDIkovQzxkqm cgmVbzl+znuTlsM2f7R1Ix7U9tvwavYNFvSXSreRlRigBt585nn8Z3WD8 vBJFUI+Irx+DCh0GCuHEkAnMbULqJzblKpo/iGZaiieIPT9JfxTrLBpBa jSfAACcHPowLAw7e2JkpctMYRlmvo2BfjlqkL+vqHerbfrqEZzzL9OCWa Wb9eG1uRkGdSgPx/PqXfc51tiHAX/jUOy5C7GBg8xno0OIxeUzbzGMQiE xNrlrvNQIAYmlWrbeIQ4N98UMm7UsPuffVcO0FsCKLcEvMKg1jOqrAgOk A==; X-CSE-ConnectionGUID: YcghfiziTXiywyAWcjICMw== X-CSE-MsgGUID: CUWg83u+SxaDdj2a7aZvMg== X-IronPort-AV: E=McAfee;i="6700,10204,11342"; a="57409260" X-IronPort-AV: E=Sophos;i="6.13,279,1732608000"; d="scan'208";a="57409260" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Feb 2025 01:41:22 -0800 X-CSE-ConnectionGUID: f0tRuyz3QPKwNkngjcLptA== X-CSE-MsgGUID: J8dUS8BkRVKhduO5qSBFcg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="113674266" Received: from ncintean-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.246.167]) by orviesa008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Feb 2025 01:41:21 -0800 From: Jani Nikula To: "Kandpal, Suraj" , "intel-gfx@lists.freedesktop.org" , "intel-xe@lists.freedesktop.org" Cc: "ville.syrjala@linux.intel.com" , "Deak, Imre" Subject: RE: [PATCH 3/3] drm/i915: split out display register macros to a separate file In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: Date: Wed, 12 Feb 2025 11:41:17 +0200 Message-ID: <87seojzeiq.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, 12 Feb 2025, "Kandpal, Suraj" wrote: >> -----Original Message----- >> From: Intel-xe On Behalf Of Jani >> Nikula >> Sent: Friday, February 7, 2025 7:05 PM >> To: intel-gfx@lists.freedesktop.org; intel-xe@lists.freedesktop.org >> Cc: Nikula, Jani ; ville.syrjala@linux.intel.com; Deak, >> Imre >> Subject: [PATCH 3/3] drm/i915: split out display register macros to a >> separate file >> >> This is a scripted split of the display related register macros from >> i915_reg.h to display/intel_display_regs.h. Basically move all the >> macros that are only used in display code (or GVT). If there are users >> in core i915 code or soc/, or no users anywhere, keep the macros in >> i915_reg.h. This is done in groups of macros separated by blank lines, >> moving the comments along with the groups. >> >> This is obviously a very crude approach. It's not perfect. But there are >> 4.2k lines in i915_reg.h, and its refactoring has ground to a halt. This >> is the big hammer that splits the file to two, and enables further >> cleanup. >> > > This is a really big patch and I may have very well missed something but > Seeing that this is majorly code movement and things like conversion of 1< To reg_bit will need to happen In a different patch or series LGTM, > Reviewed-by: Suraj Kandpal Oh, I sincerely hope you're aware of 'git show --color-moved'. Applying the patch and looking at it with that makes it a breeze to review code movement! Thanks for the review. BR, Jani. -- Jani Nikula, Intel