From: Jani Nikula <jani.nikula@linux.intel.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>,
"Lisovskiy, Stanislav" <stanislav.lisovskiy@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/8] drm/i915: Rename the crtc/crtc_states in the top level DDI hooks/etc
Date: Tue, 05 Mar 2024 16:07:45 +0200 [thread overview]
Message-ID: <87sf1422mm.fsf@intel.com> (raw)
In-Reply-To: <Zebcuecv8QHwm4AE@intel.com>
On Tue, 05 Mar 2024, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Tue, Mar 05, 2024 at 10:41:49AM +0200, Lisovskiy, Stanislav wrote:
>> I also wonder whether should we really emphasize things like "master"/"slave"
>> in function names. I thought that one idea in our refactoring was to unify
>> joined pipes handling so that there are no(or at least almost no) explicit code
>> paths/function names for masters/slaves.
>
> There are no master vs. slave functions. The split is going to be
> transcoder/port vs. pipe.
Besides, for modern platforms the spec has already been changed to use
primary/secondary terminology. When renaming or refactoring stuff,
please switch to them instead of sticking with master/slave.
BR,
Jani.
--
Jani Nikula, Intel
next prev parent reply other threads:[~2024-03-05 14:07 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-01 14:35 [PATCH 0/8] drm/i915: Bigjoiner stuff Ville Syrjala
2024-03-01 14:35 ` [PATCH 1/8] drm/i915: Rename the crtc/crtc_states in the top level DDI hooks/etc Ville Syrjala
2024-03-05 8:41 ` Lisovskiy, Stanislav
2024-03-05 8:50 ` Ville Syrjälä
2024-03-05 9:08 ` Lisovskiy, Stanislav
2024-03-05 9:19 ` Ville Syrjälä
2024-03-05 14:07 ` Jani Nikula [this message]
2024-03-05 14:34 ` Ville Syrjälä
2024-03-05 14:57 ` Jani Nikula
2024-03-01 14:35 ` [PATCH 2/8] drm/i915: Introduce intel_crtc_joined_pipe_mask() Ville Syrjala
2024-03-01 14:35 ` [PATCH 3/8] drm/i915: Extract intel_ddi_post_disable_hdmi_or_sst() Ville Syrjala
2024-03-05 8:47 ` Lisovskiy, Stanislav
2024-03-01 14:35 ` [PATCH 4/8] drm/i915: Utilize intel_crtc_joined_pipe_mask() more Ville Syrjala
2024-03-01 14:35 ` [PATCH 5/8] drm/i915: Precompute disable_pipes bitmask in intel_commit_modeset_disables() Ville Syrjala
2024-03-05 8:49 ` Lisovskiy, Stanislav
2024-03-01 14:35 ` [PATCH 6/8] drm/i915: Disable planes more atomically during modesets Ville Syrjala
2024-03-05 8:58 ` Lisovskiy, Stanislav
2024-03-01 14:35 ` [PATCH 7/8] drm/i915: Simplify intel_old_crtc_state_disables() calling convention Ville Syrjala
2024-03-05 8:59 ` Lisovskiy, Stanislav
2024-03-01 14:36 ` [PATCH 8/8] drm/i915: Handle joined pipes inside hsw_crtc_disable() Ville Syrjala
2024-03-01 16:04 ` Lisovskiy, Stanislav
2024-03-01 16:10 ` Ville Syrjälä
2024-03-01 16:22 ` Lisovskiy, Stanislav
2024-03-01 16:47 ` Ville Syrjälä
2024-03-04 8:55 ` Lisovskiy, Stanislav
2024-03-01 16:08 ` Lisovskiy, Stanislav
2024-03-01 16:15 ` Ville Syrjälä
2024-03-01 17:23 ` [PATCH v2 " Ville Syrjala
2024-03-04 6:44 ` Srinivas, Vidya
2024-03-04 10:20 ` Lisovskiy, Stanislav
2024-03-01 19:54 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Bigjoiner stuff (rev2) Patchwork
2024-03-01 20:12 ` ✗ Fi.CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sf1422mm.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=stanislav.lisovskiy@intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).