From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ED289C433F5 for ; Tue, 11 Oct 2022 00:34:17 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 534FD10E76E; Tue, 11 Oct 2022 00:34:16 +0000 (UTC) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0336210E76F for ; Tue, 11 Oct 2022 00:34:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665448453; x=1696984453; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=EWeMdlhC4gtzO70y6ym2vRZSCLNQwPeoAxBht2qwNkY=; b=b8RSv08e/AiEStKbNuu1+Rit0ikFLHZPyCd63+2wxxVcJu/658V/aXL0 LOYJB6IgW14XX4eEuUlhZNrgS36CnQcO1H0ZhGZsc8D7Np8O5FzRny6un GsP3fPk4ZZpRoUnu3j9ZqCieivwL3/eMHZ0e4fBZQg+M6YITSUOS3JUYW Yq14qo9d8yp60QePP0pUAjg7sDAqrROjAUe40IrNlipyoJeYZoZVQMkZ8 dbfMzJ4BlaxEouuLakkj5rNr0Z93vuMmv2INOL7yn2k7BlKqyVnDUhWE1 /yLL0BRC9fyKGP+XsmmfyCR9mUxW1U2dy0GlwDCCXjTXxVAalEH290zid A==; X-IronPort-AV: E=McAfee;i="6500,9779,10496"; a="305991056" X-IronPort-AV: E=Sophos;i="5.95,173,1661842800"; d="scan'208";a="305991056" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Oct 2022 17:34:12 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10496"; a="871310818" X-IronPort-AV: E=Sophos;i="5.95,173,1661842800"; d="scan'208";a="871310818" Received: from smuttava-mobl.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.212.187.14]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Oct 2022 17:34:11 -0700 Date: Mon, 10 Oct 2022 17:34:10 -0700 Message-ID: <87sfjv19ml.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Umesh Nerlige Ramappa In-Reply-To: <20221010181434.513477-16-umesh.nerlige.ramappa@intel.com> References: <20221010181434.513477-1-umesh.nerlige.ramappa@intel.com> <20221010181434.513477-16-umesh.nerlige.ramappa@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [Intel-gfx] [PATCH v3 15/16] drm/i915/perf: complete programming whitelisting for XEHPSDV X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, 10 Oct 2022 11:14:33 -0700, Umesh Nerlige Ramappa wrote: > > From: Lionel Landwerlin > > We have an additional register to select which slices contribute to > OAG/OAG counter increments. > > Signed-off-by: Lionel Landwerlin > Signed-off-by: Matt Roper > --- > drivers/gpu/drm/i915/i915_drv.h | 2 ++ > drivers/gpu/drm/i915/i915_pci.c | 1 + > drivers/gpu/drm/i915/i915_perf.c | 13 +++++++++++++ > drivers/gpu/drm/i915/intel_device_info.h | 1 + > 4 files changed, 17 insertions(+) > > diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h > index ccd54ff54002..992ca7b0aea0 100644 > --- a/drivers/gpu/drm/i915/i915_drv.h > +++ b/drivers/gpu/drm/i915/i915_drv.h > @@ -904,6 +904,8 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915, > > #define HAS_OA_BPC_REPORTING(dev_priv) \ > (INTEL_INFO(dev_priv)->has_oa_bpc_reporting) > +#define HAS_OA_SLICE_CONTRIB_LIMITS(dev_priv) \ > + (INTEL_INFO(dev_priv)->has_oa_slice_contrib_limits) If this is just for XEHPSDV maybe we could just have a platform check rather than introduce a flag? Otherwise this is: Reviewed-by: Ashutosh Dixit