From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 22F2CC32771 for ; Wed, 28 Sep 2022 19:04:55 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D81B510E7D0; Wed, 28 Sep 2022 19:04:53 +0000 (UTC) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2ADA310E7CE; Wed, 28 Sep 2022 19:04:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1664391875; x=1695927875; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=LAVIGpqxXp3U7Loe8lBhFzM7hB1i1NKM8b5Ugb8Yp+I=; b=FK+Y1xhbfS9kO7jyA69N4cYsdWTfVvzFgbNXdzo+HoNNtneHgE3hO5nP 50pbuGEnaPV6S/ZfZjO/FtCd1KVyJ3QW8xeC/2LEGNUECnLqcEr9zmuHD sTdqxlFe35HJPPdbsWTczfEbwrYwMoBLQseIL9EXXkcFBWzVTwJmpGIZ0 N/KWuZWc4b1FUWXh0OlqOjBWN1C2ieKdkFKVFgAaq+Xfzr9QHQQHPIjcp TM5Lp811INfhevYhIdTihgXHaD3C8nVqr5C4F860GSDHZ6+wKm+jAqwoo jc8NvujKduiuSU9kwyYw4pWxJOBE/vesXGBgpgPrzUeP1kUKm+blfPlW+ A==; X-IronPort-AV: E=McAfee;i="6500,9779,10484"; a="303177623" X-IronPort-AV: E=Sophos;i="5.93,352,1654585200"; d="scan'208";a="303177623" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Sep 2022 12:04:34 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10484"; a="867083779" X-IronPort-AV: E=Sophos;i="5.93,352,1654585200"; d="scan'208";a="867083779" Received: from cornea-mobl1.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.212.246.34]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Sep 2022 12:04:33 -0700 Date: Wed, 28 Sep 2022 12:03:41 -0700 Message-ID: <87sfkb5njm.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Rodrigo Vivi In-Reply-To: References: <20220919162401.2077713-1-ashutosh.dixit@intel.com> <871qrvzq2h.fsf@intel.com> <87v8p75pp9.wl-ashutosh.dixit@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [Intel-gfx] [PATCH] drm/i915: Perf_limit_reasons are only available for Gen11+ X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, 28 Sep 2022 11:35:18 -0700, Rodrigo Vivi wrote: > > On Wed, Sep 28, 2022 at 11:17:06AM -0700, Dixit, Ashutosh wrote: > > On Wed, 28 Sep 2022 04:38:46 -0700, Jani Nikula wrote: > > > > > > On Mon, 19 Sep 2022, Ashutosh Dixit wrote: > > > > Register GT0_PERF_LIMIT_REASONS (0x1381a8) is available only for > > > > Gen11+. Therefore ensure perf_limit_reasons sysfs/debugfs files are created > > > > only for Gen11+. Otherwise on Gen < 5 accessing these files results in the > > > > following oops: > > > > > > > > <1> [88.829420] BUG: unable to handle page fault for address: ffffc90000bb81a8 > > > > <1> [88.829438] #PF: supervisor read access in kernel mode > > > > <1> [88.829447] #PF: error_code(0x0000) - not-present page > > > > > > > > Bspec: 20008 > > > > Bug: https://gitlab.freedesktop.org/drm/intel/-/issues/6863 > > > > Fixes: fe5979665f64 ("drm/i915/debugfs: Add perf_limit_reasons in debugfs") > > > > Fixes: fa68bff7cf27 ("drm/i915/gt: Add sysfs throttle frequency interfaces") > > > > Signed-off-by: Ashutosh Dixit > > > > > > > Hi Jani, > > > > > Ashutosh, can you provide a backport of this i.e. commit 0d2d201095e9 > > > ("drm/i915: Perf_limit_reasons are only available for Gen11+") that > > > applies cleanly on drm-intel-fixes, please? > > > > I've sent the patch: > > > > https://patchwork.freedesktop.org/series/109196/ > > > > Not sure though if it is worth applying on drm-intel-fixes because of one > > conflict with drm-tip which will need to be resolved manually. On Hi Rodrigo, > The conflict shouldn't be that bad to resolve, but since the patch deviates > from the original, the new commit message needs to highlight and explain > that this is a backport and the reasons of the difference and including the sha > of the already merged patch. Similar to the option 3 of the stable rules. [1]. I have improved the commit message and sent out a v2. Please take a look. Thanks. -- Ashutosh > Well, another option is to wait until this patch gets propagated to Linus master > and then send the backported version to the stable mailing list. But again, > with the proper rules of the option 3. [1] > > [1] - https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html > > > drm-intel-fixes the crash mentioned above will be seen only on Gen < 5 if > > someone manually cat's the sysfs. We had to fix on drm-tip because there > > was a CI failure with Gen3 debugfs but that code is not in drm-intel-fixes. > > since it is sysfs it is probably a good protection to have anyway. > > > > > Thanks. > > -- > > Ashutosh