From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4E574C28D13 for ; Thu, 25 Aug 2022 14:48:19 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8465E10E239; Thu, 25 Aug 2022 14:48:18 +0000 (UTC) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id AD45910E239 for ; Thu, 25 Aug 2022 14:48:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1661438893; x=1692974893; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version:content-transfer-encoding; bh=Bxcfj15EA4On+ZizYl/NclYUnSWZECFeKGUNGdK+YL8=; b=mTVZsg0mkPLQAYhzQ8HBPjAhvCtVxAUzonJ5ypDJz9h4Zu5th1NLN77G eQesZVLcMyT/AOIclG8ZAsNVEttvEP97sEm65RWkq3Sw2AdmMM0qlqMZo vRGV1pE/UvV7MdakxD8tXUoFSq0ebE3VAP77VsZ+3eNmACjzcxQIUvsTd aWiiRIqq61oUyLu6fwtKL62oqgrqv9WxrOJY6gQE1JRe9utHzHhiQEwlF Xa/pyCywL2h2XNhXdFBogxvhACKXiIW/pPoKJVSMbpeKviFiekeBI0Q8m 0DGcj33PRMPmjPZQsblIUYfDCMOx5P6PW95hKEynuqOIkKbgAfbj5FAa5 w==; X-IronPort-AV: E=McAfee;i="6500,9779,10450"; a="277272164" X-IronPort-AV: E=Sophos;i="5.93,263,1654585200"; d="scan'208";a="277272164" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Aug 2022 07:48:12 -0700 X-IronPort-AV: E=Sophos;i="5.93,263,1654585200"; d="scan'208";a="678485667" Received: from jnikula-mobl4.fi.intel.com (HELO localhost) ([10.237.66.149]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Aug 2022 07:48:10 -0700 From: Jani Nikula To: Ville =?utf-8?B?U3lyasOkbMOk?= In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20220616124137.3184371-1-jani.nikula@intel.com> Date: Thu, 25 Aug 2022 17:48:07 +0300 Message-ID: <87sflkgz14.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Intel-gfx] [PATCH] drm/i915/glk: ECS Liva Q2 needs GLK HDMI port timing quirk X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, Diego Santa Cruz , stable@vger.kernel.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, 25 Aug 2022, Ville Syrj=C3=A4l=C3=A4 wrote: > On Thu, Jun 16, 2022 at 03:41:37PM +0300, Jani Nikula wrote: >> From: Diego Santa Cruz >>=20 >> The quirk added in upstream commit 90c3e2198777 ("drm/i915/glk: Add >> Quirk for GLK NUC HDMI port issues.") is also required on the ECS Liva >> Q2. >>=20 >> Note: Would be nicer to figure out the extra delay required for the >> retimer without quirks, however don't know how to check for that. >>=20 >> Cc: stable@vger.kernel.org >> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/1326 >> Signed-off-by: Diego Santa Cruz >> Signed-off-by: Jani Nikula > > Seems fine. Although I do wonder whether we could directly identify the > bogus retimer chip via the dual mode adapter registers. I've asked for > that in the bug. > > Reviewed-by: Ville Syrj=C3=A4l=C3=A4 Thanks, pushed to drm-intel-next. Let's follow up with cleanups if the folks in the bug ever reply. BR, Jani. > >> --- >> drivers/gpu/drm/i915/display/intel_quirks.c | 3 +++ >> 1 file changed, 3 insertions(+) >>=20 >> diff --git a/drivers/gpu/drm/i915/display/intel_quirks.c b/drivers/gpu/d= rm/i915/display/intel_quirks.c >> index c8488f5ebd04..e415cd7c0b84 100644 >> --- a/drivers/gpu/drm/i915/display/intel_quirks.c >> +++ b/drivers/gpu/drm/i915/display/intel_quirks.c >> @@ -191,6 +191,9 @@ static struct intel_quirk intel_quirks[] =3D { >> /* ASRock ITX*/ >> { 0x3185, 0x1849, 0x2212, quirk_increase_ddi_disabled_time }, >> { 0x3184, 0x1849, 0x2212, quirk_increase_ddi_disabled_time }, >> + /* ECS Liva Q2 */ >> + { 0x3185, 0x1019, 0xa94d, quirk_increase_ddi_disabled_time }, >> + { 0x3184, 0x1019, 0xa94d, quirk_increase_ddi_disabled_time }, >> }; >>=20=20 >> void intel_init_quirks(struct drm_i915_private *i915) >> --=20 >> 2.30.2 --=20 Jani Nikula, Intel Open Source Graphics Center