From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C2A9C433F5 for ; Wed, 13 Oct 2021 10:47:19 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CD84460273 for ; Wed, 13 Oct 2021 10:47:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CD84460273 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 396CC88549; Wed, 13 Oct 2021 10:47:17 +0000 (UTC) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8035E6E86B for ; Wed, 13 Oct 2021 10:47:15 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10135"; a="207514059" X-IronPort-AV: E=Sophos;i="5.85,370,1624345200"; d="scan'208";a="207514059" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2021 03:47:14 -0700 X-IronPort-AV: E=Sophos;i="5.85,370,1624345200"; d="scan'208";a="491406485" Received: from araghuw-mobl.gar.corp.intel.com (HELO localhost) ([10.251.208.234]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2021 03:47:12 -0700 From: Jani Nikula To: Ville =?utf-8?B?U3lyasOkbMOk?= Cc: intel-gfx@lists.freedesktop.org, Lucas De Marchi In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: Date: Wed, 13 Oct 2021 13:47:09 +0300 Message-ID: <87sfx5xkuq.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Intel-gfx] [PATCH 0/1] drm/i915: vlv sideband X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, 13 Oct 2021, Ville Syrj=C3=A4l=C3=A4 wrote: > On Wed, Oct 13, 2021 at 01:11:58PM +0300, Jani Nikula wrote: >> Three main ideas here: >>=20 >> - vlv sideband only has the name "sideband" in common with the rest of >> intel_sideband.[ch] > > I wouldn't put it like that. There are two actual sideband=20 > implementtions in that file: > - vlv/chv iosf sideband (vlv_sideband) > - lpt/wpt iosf sideband (intel_sbi) > > And the third thing in that file is the snb+ pcode mailbox stuff, > which has nothing to do with sideband. Fair enough... but no opposition to the splitting out of vlv/chv iosf sideband? vlv_sideband.[ch] like here? I'm fine with renaming too. I can follow up with lpt/wpt iosf split out (intel_sbi.[ch]?) and snb+ pcode (intel_pcode.[ch]?). I think we've just put all of them together way back when this was all probably bundled in i915_drv.c or something... BR, Jani. --=20 Jani Nikula, Intel Open Source Graphics Center