From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 423EEC2D0A8 for ; Mon, 28 Sep 2020 17:32:30 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F0BB42083B for ; Mon, 28 Sep 2020 17:32:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F0BB42083B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5B6336E14F; Mon, 28 Sep 2020 17:32:29 +0000 (UTC) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0621B6E14F; Mon, 28 Sep 2020 17:32:28 +0000 (UTC) IronPort-SDR: BwRWlioCwVGqBxK5SW0FW4N5w5ziVAWAhK8bG9cBNU0p4yR0LTJU5kfoom5iXDK0JTC+h07kDl U7tf+B0WdwQw== X-IronPort-AV: E=McAfee;i="6000,8403,9758"; a="159414029" X-IronPort-AV: E=Sophos;i="5.77,313,1596524400"; d="scan'208";a="159414029" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Sep 2020 10:32:26 -0700 IronPort-SDR: j8xoHDJJ45rGwOwoyZZF+HllFLLJ158Zya1dckhQLHFShb8AsHRsnJgHZ0XZbKAsPILnuPhSUL yTL6bLE1PmoA== X-IronPort-AV: E=Sophos;i="5.77,313,1596524400"; d="scan'208";a="488674823" Received: from lizwalsh-mobl3.ger.corp.intel.com (HELO localhost) ([10.251.86.12]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Sep 2020 10:32:21 -0700 From: Jani Nikula To: Matt Roper In-Reply-To: <20200928172447.GA2157395@mdroper-desk1.amr.corp.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20200928080931.246347-1-tejaskumarx.surendrakumar.upadhyay@intel.com> <20200928080931.246347-2-tejaskumarx.surendrakumar.upadhyay@intel.com> <87d026owdq.fsf@intel.com> <874knhq0x1.fsf@intel.com> <20200928172447.GA2157395@mdroper-desk1.amr.corp.intel.com> Date: Mon, 28 Sep 2020 20:32:38 +0300 Message-ID: <87sgb1olhl.fsf@intel.com> MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH 1/2] drm/i915/jsl: Split EHL/JSL platform info and PCI ids X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Pandey, Hariom" , "airlied@linux.ie" , "intel-gfx@lists.freedesktop.org" , "De Marchi, Lucas" , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, 28 Sep 2020, Matt Roper wrote: > Why are we adding IS_JASPERLAKE at all? EHL/JSL are documented as the > same graphics IP, but are paired with different PCHs in the final SoCs, > which is what causes the minor differences in programming. My > understanding is that the voltage programming differences are ultimately > due to that difference in PCH so we should just use HAS_PCH_MCC (EHL) > and HAS_PCH_JSP (JSL) to distinguish which type of programming is needed > rather than using a platform test. Good point. If the difference is in the PCH, then of course the PCH check should be used instead. Which avoids the problem altogether. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx