From: Jani Nikula <jani.nikula@intel.com>
To: Michal Wajdeczko <michal.wajdeczko@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2 04/13] drm/i915: make i915_gem_gtt.h self-contained
Date: Wed, 26 Jun 2019 18:51:56 +0300 [thread overview]
Message-ID: <87sgrwqr8j.fsf@intel.com> (raw)
In-Reply-To: <87v9wsqre3.fsf@intel.com>
On Wed, 26 Jun 2019, Jani Nikula <jani.nikula@intel.com> wrote:
> On Wed, 26 Jun 2019, Michal Wajdeczko <michal.wajdeczko@intel.com> wrote:
>> On Wed, 26 Jun 2019 16:40:11 +0200, Jani Nikula <jani.nikula@intel.com>
>> wrote:
>>
>>> Add the minimal includes/declarations to make the header self-contained,
>>> and ensure it stays that way.
>>>
>>> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
>>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>>> ---
>>> drivers/gpu/drm/i915/i915_gem_gtt.h | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.h
>>> b/drivers/gpu/drm/i915/i915_gem_gtt.h
>>> index 028be3b44d07..883a5ed146c3 100644
>>> --- a/drivers/gpu/drm/i915/i915_gem_gtt.h
>>> +++ b/drivers/gpu/drm/i915/i915_gem_gtt.h
>>> @@ -42,6 +42,8 @@
>>> #include <drm/drm_mm.h>
>>> +#include <drm/drm_mm.h>
>>
>> this seems to be redundant ;)
>
> Gah, curiously silent rebase fail. Thanks for spotting!
Heh, I went back to fix it, but we can just drop this one. It was all
done by Chris in b32fa8111563 ("drm/i915/gtt: Defer address space
cleanup to an RCU worker").
J.
>
> BR,
> Jani.
>
>>
>>> +
>>> #include "gt/intel_reset.h"
>>> #include "i915_gem_fence_reg.h"
>>> #include "i915_request.h"
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-06-26 15:49 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-26 14:40 drm/i915: last bits to make headers self-contained Jani Nikula
2019-06-26 14:40 ` [PATCH v2 01/13] drm/i915: prefix header search path with $(srctree)/ Jani Nikula
2019-06-26 14:40 ` [PATCH v2 02/13] drm/i915: add include path to subdir Makefiles Jani Nikula
2019-06-26 14:40 ` [PATCH v2 03/13] drm/i915: make i915_fixed.h self-contained Jani Nikula
2019-06-26 14:40 ` [PATCH v2 04/13] drm/i915: make i915_gem_gtt.h self-contained Jani Nikula
2019-06-26 15:37 ` Michal Wajdeczko
2019-06-26 15:48 ` Jani Nikula
2019-06-26 15:51 ` Jani Nikula [this message]
2019-06-26 14:40 ` [PATCH v2 05/13] drm/i915: make i915_globals.h self-contained Jani Nikula
2019-06-26 14:40 ` [PATCH v2 06/13] drm/i915: make i915_pvinfo.h self-contained Jani Nikula
2019-06-26 14:40 ` [PATCH v2 07/13] drm/i915: make i915_vgpu.h self-contained Jani Nikula
2019-06-26 14:40 ` [PATCH v2 08/13] drm/i915: make intel_guc_ct.h self-contained Jani Nikula
2019-06-26 14:40 ` [PATCH v2 09/13] drm/i915: make intel_guc_fwif.h self-contained Jani Nikula
2019-06-26 14:40 ` [PATCH v2 10/13] drm/i915: make intel_guc_reg.h self-contained Jani Nikula
2019-06-26 14:40 ` [PATCH v2 11/13] drm/i915: make intel_gvt.h self-contained Jani Nikula
2019-06-26 14:40 ` [PATCH v2 12/13] drm/i915: make intel_uc_fw.h self-contained Jani Nikula
2019-06-26 14:40 ` [PATCH v2 13/13] drm/i915: use wildcard to ensure all headers stay self-contained Jani Nikula
2019-06-26 15:29 ` ✗ Fi.CI.SPARSE: warning for series starting with [v2,01/13] drm/i915: prefix header search path with $(srctree)/ Patchwork
2019-06-26 15:56 ` Jani Nikula
2019-06-26 15:53 ` ✓ Fi.CI.BAT: success " Patchwork
2019-06-27 1:34 ` ✓ Fi.CI.IGT: " Patchwork
2019-06-27 8:06 ` drm/i915: last bits to make headers self-contained Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sgrwqr8j.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=michal.wajdeczko@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).