From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jani Nikula <jani.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Subject: Re: [PATCH v2 2/3] drm/dsc: Add native 420 and 422 support to
 compute_rc_params
Date: Mon, 25 Feb 2019 17:11:47 +0200
Message-ID: <87sgwbrjgs.fsf@intel.com>
References: <20190221202001.28430-1-David.Francis@amd.com>
 <20190221202001.28430-3-David.Francis@amd.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
In-Reply-To: <20190221202001.28430-3-David.Francis-5C7GfCeVMHo@public.gmane.org>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/amd-gfx>,
 <mailto:amd-gfx-request-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/amd-gfx>
List-Post: <mailto:amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
List-Help: <mailto:amd-gfx-request-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/amd-gfx>,
 <mailto:amd-gfx-request-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org?subject=subscribe>
Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Sender: "amd-gfx" <amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
To: dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Cc: manasi.d.navare-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, intel-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, David Francis <David.Francis-5C7GfCeVMHo@public.gmane.org>, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, nikola.cornij-5C7GfCeVMHo@public.gmane.org
List-Id: intel-gfx@lists.freedesktop.org

T24gVGh1LCAyMSBGZWIgMjAxOSwgRGF2aWQgRnJhbmNpcyA8RGF2aWQuRnJhbmNpc0BhbWQuY29t
PiB3cm90ZToKPiBOYXRpdmUgNDIwIGFuZCA0MjIgdHJhbnNmZXIgbW9kZXMgYXJlIG5ldyBpbiBE
U0MxLjIKPgo+IEluIHRoZXNlIG1vZGVzLCBlYWNoIHR3byBwaXhlbHMgb2YgYSBzbGljZSBhcmUg
dHJlYXRlZCBhcyBvbmUKPiBwaXhlbCwgc28gdGhlIHNsaWNlIHdpZHRoIGlzIGhhbGYgYXMgbGFy
Z2UgKHJvdW5kIGRvd24pIGZvcgo+IHRoZSBwdXJwb3NlcyBvZiBjYWx1Y2F0aW5nIHRoZSBncm91
cHMgcGVyIGxpbmUgYW5kIGNodW5rIHNpemUKPiBpbiBieXRlcwo+Cj4gSW4gbmF0aXZlIDQyMiBt
b2RlLCBlYWNoIHBpeGVsIGhhcyBmb3VyIGNvbXBvbmVudHMsIHNvIHRoZQo+IG11eCBjb21wb25l
bnQgb2YgYSBncm91cCBpcyBsYXJnZXIgYnkgb25lIGFkZGl0aW9uYWwgbXV4IHdvcmQKPiBhbmQg
b25lIGFkZGl0aW9uYWwgY29tcG9uZW50Cj4KPiBOb3cgdGhhdCB0aGVyZSBpcyBuYXRpdmUgNDIy
IHN1cHBvcnQsIHRoZSBjb25maWd1cmF0aW9uIG9wdGlvbgo+IHByZXZpb3VzbHkgY2FsbGVkIGVu
YWJsZTQyMiBpcyByZW5hbWVkIHRvIHNpbXBsZV80MjIgdG8gYXZvaWQKPiBjb25mdXNpb24KPgo+
IEFja2VkLWJ5OiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAaW50ZWwuY29tPgoKVGhpcyB3YXMg
cmVhbGx5IGZvciBwYXRjaCAxLzMgd2hlcmUgaXQgYWN0dWFsbHkgbWF0dGVycy4KCkJSLApKYW5p
LgoKPiBSZXZpZXdlZC1ieTogTWFuYXNpIE5hdmFyZSA8bWFuYXNpLmQubmF2YXJlQGludGVsLmNv
bT4KPiBSZXZpZXdlZC1ieTogSGFycnkgV2VudGxhbmQgPGhhcnJ5LndlbnRsYW5kQGFtZC5jb20+
Cj4gU2lnbmVkLW9mZi1ieTogRGF2aWQgRnJhbmNpcyA8RGF2aWQuRnJhbmNpc0BhbWQuY29tPgo+
IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX2RzYy5jICAgICAgICAgfCAzMyArKysrKysrKysr
KysrKysrKysrKysrLS0tLS0tLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Zkc2Mu
YyB8ICA0ICsrLS0KPiAgaW5jbHVkZS9kcm0vZHJtX2RzYy5oICAgICAgICAgICAgIHwgIDQgKyst
LQo+ICAzIGZpbGVzIGNoYW5nZWQsIDI4IGluc2VydGlvbnMoKyksIDEzIGRlbGV0aW9ucygtKQo+
Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fZHNjLmMgYi9kcml2ZXJzL2dwdS9k
cm0vZHJtX2RzYy5jCj4gaW5kZXggYjdmMTkwMzUwOGE0Li5kNzc1NzBiZjZhYzQgMTAwNjQ0Cj4g
LS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9kc2MuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9k
cm1fZHNjLmMKPiBAQCAtOTUsNyArOTUsNyBAQCB2b2lkIGRybV9kc2NfcHBzX2luZm9mcmFtZV9w
YWNrKHN0cnVjdCBkcm1fZHNjX3Bwc19pbmZvZnJhbWUgKnBwc19zZHAsCj4gIAkJKChkc2NfY2Zn
LT5iaXRzX3Blcl9waXhlbCAmIERTQ19QUFNfQlBQX0hJR0hfTUFTSykgPj4KPiAgCQkgRFNDX1BQ
U19NU0JfU0hJRlQpIHwKPiAgCQlkc2NfY2ZnLT52YnJfZW5hYmxlIDw8IERTQ19QUFNfVkJSX0VO
X1NISUZUIHwKPiAtCQlkc2NfY2ZnLT5lbmFibGU0MjIgPDwgRFNDX1BQU19TSU1QTEU0MjJfU0hJ
RlQgfAo+ICsJCWRzY19jZmctPnNpbXBsZV80MjIgPDwgRFNDX1BQU19TSU1QTEU0MjJfU0hJRlQg
fAo+ICAJCWRzY19jZmctPmNvbnZlcnRfcmdiIDw8IERTQ19QUFNfQ09OVkVSVF9SR0JfU0hJRlQg
fAo+ICAJCWRzY19jZmctPmJsb2NrX3ByZWRfZW5hYmxlIDw8IERTQ19QUFNfQkxPQ0tfUFJFRF9F
Tl9TSElGVDsKPiAgCj4gQEAgLTI0OSw3ICsyNDksNyBAQCBFWFBPUlRfU1lNQk9MKGRybV9kc2Nf
cHBzX2luZm9mcmFtZV9wYWNrKTsKPiAgLyoqCj4gICAqIGRybV9kc2NfY29tcHV0ZV9yY19wYXJh
bWV0ZXJzKCkgLSBXcml0ZSByYXRlIGNvbnRyb2wKPiAgICogcGFyYW1ldGVycyB0byB0aGUgZHNj
IGNvbmZpZ3VyYXRpb24gZGVmaW5lZCBpbgo+IC0gKiAmc3RydWN0IGRybV9kc2NfY29uZmlnIGlu
IGFjY29yZGFuY2Ugd2l0aCB0aGUgRFNDIDEuMQo+ICsgKiAmc3RydWN0IGRybV9kc2NfY29uZmln
IGluIGFjY29yZGFuY2Ugd2l0aCB0aGUgRFNDIDEuMgo+ICAgKiBzcGVjaWZpY2F0aW9uLiBTb21l
IGNvbmZpZ3VyYXRpb24gZmllbGRzIG11c3QgYmUgcHJlc2VudAo+ICAgKiBiZWZvcmVoYW5kLgo+
ICAgKgo+IEBAIC0yNjYsMTkgKzI2NiwzNCBAQCBpbnQgZHJtX2RzY19jb21wdXRlX3JjX3BhcmFt
ZXRlcnMoc3RydWN0IGRybV9kc2NfY29uZmlnICp2ZHNjX2NmZykKPiAgCXVuc2lnbmVkIGxvbmcg
ZmluYWxfc2NhbGUgPSAwOwo+ICAJdW5zaWduZWQgbG9uZyByYnNfbWluID0gMDsKPiAgCj4gLQkv
KiBOdW1iZXIgb2YgZ3JvdXBzIHVzZWQgdG8gY29kZSBlYWNoIGxpbmUgb2YgYSBzbGljZSAqLwo+
IC0JZ3JvdXBzX3Blcl9saW5lID0gRElWX1JPVU5EX1VQKHZkc2NfY2ZnLT5zbGljZV93aWR0aCwK
PiAtCQkJCSAgICAgICBEU0NfUkNfUElYRUxTX1BFUl9HUk9VUCk7Cj4gKwlpZiAodmRzY19jZmct
Pm5hdGl2ZV80MjAgfHwgdmRzY19jZmctPm5hdGl2ZV80MjIpIHsKPiArCQkvKiBOdW1iZXIgb2Yg
Z3JvdXBzIHVzZWQgdG8gY29kZSBlYWNoIGxpbmUgb2YgYSBzbGljZSAqLwo+ICsJCWdyb3Vwc19w
ZXJfbGluZSA9IERJVl9ST1VORF9VUCh2ZHNjX2NmZy0+c2xpY2Vfd2lkdGggLyAyLAo+ICsJCQkJ
CSAgICAgICBEU0NfUkNfUElYRUxTX1BFUl9HUk9VUCk7Cj4gIAo+IC0JLyogY2h1bmtzaXplIGlu
IEJ5dGVzICovCj4gLQl2ZHNjX2NmZy0+c2xpY2VfY2h1bmtfc2l6ZSA9IERJVl9ST1VORF9VUCh2
ZHNjX2NmZy0+c2xpY2Vfd2lkdGggKgo+IC0JCQkJCQkgIHZkc2NfY2ZnLT5iaXRzX3Blcl9waXhl
bCwKPiAtCQkJCQkJICAoOCAqIDE2KSk7Cj4gKwkJLyogY2h1bmtzaXplIGluIEJ5dGVzICovCj4g
KwkJdmRzY19jZmctPnNsaWNlX2NodW5rX3NpemUgPSBESVZfUk9VTkRfVVAodmRzY19jZmctPnNs
aWNlX3dpZHRoIC8gMiAqCj4gKwkJCQkJCQkgIHZkc2NfY2ZnLT5iaXRzX3Blcl9waXhlbCwKPiAr
CQkJCQkJCSAgKDggKiAxNikpOwo+ICsJfSBlbHNlIHsKPiArCQkvKiBOdW1iZXIgb2YgZ3JvdXBz
IHVzZWQgdG8gY29kZSBlYWNoIGxpbmUgb2YgYSBzbGljZSAqLwo+ICsJCWdyb3Vwc19wZXJfbGlu
ZSA9IERJVl9ST1VORF9VUCh2ZHNjX2NmZy0+c2xpY2Vfd2lkdGgsCj4gKwkJCQkJICAgICAgIERT
Q19SQ19QSVhFTFNfUEVSX0dST1VQKTsKPiArCj4gKwkJLyogY2h1bmtzaXplIGluIEJ5dGVzICov
Cj4gKwkJdmRzY19jZmctPnNsaWNlX2NodW5rX3NpemUgPSBESVZfUk9VTkRfVVAodmRzY19jZmct
PnNsaWNlX3dpZHRoICoKPiArCQkJCQkJCSAgdmRzY19jZmctPmJpdHNfcGVyX3BpeGVsLAo+ICsJ
CQkJCQkJICAoOCAqIDE2KSk7Cj4gKwl9Cj4gIAo+ICAJaWYgKHZkc2NfY2ZnLT5jb252ZXJ0X3Jn
YikKPiAgCQludW1fZXh0cmFfbXV4X2JpdHMgPSAzICogKHZkc2NfY2ZnLT5tdXhfd29yZF9zaXpl
ICsKPiAgCQkJCQkgICg0ICogdmRzY19jZmctPmJpdHNfcGVyX2NvbXBvbmVudCArIDQpCj4gIAkJ
CQkJICAtIDIpOwo+ICsJZWxzZSBpZiAodmRzY19jZmctPm5hdGl2ZV80MjIpCj4gKwkJbnVtX2V4
dHJhX211eF9iaXRzID0gNCAqIHZkc2NfY2ZnLT5tdXhfd29yZF9zaXplICsKPiArCQkJKDQgKiB2
ZHNjX2NmZy0+Yml0c19wZXJfY29tcG9uZW50ICsgNCkgKwo+ICsJCQkzICogKDQgKiB2ZHNjX2Nm
Zy0+Yml0c19wZXJfY29tcG9uZW50KSAtIDI7Cj4gIAllbHNlCj4gIAkJbnVtX2V4dHJhX211eF9i
aXRzID0gMyAqIHZkc2NfY2ZnLT5tdXhfd29yZF9zaXplICsKPiAgCQkJKDQgKiB2ZHNjX2NmZy0+
Yml0c19wZXJfY29tcG9uZW50ICsgNCkgKwo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v
aTkxNS9pbnRlbF92ZHNjLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF92ZHNjLmMKPiBp
bmRleCAyZDA1OWViYzliZDAuLjhjOGQ5NjE1NzMzMyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dw
dS9kcm0vaTkxNS9pbnRlbF92ZHNjLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl
bF92ZHNjLmMKPiBAQCAtMzY4LDcgKzM2OCw3IEBAIGludCBpbnRlbF9kcF9jb21wdXRlX2RzY19w
YXJhbXMoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCwKPiAgCQkJRFNDXzFfMV9NQVhfTElORUJV
Rl9ERVBUSF9CSVRTIDogbGluZV9idWZfZGVwdGg7Cj4gIAo+ICAJLyogR2VuIDExIGRvZXMgbm90
IHN1cHBvcnQgWUNiQ3IgKi8KPiAtCXZkc2NfY2ZnLT5lbmFibGU0MjIgPSBmYWxzZTsKPiArCXZk
c2NfY2ZnLT5zaW1wbGVfNDIyID0gZmFsc2U7Cj4gIAkvKiBHZW4gMTEgZG9lcyBub3Qgc3VwcG9y
dCBWQlIgKi8KPiAgCXZkc2NfY2ZnLT52YnJfZW5hYmxlID0gZmFsc2U7Cj4gIAl2ZHNjX2NmZy0+
YmxvY2tfcHJlZF9lbmFibGUgPQo+IEBAIC00OTUsNyArNDk1LDcgQEAgc3RhdGljIHZvaWQgaW50
ZWxfY29uZmlndXJlX3Bwc19mb3JfZHNjX2VuY29kZXIoc3RydWN0IGludGVsX2VuY29kZXIgKmVu
Y29kZXIsCj4gIAkJcHBzX3ZhbCB8PSBEU0NfQkxPQ0tfUFJFRElDVElPTjsKPiAgCWlmICh2ZHNj
X2NmZy0+Y29udmVydF9yZ2IpCj4gIAkJcHBzX3ZhbCB8PSBEU0NfQ09MT1JfU1BBQ0VfQ09OVkVS
U0lPTjsKPiAtCWlmICh2ZHNjX2NmZy0+ZW5hYmxlNDIyKQo+ICsJaWYgKHZkc2NfY2ZnLT5zaW1w
bGVfNDIyKQo+ICAJCXBwc192YWwgfD0gRFNDXzQyMl9FTkFCTEU7Cj4gIAlpZiAodmRzY19jZmct
PnZicl9lbmFibGUpCj4gIAkJcHBzX3ZhbCB8PSBEU0NfVkJSX0VOQUJMRTsKPiBkaWZmIC0tZ2l0
IGEvaW5jbHVkZS9kcm0vZHJtX2RzYy5oIGIvaW5jbHVkZS9kcm0vZHJtX2RzYy5oCj4gaW5kZXgg
NWE5OGI4ZGZkZjQzLi5mMjZhODllMWI2OGEgMTAwNjQ0Cj4gLS0tIGEvaW5jbHVkZS9kcm0vZHJt
X2RzYy5oCj4gKysrIGIvaW5jbHVkZS9kcm0vZHJtX2RzYy5oCj4gQEAgLTEwMSw5ICsxMDEsOSBA
QCBzdHJ1Y3QgZHJtX2RzY19jb25maWcgewo+ICAJICovCj4gIAl1MTYgc2xpY2VfaGVpZ2h0Owo+
ICAJLyoqCj4gLQkgKiBAZW5hYmxlNDIyOiBUcnVlIGZvciA0XzJfMiBzYW1wbGluZywgZmFsc2Ug
Zm9yIDRfNF80IHNhbXBsaW5nCj4gKwkgKiBAc2ltcGxlXzQyMjogVHJ1ZSBpZiBzaW1wbGUgNF8y
XzIgbW9kZSBpcyBlbmFibGVkIGVsc2UgRmFsc2UKPiAgCSAqLwo+IC0JYm9vbCBlbmFibGU0MjI7
Cj4gKwlib29sIHNpbXBsZV80MjI7Cj4gIAkvKioKPiAgCSAqIEBwaWNfd2lkdGg6IFdpZHRoIG9m
IHRoZSBpbnB1dCBkaXNwbGF5IGZyYW1lIGluIHBpeGVscwo+ICAJICovCgotLSAKSmFuaSBOaWt1
bGEsIEludGVsIE9wZW4gU291cmNlIEdyYXBoaWNzIENlbnRlcgpfX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fXwphbWQtZ2Z4IG1haWxpbmcgbGlzdAphbWQtZ2Z4
QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls
bWFuL2xpc3RpbmZvL2FtZC1nZng=