From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH 2/8] drm/i915: Defer removing fence register tracking to rpm wakeup Date: Thu, 07 Feb 2019 15:22:45 +0200 Message-ID: <87sgwz3f8a.fsf@gaia.fi.intel.com> References: <20190207071829.5574-1-chris@chris-wilson.co.uk> <20190207071829.5574-2-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4C3696E087 for ; Thu, 7 Feb 2019 13:22:55 +0000 (UTC) In-Reply-To: <20190207071829.5574-2-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+IHdyaXRlczoKCj4gQ3VycmVu dGx5LCB3ZSBtYXkgc2ltdWx0YW5lb3VzbHkgcmVsZWFzZSB0aGUgZmVuY2UgcmVnaXN0ZXIgZnJv bSBib3RoCj4gZmVuY2VfdXBkYXRlKCkgYW5kIGk5MTVfZ2VtX3Jlc3RvcmVfZmVuY2VzKCkuIFRo aXMgaXMgZGFuZ2Vyb3VzLCBzbwo+IGRlZmVyIHRoZSBib29ra2VlcGluZyBlbnRpcmVseSB0byBp OTE1X2dlbV9yZXN0b3JlX2ZlbmNlcygpIHdoZW4gdGhlCj4gZGV2aWNlIGlzIGFzbGVlcC4KPgo+ IFJlcG9ydGVkLWJ5OiBNaWthIEt1b3BwYWxhIDxtaWthLmt1b3BwYWxhQGxpbnV4LmludGVsLmNv bT4KPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51 az4KPiBDYzogTWlrYSBLdW9wcGFsYSA8bWlrYS5rdW9wcGFsYUBsaW51eC5pbnRlbC5jb20+Cj4g LS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2ZlbmNlX3JlZy5jIHwgNjIgKysr KysrKysrKysrLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDMyIGluc2VydGlvbnMoKyks IDMwIGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfZ2VtX2ZlbmNlX3JlZy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fZmVuY2Vf cmVnLmMKPiBpbmRleCBlMDM3ZTk0NzkyZjMuLmJlODliZDk1YWI3YyAxMDA2NDQKPiAtLS0gYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9mZW5jZV9yZWcuYwo+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2k5MTVfZ2VtX2ZlbmNlX3JlZy5jCj4gQEAgLTIxMCw2ICsyMTAsNyBAQCBz dGF0aWMgaW50IGZlbmNlX3VwZGF0ZShzdHJ1Y3QgZHJtX2k5MTVfZmVuY2VfcmVnICpmZW5jZSwK PiAgCQkJc3RydWN0IGk5MTVfdm1hICp2bWEpCj4gIHsKPiAgCWludGVsX3dha2VyZWZfdCB3YWtl cmVmOwo+ICsJc3RydWN0IGk5MTVfdm1hICpvbGQ7Cj4gIAlpbnQgcmV0Owo+ICAKPiAgCWlmICh2 bWEpIHsKPiBAQCAtMjI5LDQ5ICsyMzAsNTUgQEAgc3RhdGljIGludCBmZW5jZV91cGRhdGUoc3Ry dWN0IGRybV9pOTE1X2ZlbmNlX3JlZyAqZmVuY2UsCj4gIAkJCXJldHVybiByZXQ7Cj4gIAl9Cj4g IAo+IC0JaWYgKGZlbmNlLT52bWEpIHsKPiAtCQlzdHJ1Y3QgaTkxNV92bWEgKm9sZCA9IGZlbmNl LT52bWE7Cj4gLQo+ICsJb2xkID0geGNoZygmZmVuY2UtPnZtYSwgTlVMTCk7CgpTbyB0aGlzIGlz IGZvciByZXN0b3JlIHNlZWluZyBmZW5jZSBjb25zaXN0ZW50bHkuCgo+ICsJaWYgKG9sZCkgewo+ ICAJCXJldCA9IGk5MTVfYWN0aXZlX3JlcXVlc3RfcmV0aXJlKCZvbGQtPmxhc3RfZmVuY2UsCj4g IAkJCQkJICAgICAmb2xkLT5vYmotPmJhc2UuZGV2LT5zdHJ1Y3RfbXV0ZXgpOwo+IC0JCWlmIChy ZXQpCj4gKwkJaWYgKHJldCkgewo+ICsJCQlmZW5jZS0+dm1hID0gb2xkOwoKQW5kIHRoaXMgdGhl biB3b24ndCBtYXR0ZXIgYXMgdGhlIHJlc3RvcmUgZmVuY2VzIGhhZCB6ZXJvZWQKdGhlIGZlbmNl IHJlZyBiZWZvcmUgZXJyb3IuIFdlIGdldCBiYWNrIHRvIGV4YWN0IHN0YXRlCmxhdGVyIGJ1dCB3 aGVuPwoKPiAgCQkJcmV0dXJuIHJldDsKPiArCQl9Cj4gIAo+ICAJCWk5MTVfdm1hX2ZsdXNoX3dy aXRlcyhvbGQpOwo+IC0JfQo+ICAKPiAtCWlmIChmZW5jZS0+dm1hICYmIGZlbmNlLT52bWEgIT0g dm1hKSB7Cj4gLQkJLyogRW5zdXJlIHRoYXQgYWxsIHVzZXJzcGFjZSBDUFUgYWNjZXNzIGlzIGNv bXBsZXRlZCBiZWZvcmUKPiArCQkvKgo+ICsJCSAqIEVuc3VyZSB0aGF0IGFsbCB1c2Vyc3BhY2Ug Q1BVIGFjY2VzcyBpcyBjb21wbGV0ZWQgYmVmb3JlCj4gIAkJICogc3RlYWxpbmcgdGhlIGZlbmNl Lgo+ICAJCSAqLwo+IC0JCUdFTV9CVUdfT04oZmVuY2UtPnZtYS0+ZmVuY2UgIT0gZmVuY2UpOwo+ IC0JCWk5MTVfdm1hX3Jldm9rZV9tbWFwKGZlbmNlLT52bWEpOwo+IC0KPiAtCQlmZW5jZS0+dm1h LT5mZW5jZSA9IE5VTEw7Cj4gLQkJZmVuY2UtPnZtYSA9IE5VTEw7Cj4gKwkJaWYgKG9sZCAhPSB2 bWEpIHsKPiArCQkJR0VNX0JVR19PTihvbGQtPmZlbmNlICE9IGZlbmNlKTsKPiArCQkJaTkxNV92 bWFfcmV2b2tlX21tYXAob2xkKTsKPiArCQkJb2xkLT5mZW5jZSA9IE5VTEw7Cj4gKwkJfQo+ICAK PiAgCQlsaXN0X21vdmUoJmZlbmNlLT5saW5rLCAmZmVuY2UtPmk5MTUtPm1tLmZlbmNlX2xpc3Qp Owo+ICAJfQo+ICAKPiAtCS8qIFdlIG9ubHkgbmVlZCB0byB1cGRhdGUgdGhlIHJlZ2lzdGVyIGl0 c2VsZiBpZiB0aGUgZGV2aWNlIGlzIGF3YWtlLgo+ICsJLyoKPiArCSAqIFdlIG9ubHkgbmVlZCB0 byB1cGRhdGUgdGhlIHJlZ2lzdGVyIGl0c2VsZiBpZiB0aGUgZGV2aWNlIGlzIGF3YWtlLgo+ICAJ ICogSWYgdGhlIGRldmljZSBpcyBjdXJyZW50bHkgcG93ZXJlZCBkb3duLCB3ZSB3aWxsIGRlZmVy IHRoZSB3cml0ZQo+ICAJICogdG8gdGhlIHJ1bnRpbWUgcmVzdW1lLCBzZWUgaTkxNV9nZW1fcmVz dG9yZV9mZW5jZXMoKS4KPiArCSAqCj4gKwkgKiBUaGlzIG9ubHkgd29ya3MgZm9yIHJlbW92aW5n IHRoZSBmZW5jZSByZWdpc3Rlciwgb24gYWNxdWlzaXRpb24KPiArCSAqIHRoZSBjYWxsZXIgbXVz dCBob2xkIHRoZSBycG0gd2FrZXJlZi4gVGhlIGZlbmNlIHJlZ2lzdGVyIG11c3QKPiArCSAqIGJl IGNsZWFyZWQgYmVmb3JlIHdlIGNhbiB1c2UgYW55IG90aGVyIGZlbmNlcyB0byBlbnN1cmUgdGhh dAo+ICsJICogdGhlIG5ldyBmZW5jZXMgZG8gbm90IG92ZXJsYXAgdGhlIGVsaWRlZCBjbGVhcnMs IGNvbmZ1c2luZyBIVy4KPiAgCSAqLwo+ICAJd2FrZXJlZiA9IGludGVsX3J1bnRpbWVfcG1fZ2V0 X2lmX2luX3VzZShmZW5jZS0+aTkxNSk7Cj4gLQlpZiAod2FrZXJlZikgewo+IC0JCWZlbmNlX3dy aXRlKGZlbmNlLCB2bWEpOwo+IC0JCWludGVsX3J1bnRpbWVfcG1fcHV0KGZlbmNlLT5pOTE1LCB3 YWtlcmVmKTsKPiArCWlmICghd2FrZXJlZikgewo+ICsJCUdFTV9CVUdfT04odm1hKTsKPiArCQly ZXR1cm4gMDsKPiAgCX0KPiAgCj4gLQlpZiAodm1hKSB7Cj4gLQkJaWYgKGZlbmNlLT52bWEgIT0g dm1hKSB7Cj4gLQkJCXZtYS0+ZmVuY2UgPSBmZW5jZTsKPiAtCQkJZmVuY2UtPnZtYSA9IHZtYTsK PiAtCQl9Cj4gKwlmZW5jZV93cml0ZShmZW5jZSwgdm1hKTsKPiArCWZlbmNlLT52bWEgPSB2bWE7 Cj4gIAo+ICsJaWYgKHZtYSkgewo+ICsJCXZtYS0+ZmVuY2UgPSBmZW5jZTsKPiAgCQlsaXN0X21v dmVfdGFpbCgmZmVuY2UtPmxpbmssICZmZW5jZS0+aTkxNS0+bW0uZmVuY2VfbGlzdCk7Cj4gIAl9 Cj4gIAo+ICsJaW50ZWxfcnVudGltZV9wbV9wdXQoZmVuY2UtPmk5MTUsIHdha2VyZWYpOwo+ICAJ cmV0dXJuIDA7Cj4gIH0KPiAgCj4gQEAgLTQ3Myw5ICs0ODAsMTAgQEAgdm9pZCBpOTE1X2dlbV9y ZXN0b3JlX2ZlbmNlcyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gIHsKPiAg CWludCBpOwo+ICAKPiArCXJjdV9yZWFkX2xvY2soKTsgLyoga2VlcCBvYmogYWxpdmUgYXMgd2Ug ZGVyZWZlcmVuY2UgKi8KPiAgCWZvciAoaSA9IDA7IGkgPCBkZXZfcHJpdi0+bnVtX2ZlbmNlX3Jl Z3M7IGkrKykgewo+ICAJCXN0cnVjdCBkcm1faTkxNV9mZW5jZV9yZWcgKnJlZyA9ICZkZXZfcHJp di0+ZmVuY2VfcmVnc1tpXTsKCkkgZG8gaGF2ZSBzcGVudCBzb21lIGFtb3VudCBvZiB0aW1lIHRv IHRyeSB0byBmaWd1cmUgb3V0IGlmCnRoZXJlIGlzIGEgcmVhc29uaW5nIG9mIHNvbWV0aW1lcyBj YWxsaW5nIHRoZSBmZW5jZSByZWcgYXMgJ2ZlbmNlJwphbmQgaW4gb3RoZXIgY2FzZXMgJ3JlZycu CgpJZiB0aGVyZSBpcyBhIHJlYXNvbiwgaGVscCBtZSBvdXQuIElmIHRoZXJlIGlzIG5vdCwgSQpw b2xpdGVseSBhc2sgdG8gZm9sbG93IHRoZSBzYW1lIG5hbWluZyB0aGFuIGluIHJldm9rZV9mZW5j ZXMuCgpPciB0aGF0IHdlIGdvIGZvciAnZmVuY2VfcmVnJyBhbHdheXMgd2hlbiB0YWxraW5nIGFi b3V0CnByZWFsbG9jYXRlZCByZWcgc2xvdHMuCgo+IC0JCXN0cnVjdCBpOTE1X3ZtYSAqdm1hID0g cmVnLT52bWE7Cj4gKwkJc3RydWN0IGk5MTVfdm1hICp2bWEgPSBSRUFEX09OQ0UocmVnLT52bWEp Owo+ICAKPiAgCQlHRU1fQlVHX09OKHZtYSAmJiB2bWEtPmZlbmNlICE9IHJlZyk7Cj4gIAo+IEBA IC00ODMsMTggKzQ5MSwxMiBAQCB2b2lkIGk5MTVfZ2VtX3Jlc3RvcmVfZmVuY2VzKHN0cnVjdCBk cm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAgCQkgKiBDb21taXQgZGVsYXllZCB0aWxpbmcg Y2hhbmdlcyBpZiB3ZSBoYXZlIGFuIG9iamVjdCBzdGlsbAo+ICAJCSAqIGF0dGFjaGVkIHRvIHRo ZSBmZW5jZSwgb3RoZXJ3aXNlIGp1c3QgY2xlYXIgdGhlIGZlbmNlLgo+ICAJCSAqLwo+IC0JCWlm ICh2bWEgJiYgIWk5MTVfZ2VtX29iamVjdF9pc190aWxlZCh2bWEtPm9iaikpIHsKPiAtCQkJR0VN X0JVR19PTighcmVnLT5kaXJ0eSk7CgpZb3Ugb21pdCB0aGUgZGlydHkgY2hlY2sgaGVyZS4gSWYg dGhlIHJlYXNvbmluZyBpcwp0aGF0IHdlIGNhbid0IHNhbXBsZSBkdWUgdG8gaW5jb25zdGVuY3kg d3J0IHJlc3Qgb2YgZmVuY2UgcmVnLApkb2VzIGl0IHRoZW4gbGVhZCB0byBuZWVkIHRvIG1ha2Ug YSBfX2ZlbmNlX3dyaXRlKCkKdGhhdCBkb2VzIG5vdCB3cml0ZSB0aGUgZGlydHkgZmxhZy4KCkZv ciBtYWtpbmcgc3VyZSB0aGF0IGZvciBuZXh0IHBpbiB3b24ndCBkcm9wIHRoZSB3cml0ZT8KCj4g LQkJCUdFTV9CVUdfT04oaTkxNV92bWFfaGFzX3VzZXJmYXVsdCh2bWEpKTsKPiAtCj4gLQkJCWxp c3RfbW92ZSgmcmVnLT5saW5rLCAmZGV2X3ByaXYtPm1tLmZlbmNlX2xpc3QpOwoKVGhpcyBtYWtl cyBsaWZlIGVhc2llci4KCj4gLQkJCXZtYS0+ZmVuY2UgPSBOVUxMOwo+ICsJCWlmICh2bWEgJiYg IWk5MTVfZ2VtX29iamVjdF9pc190aWxlZCh2bWEtPm9iaikpCj4gIAkJCXZtYSA9IE5VTEw7Cj4g LQkJfQo+ICAKPiAgCQlmZW5jZV93cml0ZShyZWcsIHZtYSk7Cj4gLQkJcmVnLT52bWEgPSB2bWE7 Cj4gIAl9Cj4gKwlyY3VfcmVhZF91bmxvY2soKTsKPiAgfQo+ICAKPiAgLyoqCj4gLS0gCj4gMi4y MC4xCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVs LWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=