From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm/i915: encourage BIT() macro usage in register definitions Date: Thu, 28 Jun 2018 15:03:15 +0300 Message-ID: <87sh57rud8.fsf@intel.com> References: <20180627144113.6989-1-jani.nikula@intel.com> <153011517949.8693.5606799904077354457@mail.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 59FC36ED26 for ; Thu, 28 Jun 2018 12:03:29 +0000 (UTC) In-Reply-To: <153011517949.8693.5606799904077354457@mail.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , Michal Wajdeczko , intel-gfx@lists.freedesktop.org Cc: Paulo Zanoni List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCAyNyBKdW4gMjAxOCwgQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28u dWs+IHdyb3RlOgo+IFF1b3RpbmcgTWljaGFsIFdhamRlY3prbyAoMjAxOC0wNi0yNyAxNjo1MTo0 MikKPj4gT24gV2VkLCAyNyBKdW4gMjAxOCAxNjo0MToxMyArMDIwMCwgSmFuaSBOaWt1bGEgPGph bmkubmlrdWxhQGludGVsLmNvbT4gIAo+PiB3cm90ZToKPj4gCj4+ID4gVGhlcmUncyBhbHJlYWR5 IHNvbWUgQklUKCkgdXNhZ2UgaGVyZSBhbmQgdGhlcmUsIGVtYnJhY2UgaXQuCj4+ID4KPj4gPiBD YzogUGF1bG8gWmFub25pIDxwYXVsby5yLnphbm9uaUBpbnRlbC5jb20+Cj4+ID4gU2lnbmVkLW9m Zi1ieTogSmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGludGVsLmNvbT4KPj4gPiAtLS0KPj4gPiAg ZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZWcuaCB8IDkgKysrKystLS0tCj4+ID4gIDEgZmls ZSBjaGFuZ2VkLCA1IGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0pCj4+ID4KPj4gPiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZWcuaCAgCj4+ID4gYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oCj4+ID4gaW5kZXggNDc2MTE4ZjQ2Y2YzLi42NGI5YzI3 MDA0NWQgMTAwNjQ0Cj4+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZWcuaAo+ PiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmgKPj4gPiBAQCAtNjUsOSAr NjUsMTAgQEAKPj4gPiAgICogYnV0IGRvIG5vdGUgdGhhdCB0aGUgbWFjcm9zIG1heSBiZSBuZWVk ZWQgdG8gcmVhZCBhcyB3ZWxsIGFzIHdyaXRlICAKPj4gPiB0aGUKPj4gPiAgICogcmVnaXN0ZXIg Y29udGVudHMuCj4+ID4gICAqCj4+ID4gLSAqIERlZmluZSBiaXRzIHVzaW5nIGBgKDEgPDwgTilg YCBpbnN0ZWFkIG9mIGBgQklUKE4pYGAuIFdlIG1heSBjaGFuZ2UgIAo+PiA+IHRoaXMgaW4KPj4g PiAtICogdGhlIGZ1dHVyZSwgYnV0IHRoaXMgaXMgdGhlIHByZXZhaWxpbmcgc3R5bGUuIERvICoq bm90KiogYWRkICAKPj4gPiBgYF9CSVRgYCBzdWZmaXgKPj4gPiAtICogdG8gdGhlIG5hbWUuCj4+ ID4gKyAqIERlZmluZSBiaXRzIHVzaW5nIGBgQklUKE4pYGAgaW5zdGVhZCBvZiBgYCgxIDw8IE4p YGAuIERvICoqbm90KiogYWRkICAKPj4gPiBgYF9CSVRgYAo+PiA+ICsgKiBzdWZmaXggdG8gdGhl IG5hbWUuIEV4Y2VwdGlvbiB0byBgYEJJVCgpYGAgdXNhZ2U6IFZhbHVlIDEgZm9yIGEgYml0ICAK Pj4gPiBmaWVsZAo+PiA+ICsgKiBzaG91bGQgYmUgZGVmaW5lZCB1c2luZyBgYCgxIDw8IE4pYGAg dG8gYmUgaW4gbGluZSB3aXRoIG90aGVyIHZhbHVlcyAgCj4+ID4gc3VjaCBhcwo+PiA+ICsgKiBg YCgyIDw8IE4pYGAgZm9yIHRoZSBzYW1lIGZpZWxkLgo+PiA+ICAgKgo+PiA+ICAgKiBHcm91cCB0 aGUgcmVnaXN0ZXIgYW5kIGl0cyBjb250ZW50cyB0b2dldGhlciB3aXRob3V0IGJsYW5rIGxpbmVz LCAgCj4+ID4gc2VwYXJhdGUKPj4gPiAgICogZnJvbSBvdGhlciByZWdpc3RlcnMgYW5kIHRoZWly IGNvbnRlbnRzIHdpdGggb25lIGJsYW5rIGxpbmUuCj4+ID4gQEAgLTEwNSw3ICsxMDYsNyBAQAo+ PiA+ICAgKiAgI2RlZmluZSBfRk9PX0EgICAgICAgICAgICAgICAgICAgICAgMHhmMDAwCj4+ID4g ICAqICAjZGVmaW5lIF9GT09fQiAgICAgICAgICAgICAgICAgICAgICAweGYwMDEKPj4gPiAgICog ICNkZWZpbmUgRk9PKHBpcGUpICAgICAgICAgICAgICAgICAgIF9NTUlPX1BJUEUocGlwZSwgX0ZP T19BLCBfRk9PX0IpCj4+ID4gLSAqICAjZGVmaW5lICAgRk9PX0VOQUJMRSAgICAgICAgICAgICAg ICAoMSA8PCAzMSkKPj4gPiArICogICNkZWZpbmUgICBGT09fRU5BQkxFICAgICAgICAgICAgICAg IEJJVCgzMSkKPj4gCj4+IGhtbSwgdGhpcyBicmVha3MgbmljZSBjb25zaXN0ZW5jeSBiZXR3ZWVu IG9uZS0gYW5kIG11bHRpLWJpdCBmaWVsZHMgLi4KPj4gCj4+ID4gICAqICAjZGVmaW5lICAgRk9P X01PREVfTUFTSyAgICAgICAgICAgICAoMHhmIDw8IDE2KQo+PiAKPj4gLi4gYnV0IGlmIHlvdSB3 YW50IHRvIHVzZSBtYWNybyBmb3Igc2luZ2xlIGJpdCwgdGhlbiBtYXliZSB5b3Ugc2hvdWxkCj4+ IGFsc28gY29uc2lkZXIgb3RoZXIgZXhpc3RpbmcgbWFjcm8gZm9yIHRoZSBtYXNrIGRlZmluaXRp b246Cj4+IAo+PiAgICAgICAgICNkZWZpbmUgICBGT09fTU9ERV9NQVNLICAgICAgICAgICAgIEdF Tk1BU0soMTksIDE2KQo+PiAKPj4gPiAgICogICNkZWZpbmUgICBGT09fTU9ERV9TSElGVCAgICAg ICAgICAgIDE2Cj4+ID4gICAqICAjZGVmaW5lICAgRk9PX01PREVfQkFSICAgICAgICAgICAgICAo MCA8PCAxNikKPj4gCj4+IC4uIGJ1dCB3ZSBzdGlsbCBkb24ndCBoYXZlIGFueSBtYWNybyBmb3Ig ZGVmaW5pbmcgbXVsdGktYml0IHZhbHVlcwo+PiBzbyBJJ20gbm90IHN1cmUgaWYgdGhpcyBjaGFu Z2Ugd2lsbCBtYWtlIGNvZGUgcmVhbGx5IGVhc2llciB0byByZWFkCj4KPiAjaW5jbHVkZSA8bGlu dXgvYml0ZmllbGQuaD4KPgo+IEknbSBub3Qgc3VyZSBpZiBJJ20gcmVhZHkgdG8gZW1icmFjZSB0 aGF0IHlldCwgYnV0IGl0IGRvZXMgc2VlbSB0byBiZQo+IHRoZSBkaXJlY3Rpb24gd2Ugc2hvdWxk IGJlIGhlYWRpbmcgaW4uIFByaW1hcmlseSB0byBjaGVjayB0aGUgaW52YWxpZAo+IHJhbmdlIGNo ZWNraW5nICYgdXNhZ2UuCgpJIGd1ZXNzIHRoZXJlIGFyZSB0d28gdGhpbmdzIGhlcmUuIFVzaW5n IGJpdGZpZWxkLmggbWFjcm9zIHRvIGRlZmluZSBvdXIKb3duIHN0dWZmIGlzIG9uZSB0aGluZywg bGlrZSBzbzoKCiNkZWZpbmUgICBGT09fRU5BQkxFICAgICAgICAgICAgICAgIEJJVCgzMSkKI2Rl ZmluZSAgIEZPT19NT0RFX01BU0sgICAgICAgICAgICAgR0VOTUFTSygxOSwgMTYpCiNkZWZpbmUg ICBGT09fTU9ERV9TSElGVCAgICAgICAgICAgIDE2CiNkZWZpbmUgICBGT09fTU9ERV9CQVIgICAg ICAgICAgICAgIEZJRUxEX1BSRVAoRk9PX01PREVfTUFTSywgMCkKI2RlZmluZSAgIEZPT19NT0RF X0JBWiAgICAgICAgICAgICAgRklFTERfUFJFUChGT09fTU9ERV9NQVNLLCAxKQojZGVmaW5lICAg Rk9PX01PREVfUVVYX1NOQiAgICAgICAgICBGSUVMRF9QUkVQKEZPT19NT0RFX01BU0ssIDIpCgpU aGUgcmFuZ2UgY2hlY2tpbmcgaXMgaW5kZWVkIGFuIGFkdmFudGFnZS4KClVzaW5nIEZJRUxEX1BS RVAoKSBvciBGSUVMRF9HRVQoKSBpbiBjb2RlIGlzIGFub3RoZXIsIGJlY2F1c2Ugd2UKY3VycmVu dGx5IGRvbid0IGRlZmluZSB0aGUgKnVuc2hpZnRlZCogZmllbGQgdmFsdWVzLiBFdmVyeXRoaW5n IGlzCmRlZmluZWQgd2l0aCB0aGUgc2hpZnQuIERlZmluaW5nIGV2ZXJ5dGhpbmcgdW5zaGlmdGVk IGFuZCB0aGVuIG1vdmluZwp0aGUgRklFTERfUFJFUCgpIGFuZCBGSUVMRF9HRVQoKSBpbiBjb2Rl IHdvdWxkIGJlIHF1aXRlIHRoZSBjaGFuZ2UuCgpCUiwKSmFuaS4KCi0tIApKYW5pIE5pa3VsYSwg SW50ZWwgT3BlbiBTb3VyY2UgR3JhcGhpY3MgQ2VudGVyCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4 QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=