From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH 2/2] drm/i915: Fix DSI panels with v1 MIPI sequences without a DEASSERT sequence v3 Date: Fri, 02 Feb 2018 20:48:07 +0200 Message-ID: <87shajrzx4.fsf@intel.com> References: <20180129144735.32412-1-hdegoede@redhat.com> <20180129144735.32412-2-hdegoede@redhat.com> <20180202161738.GE5453@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180202161738.GE5453@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville =?utf-8?B?U3lyasOkbMOk?= , Hans de Goede Cc: Jan-Michael Brummer , intel-gfx , dri-devel@lists.freedesktop.org, Hans de Goede , Rodrigo Vivi List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCAwMiBGZWIgMjAxOCwgVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4 LmludGVsLmNvbT4gd3JvdGU6Cj4gT24gTW9uLCBKYW4gMjksIDIwMTggYXQgMDM6NDc6MzVQTSAr MDEwMCwgSGFucyBkZSBHb2VkZSB3cm90ZToKPj4gU28gZmFyIG1vZGVscyBvZiB0aGUgRGVsbCBW ZW51ZSA4IFBybywgd2l0aCBhIHBhbmVsIHdpdGggTUlQSSBwYW5lbAo+PiBpbmRleCA9IDMsIG9u ZSBvZiB3aGljaCBoYXMgYmVlbiBraW5kbHkgcHJvdmlkZWQgdG8gbWUgYnkgSmFuIEJydW1tZXIs Cj4+IHdoZXJlIG5vdCB3b3JraW5nIHdpdGggdGhlIGk5MTUgZHJpdmVyLCBnaXZpbmcgYSBibGFj ayBzY3JlZW4gb24gdGhlCj4+IGZpcnN0IG1vZGVzZXQuCj4+IAo+PiBUaGUgcHJvYmxlbSB3aXRo IGF0IGxlYXN0IHRoZXNlIERlbGxzIGlzIHRoYXQgdGhlaXIgVkJUIGRlZmluZXMgYSBNSVBJCj4+ IEFTU0VSVCBzZXF1ZW5jZSwgYnV0IG5vdCBhIERFQVNTRVJUIHNlcXVlbmNlLiBJbnN0ZWFkIHRo ZXkgREVBU1NFUlQgdGhlCj4+IHJlc2V0IGluIHRoZWlyIElOSVRfT1RQIHNlcXVlbmNlLCBidXQg dGhlIGRlYXNzZXJ0IG11c3QgYmUgZG9uZSBiZWZvcmUKPj4gY2FsbGluZyBpbnRlbF9kc2lfZGV2 aWNlX3JlYWR5KCksIHNvIHRoYXQgaXMgdG9vIGxhdGUuCj4+IAo+PiBTaW1wbHkgZG9pbmcgdGhl IElOSVRfT1RQIHNlcXVlbmNlIGVhcmxpZXIgaXMgbm90IGVub3VnaCB0byBmaXggdGhpcywKPj4g YmVjYXVzZSB0aGUgSU5JVF9PVFAgc2VxdWVuY2UgYWxzbyBzZW5kcyB2YXJpb3VzIE1JUEkgcGFj a2V0cyB0byB0aGUKPj4gcGFuZWwsIHdoaWNoIGNhbiBvbmx5IGhhcHBlbiBhZnRlciBjYWxsaW5n IGludGVsX2RzaV9kZXZpY2VfcmVhZHkoKS4KPj4gCj4+IFRoaXMgY29tbWl0IGZpeGVzIHRoaXMg Ynkgc3BsaXR0aW5nIHRoZSBJTklUX09UUCBzZXF1ZW5jZSBpbnRvIGV2ZXJ5dGhpbmcKPj4gYmVm b3JlIHRoZSBmaXJzdCBEU0kgcGFja2V0IGFuZCBldmVyeXRoaW5nIGVsc2UsIGluY2x1ZGluZyB0 aGUgZmlyc3QgRFNJCj4+IHBhY2tldC4gVGhlIGZpcnN0IHBhcnQgKGV2ZXJ5dGhpbmcgYmVmb3Jl IHRoZSBmaXJzdCBEU0kgcGFja2V0KSBpcyB0aGVuCj4+IHVzZWQgYXMgZGVhc3NlcnQgc2VxdWVu Y2UuCj4+IAo+PiBDaGFuZ2VkIGluIHYyOgo+PiAtU3BsaXQgdGhlIGluaXQgT1RQIHNlcXVlbmNl IGludG8gYSBkZWFzc2VydCByZXNldCBhbmQgdGhlIGFjdHVhbCBpbml0Cj4+ICBPVFAgc2VxdWVu Y2UsIGluc3RlYWQgb2YgY2FsbGluZyBpdCBlYXJsaWVyIGFuZCB0aGVuIGhhdmluZyB0aGUgZmly c3QKPj4gIG1pcGlfZXhlY19zZW5kX3BhY2tldCgpIGNhbGwgY2FsbCBpbnRlbF9kc2lfZGV2aWNl X3JlYWR5KCkuCj4+IAo+PiBDaGFuZ2VzIGluIHYzOgo+PiAtTW92ZSB0aGUgd2hvbGUgc2hlYmFu ZyB0byBpbnRlbF9iaW9zLmMKPj4gCj4+IEJ1Z0xpbms6IGh0dHBzOi8vYnVncy5mcmVlZGVza3Rv cC5vcmcvc2hvd19idWcuY2dpP2lkPTgyODgwCj4KPiBCdWd6aWxsYToKPgo+PiBSZWxhdGVkOiBo dHRwczovL2J1Z3MuZnJlZWRlc2t0b3Aub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDEyMDUKPgo+IFJl ZmVyZW5jZXM6Cj4KPj4gQ2M6IEphbi1NaWNoYWVsIEJydW1tZXIgPGphbi5icnVtbWVyQHRhYm9z Lm9yZz4KPj4gUmVwb3J0ZWQtYnk6IEphbi1NaWNoYWVsIEJydW1tZXIgPGphbi5icnVtbWVyQHRh Ym9zLm9yZz4KPj4gVGVzdGVkLWJ5OiBIYW5zIGRlIEdvZWRlIDxoZGVnb2VkZUByZWRoYXQuY29t Pgo+PiBTaWduZWQtb2ZmLWJ5OiBIYW5zIGRlIEdvZWRlIDxoZGVnb2VkZUByZWRoYXQuY29tPgo+ Cj4gVGhpcyBvbmUgc2VlbXMgZ29vZCB0byBtZSwgYW5kIEphbmkgaGFzbid0IGNvbXBsYWluZWQg YWJvdXQgYW55dGhpbmcgc28KPiBSZXZpZXdlZC1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5z eXJqYWxhQGxpbnV4LmludGVsLmNvbT4KClRoYW5rcyBmb3IgaGlkaW5nIHRoaXMgaW4gb25lIHBs YWNlLgoKQWNrZWQtYnk6IEphbmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBpbnRlbC5jb20+CgoKPgo+ PiAtLS0KPj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmggICB8ICAxICsKPj4gIGRy aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Jpb3MuYyB8IDgzICsrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKwo+PiAgMiBmaWxlcyBjaGFuZ2VkLCA4NCBpbnNlcnRpb25zKCsp Cj4+IAo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaCBiL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPj4gaW5kZXggMDgxMTkwZGEwODE4Li4xZjM0 NjI2Njk1NmIgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgK Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+PiBAQCAtMTM0OSw2ICsx MzQ5LDcgQEAgc3RydWN0IGludGVsX3ZidF9kYXRhIHsKPj4gIAkJdTMyIHNpemU7Cj4+ICAJCXU4 ICpkYXRhOwo+PiAgCQljb25zdCB1OCAqc2VxdWVuY2VbTUlQSV9TRVFfTUFYXTsKPj4gKwkJdTgg KmRlYXNzZXJ0X3NlcTsgLyogVXNlZCBieSBmaXh1cF9taXBpX3NlcXVlbmNlcygpICovCj4+ICAJ fSBkc2k7Cj4+ICAKPj4gIAlpbnQgY3J0X2RkY19waW47Cj4+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9iaW9zLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9i aW9zLmMKPj4gaW5kZXggNjRhMGQ1NWRmMjhlLi5jY2E2MjBmOGRlYjYgMTAwNjQ0Cj4+IC0tLSBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Jpb3MuYwo+PiArKysgYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9iaW9zLmMKPj4gQEAgLTk0Nyw2ICs5NDcsODYgQEAgc3RhdGljIGludCBn b3RvX25leHRfc2VxdWVuY2VfdjMoY29uc3QgdTggKmRhdGEsIGludCBpbmRleCwgaW50IHRvdGFs KQo+PiAgCXJldHVybiAwOwo+PiAgfQo+PiAgCj4+ICsvKgo+PiArICogR2V0IGxlbiBvZiBwcmUt Zml4ZWQgZGVhc3NlcnQgZnJhZ21lbnQgZnJvbSBhIHYxIGluaXQgT1RQIHNlcXVlbmNlLAo+PiAr ICogc2tpcCBhbGwgZGVsYXkgKyBncGlvIG9wZXJhbmRzIGFuZCBzdG9wIGF0IHRoZSBmaXJzdCBE U0kgcGFja2V0IG9wLgo+PiArICovCj4+ICtzdGF0aWMgaW50IGdldF9pbml0X290cF9kZWFzc2Vy dF9mcmFnbWVudF9sZW4oc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+PiArewo+ PiArCWNvbnN0IHU4ICpkYXRhID0gZGV2X3ByaXYtPnZidC5kc2kuc2VxdWVuY2VbTUlQSV9TRVFf SU5JVF9PVFBdOwo+PiArCWludCBpbmRleCwgbGVuOwo+PiArCj4+ICsJaWYgKFdBUk5fT04oIWRh dGEgfHwgZGV2X3ByaXYtPnZidC5kc2kuc2VxX3ZlcnNpb24gIT0gMSkpCj4+ICsJCXJldHVybiAw Owo+PiArCj4+ICsJLyogaW5kZXggPSAxIHRvIHNraXAgc2VxdWVuY2UgYnl0ZSAqLwo+PiArCWZv ciAoaW5kZXggPSAxOyBkYXRhW2luZGV4XSAhPSBNSVBJX1NFUV9FTEVNX0VORDsgaW5kZXggKz0g bGVuKSB7Cj4+ICsJCXN3aXRjaCAoZGF0YVtpbmRleF0pIHsKPj4gKwkJY2FzZSBNSVBJX1NFUV9F TEVNX1NFTkRfUEtUOgo+PiArCQkJcmV0dXJuIGluZGV4ID09IDEgPyAwIDogaW5kZXg7Cj4+ICsJ CWNhc2UgTUlQSV9TRVFfRUxFTV9ERUxBWToKPj4gKwkJCWxlbiA9IDU7IC8qIDEgYnl0ZSBmb3Ig b3BlcmFuZCArIHVpbnQzMiAqLwo+PiArCQkJYnJlYWs7Cj4+ICsJCWNhc2UgTUlQSV9TRVFfRUxF TV9HUElPOgo+PiArCQkJbGVuID0gMzsgLyogMSBieXRlIGZvciBvcCwgMSBmb3IgZ3Bpb19uciwg MSBmb3IgdmFsdWUgKi8KPj4gKwkJCWJyZWFrOwo+PiArCQlkZWZhdWx0Ogo+PiArCQkJcmV0dXJu IDA7Cj4+ICsJCX0KPj4gKwl9Cj4+ICsKPj4gKwlyZXR1cm4gMDsKPj4gK30KPj4gKwo+PiArLyoK Pj4gKyAqIFNvbWUgdjEgVkJUIE1JUEkgc2VxdWVuY2VzIGRvIHRoZSBkZWFzc2VydCBpbiB0aGUg aW5pdCBPVFAgc2VxdWVuY2UuCj4+ICsgKiBUaGUgZGVhc3NlcnQgbXVzdCBiZSBkb25lIGJlZm9y ZSBjYWxsaW5nIGludGVsX2RzaV9kZXZpY2VfcmVhZHksIHNvIGZvcgo+PiArICogdGhlc2UgZGV2 aWNlcyB3ZSBzcGxpdCB0aGUgaW5pdCBPVFAgc2VxdWVuY2UgaW50byBhIGRlYXNzZXJ0IHNlcXVl bmNlIGFuZAo+PiArICogdGhlIGFjdHVhbCBpbml0IE9UUCBwYXJ0Lgo+PiArICovCj4+ICtzdGF0 aWMgdm9pZCBmaXh1cF9taXBpX3NlcXVlbmNlcyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2 X3ByaXYpCj4+ICt7Cj4+ICsJdTggKmluaXRfb3RwOwo+PiArCWludCBsZW47Cj4+ICsKPj4gKwkv KiBMaW1pdCB0aGlzIHRvIFZMViBmb3Igbm93LiAqLwo+PiArCWlmICghSVNfVkFMTEVZVklFVyhk ZXZfcHJpdikpCj4+ICsJCXJldHVybjsKPj4gKwo+PiArCS8qIExpbWl0IHRoaXMgdG8gdjEgdmlk LW1vZGUgc2VxdWVuY2VzICovCj4+ICsJaWYgKGRldl9wcml2LT52YnQuZHNpLmNvbmZpZy0+aXNf Y21kX21vZGUgfHwKPj4gKwkgICAgZGV2X3ByaXYtPnZidC5kc2kuc2VxX3ZlcnNpb24gIT0gMSkK Pj4gKwkJcmV0dXJuOwo+PiArCj4+ICsJLyogT25seSBkbyB0aGlzIGlmIHRoZXJlIGFyZSBvdHAg YW5kIGFzc2VydCBzZXFzIGFuZCBubyBkZWFzc2VydCBzZXEgKi8KPj4gKwlpZiAoIWRldl9wcml2 LT52YnQuZHNpLnNlcXVlbmNlW01JUElfU0VRX0lOSVRfT1RQXSB8fAo+PiArCSAgICAhZGV2X3By aXYtPnZidC5kc2kuc2VxdWVuY2VbTUlQSV9TRVFfQVNTRVJUX1JFU0VUXSB8fAo+PiArCSAgICBk ZXZfcHJpdi0+dmJ0LmRzaS5zZXF1ZW5jZVtNSVBJX1NFUV9ERUFTU0VSVF9SRVNFVF0pCj4+ICsJ CXJldHVybjsKPj4gKwo+PiArCS8qIFRoZSBkZWFzc2VydC1zZXF1ZW5jZSBlbmRzIGF0IHRoZSBm aXJzdCBEU0kgcGFja2V0ICovCj4+ICsJbGVuID0gZ2V0X2luaXRfb3RwX2RlYXNzZXJ0X2ZyYWdt ZW50X2xlbihkZXZfcHJpdik7Cj4+ICsJaWYgKCFsZW4pCj4+ICsJCXJldHVybjsKPj4gKwo+PiAr CURSTV9ERUJVR19LTVMoIlVzaW5nIGluaXQgT1RQIGZyYWdtZW50IHRvIGRlYXNzZXJ0IHJlc2V0 XG4iKTsKPj4gKwo+PiArCS8qIENvcHkgdGhlIGZyYWdtZW50LCB1cGRhdGUgc2VxIGJ5dGUgYW5k IHRlcm1pbmF0ZSBpdCAqLwo+PiArCWluaXRfb3RwID0gKHU4ICopZGV2X3ByaXYtPnZidC5kc2ku c2VxdWVuY2VbTUlQSV9TRVFfSU5JVF9PVFBdOwo+PiArCWRldl9wcml2LT52YnQuZHNpLmRlYXNz ZXJ0X3NlcSA9IGttZW1kdXAoaW5pdF9vdHAsIGxlbiArIDEsIEdGUF9LRVJORUwpOwo+PiArCWlm ICghZGV2X3ByaXYtPnZidC5kc2kuZGVhc3NlcnRfc2VxKQo+PiArCQlyZXR1cm47Cj4+ICsJZGV2 X3ByaXYtPnZidC5kc2kuZGVhc3NlcnRfc2VxWzBdID0gTUlQSV9TRVFfREVBU1NFUlRfUkVTRVQ7 Cj4+ICsJZGV2X3ByaXYtPnZidC5kc2kuZGVhc3NlcnRfc2VxW2xlbl0gPSBNSVBJX1NFUV9FTEVN X0VORDsKPj4gKwkvKiBVc2UgdGhlIGNvcHkgZm9yIGRlYXNzZXJ0ICovCj4+ICsJZGV2X3ByaXYt PnZidC5kc2kuc2VxdWVuY2VbTUlQSV9TRVFfREVBU1NFUlRfUkVTRVRdID0KPj4gKwkJZGV2X3By aXYtPnZidC5kc2kuZGVhc3NlcnRfc2VxOwo+PiArCS8qIFJlcGxhY2UgdGhlIGxhc3QgYnl0ZSBv ZiB0aGUgZnJhZ21lbnQgd2l0aCBpbml0IE9UUCBzZXEgYnl0ZSAqLwo+PiArCWluaXRfb3RwW2xl biAtIDFdID0gTUlQSV9TRVFfSU5JVF9PVFA7Cj4+ICsJLyogQW5kIG1ha2UgTUlQSV9NSVBJX1NF UV9JTklUX09UUCBwb2ludCB0byBpdCAqLwo+PiArCWRldl9wcml2LT52YnQuZHNpLnNlcXVlbmNl W01JUElfU0VRX0lOSVRfT1RQXSA9IGluaXRfb3RwICsgbGVuIC0gMTsKPj4gK30KPj4gKwo+PiAg c3RhdGljIHZvaWQKPj4gIHBhcnNlX21pcGlfc2VxdWVuY2Uoc3RydWN0IGRybV9pOTE1X3ByaXZh dGUgKmRldl9wcml2LAo+PiAgCQkgICAgY29uc3Qgc3RydWN0IGJkYl9oZWFkZXIgKmJkYikKPj4g QEAgLTEwMTYsNiArMTA5Niw4IEBAIHBhcnNlX21pcGlfc2VxdWVuY2Uoc3RydWN0IGRybV9pOTE1 X3ByaXZhdGUgKmRldl9wcml2LAo+PiAgCWRldl9wcml2LT52YnQuZHNpLnNpemUgPSBzZXFfc2l6 ZTsKPj4gIAlkZXZfcHJpdi0+dmJ0LmRzaS5zZXFfdmVyc2lvbiA9IHNlcXVlbmNlLT52ZXJzaW9u Owo+PiAgCj4+ICsJZml4dXBfbWlwaV9zZXF1ZW5jZXMoZGV2X3ByaXYpOwo+PiArCj4+ICAJRFJN X0RFQlVHX0RSSVZFUigiTUlQSSByZWxhdGVkIFZCVCBwYXJzaW5nIGNvbXBsZXRlXG4iKTsKPj4g IAlyZXR1cm47Cj4+ICAKPj4gQEAgLTE1OTQsNiArMTY3Niw3IEBAIHZvaWQgaW50ZWxfYmlvc19p bml0KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPj4gICAqLwo+PiAgdm9pZCBp bnRlbF9iaW9zX2NsZWFudXAoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+PiAg ewo+PiArCWtmcmVlKGRldl9wcml2LT52YnQuZHNpLmRlYXNzZXJ0X3NlcSk7Cj4+ICAJa2ZyZWUo ZGV2X3ByaXYtPnZidC5kc2kuZGF0YSk7Cj4+ICAJa2ZyZWUoZGV2X3ByaXYtPnZidC5kc2kucHBz KTsKPj4gIAlrZnJlZShkZXZfcHJpdi0+dmJ0LmRzaS5jb25maWcpOwo+PiAtLSAKPj4gMi4xNC4z CgotLSAKSmFuaSBOaWt1bGEsIEludGVsIE9wZW4gU291cmNlIFRlY2hub2xvZ3kgQ2VudGVyCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBt YWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=