From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Subject: Re: [PATCH v3 2/4] drm/i915: Make engine state
	pretty-printer header configurable
Date: Fri, 10 Nov 2017 14:27:41 +0200
Message-ID: <87shdmqpxe.fsf@gaia.fi.intel.com>
References: <20171109235407.5595-1-chris@chris-wilson.co.uk>
 <20171109235407.5595-2-chris@chris-wilson.co.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by gabe.freedesktop.org (Postfix) with ESMTPS id B23B96E045
 for <intel-gfx@lists.freedesktop.org>; Fri, 10 Nov 2017 12:27:46 +0000 (UTC)
In-Reply-To: <20171109235407.5595-2-chris@chris-wilson.co.uk>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+IHdyaXRlczoKCj4gUGFzcyBp
biBhIGZvcm1hdCBzdHJpbmcgKGFuZCBhcmdzKSB0byBzcGVjaWZ5IHRoZSBoZWFkZXIgdG8gYmUg
ZW1pdHRlZAo+IGFsb25nIHdpdGggdGhlIGVuZ2luZSBzdGF0ZSB3aGVuIHByZXR0eS1wcmludGlu
Zy4gVGhpcyBhbGxvd3MgdGhlIGhlYWRlcgo+IHRvIGJlIGVtaXR0ZWQgaW5zaWRlIHRoZSBkcm1f
cHJpbnRlciBzdHJlYW0sIHNvIHNoYXJpbmcgdGhlIHNhbWUgcHJlZml4Cj4gYW5kIG91dHB1dCBj
aGFyYWN0ZXJpc3RpY3MgKGUuZy4gZGVidWcgbGV2ZWwgYW5kIGZpbHRlcmluZykuCj4KPiBTaWdu
ZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KClJldmll
d2VkLWJ5OiBNaWthIEt1b3BwYWxhIDxtaWthLmt1b3BwYWxhQGxpbnV4LmludGVsLmNvbT4KCj4g
LS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZGVidWdmcy5jICAgICAgICAgICAgICB8
ICAyICstCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2VuZ2luZV9jcy5jICAgICAgICAg
ICB8IDE4ICsrKysrKysrKysrKy0tLS0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9y
aW5nYnVmZmVyLmggICAgICAgICAgfCAgNSArKysrLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9z
ZWxmdGVzdHMvaW50ZWxfaGFuZ2NoZWNrLmMgfCAyMSArKysrKysrKysrKystLS0tLS0tLS0KPiAg
NCBmaWxlcyBjaGFuZ2VkLCAyOSBpbnNlcnRpb25zKCspLCAxNyBkZWxldGlvbnMoLSkKPgo+IGRp
ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2RlYnVnZnMuYyBiL2RyaXZlcnMv
Z3B1L2RybS9pOTE1L2k5MTVfZGVidWdmcy5jCj4gaW5kZXggNTMzYmEwOTZiOWE2Li44YzVjNGYx
NjExNDcgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kZWJ1Z2ZzLmMK
PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2RlYnVnZnMuYwo+IEBAIC0zMjQ4LDcg
KzMyNDgsNyBAQCBzdGF0aWMgaW50IGk5MTVfZW5naW5lX2luZm8oc3RydWN0IHNlcV9maWxlICpt
LCB2b2lkICp1bnVzZWQpCj4gIAo+ICAJcCA9IGRybV9zZXFfZmlsZV9wcmludGVyKG0pOwo+ICAJ
Zm9yX2VhY2hfZW5naW5lKGVuZ2luZSwgZGV2X3ByaXYsIGlkKQo+IC0JCWludGVsX2VuZ2luZV9k
dW1wKGVuZ2luZSwgJnApOwo+ICsJCWludGVsX2VuZ2luZV9kdW1wKGVuZ2luZSwgJnAsICIlc1xu
IiwgZW5naW5lLT5uYW1lKTsKPiAgCj4gIAlpbnRlbF9ydW50aW1lX3BtX3B1dChkZXZfcHJpdik7
Cj4gIAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9lbmdpbmVfY3Mu
YyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2VuZ2luZV9jcy5jCj4gaW5kZXggNDAzY2M0
NzQ5MDA4Li41NGQxOTc4NGI2YWIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv
aW50ZWxfZW5naW5lX2NzLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9lbmdp
bmVfY3MuYwo+IEBAIC0xNjUyLDEyICsxNjUyLDEyIEBAIHZvaWQgaW50ZWxfZW5naW5lc19wYXJr
KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICppOTE1KQo+ICAJCSAqIHdpbGwgYmUgbm8gbW9yZSBp
bnRlcnJ1cHRzIGFycml2aW5nIGxhdGVyIGFuZCB0aGUgZW5naW5lcwo+ICAJCSAqIGFyZSB0cnVs
eSBpZGxlLgo+ICAJCSAqLwo+IC0JCWlmICghaW50ZWxfZW5naW5lX2lzX2lkbGUoZW5naW5lKSkg
ewo+ICsJCWlmIChHRU1fV0FSTl9PTighaW50ZWxfZW5naW5lX2lzX2lkbGUoZW5naW5lKSkpIHsK
PiAgCQkJc3RydWN0IGRybV9wcmludGVyIHAgPSBkcm1fZGVidWdfcHJpbnRlcihfX2Z1bmNfXyk7
Cj4gIAo+IC0JCQlEUk1fRVJST1IoIiVzIGlzIG5vdCBpZGxlIGJlZm9yZSBwYXJraW5nXG4iLAo+
IC0JCQkJICBlbmdpbmUtPm5hbWUpOwo+IC0JCQlpbnRlbF9lbmdpbmVfZHVtcChlbmdpbmUsICZw
KTsKPiArCQkJaW50ZWxfZW5naW5lX2R1bXAoZW5naW5lLCAmcCwKPiArCQkJCQkgICIlcyBpcyBu
b3QgaWRsZSBiZWZvcmUgcGFya2luZ1xuIiwKPiArCQkJCQkgIGVuZ2luZS0+bmFtZSk7Cj4gIAkJ
fQo+ICAKPiAgCQlpZiAoZW5naW5lLT5wYXJrKQo+IEBAIC0xNzI3LDcgKzE3MjcsOSBAQCBzdGF0
aWMgdm9pZCBwcmludF9yZXF1ZXN0KHN0cnVjdCBkcm1fcHJpbnRlciAqbSwKPiAgCQkgICBycS0+
dGltZWxpbmUtPmNvbW1vbi0+bmFtZSk7Cj4gIH0KPiAgCj4gLXZvaWQgaW50ZWxfZW5naW5lX2R1
bXAoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lLCBzdHJ1Y3QgZHJtX3ByaW50ZXIgKm0p
Cj4gK3ZvaWQgaW50ZWxfZW5naW5lX2R1bXAoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5l
LAo+ICsJCSAgICAgICBzdHJ1Y3QgZHJtX3ByaW50ZXIgKm0sCj4gKwkJICAgICAgIGNvbnN0IGNo
YXIgKmZtdCwgLi4uKQo+ICB7Cj4gIAlzdHJ1Y3QgaW50ZWxfYnJlYWRjcnVtYnMgKiBjb25zdCBi
ID0gJmVuZ2luZS0+YnJlYWRjcnVtYnM7Cj4gIAljb25zdCBzdHJ1Y3QgaW50ZWxfZW5naW5lX2V4
ZWNsaXN0cyAqIGNvbnN0IGV4ZWNsaXN0cyA9ICZlbmdpbmUtPmV4ZWNsaXN0czsKPiBAQCAtMTcz
NSw5ICsxNzM3LDEzIEBAIHZvaWQgaW50ZWxfZW5naW5lX2R1bXAoc3RydWN0IGludGVsX2VuZ2lu
ZV9jcyAqZW5naW5lLCBzdHJ1Y3QgZHJtX3ByaW50ZXIgKm0pCj4gIAlzdHJ1Y3QgZHJtX2k5MTVf
cHJpdmF0ZSAqZGV2X3ByaXYgPSBlbmdpbmUtPmk5MTU7Cj4gIAlzdHJ1Y3QgZHJtX2k5MTVfZ2Vt
X3JlcXVlc3QgKnJxOwo+ICAJc3RydWN0IHJiX25vZGUgKnJiOwo+ICsJdmFfbGlzdCBhcDsKPiAg
CXU2NCBhZGRyOwo+ICAKPiAtCWRybV9wcmludGYobSwgIiVzXG4iLCBlbmdpbmUtPm5hbWUpOwo+
ICsJdmFfc3RhcnQoYXAsIGZtdCk7Cj4gKwlkcm1fdnByaW50ZihtLCBmbXQsICZhcCk7Cj4gKwl2
YV9lbmQoYXApOwo+ICsKPiAgCWRybV9wcmludGYobSwgIlx0Y3VycmVudCBzZXFubyAleCwgbGFz
dCAleCwgaGFuZ2NoZWNrICV4IFslZCBtc10sIGluZmxpZ2h0ICVkXG4iLAo+ICAJCSAgIGludGVs
X2VuZ2luZV9nZXRfc2Vxbm8oZW5naW5lKSwKPiAgCQkgICBpbnRlbF9lbmdpbmVfbGFzdF9zdWJt
aXQoZW5naW5lKSwKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmlu
Z2J1ZmZlci5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5oCj4gaW5k
ZXggMmIwYWU1NDY4ZjQ4Li5hMWEzMzQ2NjY4M2IgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUv
ZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv
aW50ZWxfcmluZ2J1ZmZlci5oCj4gQEAgLTkzNiw2ICs5MzYsOSBAQCB1bnNpZ25lZCBpbnQgaW50
ZWxfZW5naW5lc19oYXNfY29udGV4dF9pc29sYXRpb24oc3RydWN0IGRybV9pOTE1X3ByaXZhdGUg
Kmk5MTUpOwo+ICAKPiAgYm9vbCBpbnRlbF9lbmdpbmVfY2FuX3N0b3JlX2R3b3JkKHN0cnVjdCBp
bnRlbF9lbmdpbmVfY3MgKmVuZ2luZSk7Cj4gIAo+IC12b2lkIGludGVsX2VuZ2luZV9kdW1wKHN0
cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSwgc3RydWN0IGRybV9wcmludGVyICpwKTsKPiAr
X19wcmludGYoMywgNCkKPiArdm9pZCBpbnRlbF9lbmdpbmVfZHVtcChzdHJ1Y3QgaW50ZWxfZW5n
aW5lX2NzICplbmdpbmUsCj4gKwkJICAgICAgIHN0cnVjdCBkcm1fcHJpbnRlciAqbSwKPiArCQkg
ICAgICAgY29uc3QgY2hhciAqZm10LCAuLi4pOwo+ICAKPiAgI2VuZGlmIC8qIF9JTlRFTF9SSU5H
QlVGRkVSX0hfICovCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L3NlbGZ0ZXN0
cy9pbnRlbF9oYW5nY2hlY2suYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L3NlbGZ0ZXN0cy9pbnRl
bF9oYW5nY2hlY2suYwo+IGluZGV4IDcxY2UwNjY4MGQ2Ni4uMThmMTgxYzQ2NDQzIDEwMDY0NAo+
IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L3NlbGZ0ZXN0cy9pbnRlbF9oYW5nY2hlY2suYwo+
ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L3NlbGZ0ZXN0cy9pbnRlbF9oYW5nY2hlY2suYwo+
IEBAIC02MjYsOSArNjI2LDEwIEBAIHN0YXRpYyBpbnQgaWd0X3dhaXRfcmVzZXQodm9pZCAqYXJn
KQo+ICAJaWYgKCF3YWl0X2Zvcl9oYW5nKCZoLCBycSkpIHsKPiAgCQlzdHJ1Y3QgZHJtX3ByaW50
ZXIgcCA9IGRybV9pbmZvX3ByaW50ZXIoaTkxNS0+ZHJtLmRldik7Cj4gIAo+IC0JCXByX2Vycigi
RmFpbGVkIHRvIHN0YXJ0IHJlcXVlc3QgJXgsIGF0ICV4XG4iLAo+IC0JCSAgICAgICBycS0+ZmVu
Y2Uuc2Vxbm8sIGh3c19zZXFubygmaCwgcnEpKTsKPiAtCQlpbnRlbF9lbmdpbmVfZHVtcChycS0+
ZW5naW5lLCAmcCk7Cj4gKwkJaW50ZWxfZW5naW5lX2R1bXAocnEtPmVuZ2luZSwgJnAsCj4gKwkJ
CQkgICIlczogRmFpbGVkIHRvIHN0YXJ0IHJlcXVlc3QgJXgsIGF0ICV4XG4iLAo+ICsJCQkJICBy
cS0+ZW5naW5lLT5uYW1lLAo+ICsJCQkJICBycS0+ZmVuY2Uuc2Vxbm8sIGh3c19zZXFubygmaCwg
cnEpKTsKPiAgCj4gIAkJaTkxNV9yZXNldChpOTE1LCAwKTsKPiAgCQlpOTE1X2dlbV9zZXRfd2Vk
Z2VkKGk5MTUpOwo+IEBAIC03MjEsOSArNzIyLDEwIEBAIHN0YXRpYyBpbnQgaWd0X3Jlc2V0X3F1
ZXVlKHZvaWQgKmFyZykKPiAgCQkJaWYgKCF3YWl0X2Zvcl9oYW5nKCZoLCBwcmV2KSkgewo+ICAJ
CQkJc3RydWN0IGRybV9wcmludGVyIHAgPSBkcm1faW5mb19wcmludGVyKGk5MTUtPmRybS5kZXYp
Owo+ICAKPiAtCQkJCXByX2VycigiRmFpbGVkIHRvIHN0YXJ0IHJlcXVlc3QgJXgsIGF0ICV4XG4i
LAo+IC0JCQkJICAgICAgIHByZXYtPmZlbmNlLnNlcW5vLCBod3Nfc2Vxbm8oJmgsIHByZXYpKTsK
PiAtCQkJCWludGVsX2VuZ2luZV9kdW1wKHJxLT5lbmdpbmUsICZwKTsKPiArCQkJCWludGVsX2Vu
Z2luZV9kdW1wKHJxLT5lbmdpbmUsICZwLAo+ICsJCQkJCQkgICIlczogRmFpbGVkIHRvIHN0YXJ0
IHJlcXVlc3QgJXgsIGF0ICV4XG4iLAo+ICsJCQkJCQkgIHByZXYtPmVuZ2luZS0+bmFtZSwKPiAr
CQkJCQkJICBwcmV2LT5mZW5jZS5zZXFubywgaHdzX3NlcW5vKCZoLCBwcmV2KSk7Cj4gIAo+ICAJ
CQkJaTkxNV9nZW1fcmVxdWVzdF9wdXQocnEpOwo+ICAJCQkJaTkxNV9nZW1fcmVxdWVzdF9wdXQo
cHJldik7Cj4gQEAgLTgyNyw5ICs4MjksMTAgQEAgc3RhdGljIGludCBpZ3RfaGFuZGxlX2Vycm9y
KHZvaWQgKmFyZykKPiAgCWlmICghd2FpdF9mb3JfaGFuZygmaCwgcnEpKSB7Cj4gIAkJc3RydWN0
IGRybV9wcmludGVyIHAgPSBkcm1faW5mb19wcmludGVyKGk5MTUtPmRybS5kZXYpOwo+ICAKPiAt
CQlwcl9lcnIoIkZhaWxlZCB0byBzdGFydCByZXF1ZXN0ICV4LCBhdCAleFxuIiwKPiAtCQkgICAg
ICAgcnEtPmZlbmNlLnNlcW5vLCBod3Nfc2Vxbm8oJmgsIHJxKSk7Cj4gLQkJaW50ZWxfZW5naW5l
X2R1bXAocnEtPmVuZ2luZSwgJnApOwo+ICsJCWludGVsX2VuZ2luZV9kdW1wKHJxLT5lbmdpbmUs
ICZwLAo+ICsJCQkJICAiJXM6IEZhaWxlZCB0byBzdGFydCByZXF1ZXN0ICV4LCBhdCAleFxuIiwK
PiArCQkJCSAgcnEtPmVuZ2luZS0+bmFtZSwKPiArCQkJCSAgcnEtPmZlbmNlLnNlcW5vLCBod3Nf
c2Vxbm8oJmgsIHJxKSk7Cj4gIAo+ICAJCWk5MTVfcmVzZXQoaTkxNSwgMCk7Cj4gIAkJaTkxNV9n
ZW1fc2V0X3dlZGdlZChpOTE1KTsKPiAtLSAKPiAyLjE1LjAKX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1n
ZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h
aWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==