From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Stop engines before reset
Date: Wed, 20 Sep 2017 14:24:07 +0300 [thread overview]
Message-ID: <87shfh1ulk.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <20170919144128.25506-1-mika.kuoppala@intel.com>
Mika Kuoppala <mika.kuoppala@linux.intel.com> writes:
> On kbl evidence indicates that even if the hardware happily
> tells us to proceed with reset, it really isn't ready.
> Resetting a freely running batchbuffer after we have ack for readiness,
> still can cause a system hang.
>
> We also have similar experiences on older gens. So now
> attempt to stop engines before proceeding for reset, on all
> gens where we have a gpu reset. This has shown to improve reset
> reliability and reduce the risk of losing the machine.
>
> v2: Add fixme for wa (Joonas)
>
> Testcase: igt/prime_busy/hang-* # kbl
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com>
> Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
> Acked-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Pushed, thanks for acks.
-Mika
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-09-20 11:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-19 14:41 [PATCH] drm/i915: Stop engines before reset Mika Kuoppala
2017-09-19 19:14 ` ✓ Fi.CI.BAT: success for drm/i915: Stop engines before reset (rev2) Patchwork
2017-09-19 22:40 ` ✓ Fi.CI.IGT: " Patchwork
2017-09-20 11:24 ` Mika Kuoppala [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-09-14 11:10 [PATCH] drm/i915: Stop engines before reset Mika Kuoppala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87shfh1ulk.fsf@gaia.fi.intel.com \
--to=mika.kuoppala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox