[PATCH] drm/i915/vbt: Assume port A is connected to eDP when there's no VBT

[PATCH] drm/i915/vbt: Assume port A is connected to eDP when there's no VBT

[Dhinakaran Pandiyan]

We currently assume port A is connected to a DP sink when VBT is absent,
instead assume it is connected to an eDP sink, which seems like a more
common configuration. Although I don't have data to back this up,
it is still just as valid as asumming port A is not eDP. This reverts to
the behavior before a98d9c1 ("drm/i915/ddi: Rely on VBT DDI port info for
eDP detection") except only when there is no VBT. Knowing whether a panel
is eDP or not from the panel itself would have been nicer, but I cannot
find any DPCD registers that provide this reliably.

Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Imre Deak <imre.deak@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Clint Taylor <clinton.a.taylor@intel.com>

Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
---
 drivers/gpu/drm/i915/intel_bios.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios.c
index 82b144c..89a405e 100644
--- a/drivers/gpu/drm/i915/intel_bios.c
+++ b/drivers/gpu/drm/i915/intel_bios.c
@@ -1403,6 +1403,7 @@ init_vbt_missing_defaults(struct drm_i915_private *dev_priv)
 		info->supports_dvi = (port != PORT_A && port != PORT_E);
 		info->supports_hdmi = info->supports_dvi;
 		info->supports_dp = (port != PORT_E);
+		info->supports_edp = (port == PORT_A);
 	}
 }
 
-- 
2.7.4

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✓ Fi.CI.BAT: success for drm/i915/vbt: Assume port A is connected to eDP when there's no VBT

[Patchwork]

== Series Details ==

Series: drm/i915/vbt: Assume port A is connected to eDP when there's no VBT
URL   : https://patchwork.freedesktop.org/series/28597/
State : success

== Summary ==

Series 28597v1 drm/i915/vbt: Assume port A is connected to eDP when there's no VBT
https://patchwork.freedesktop.org/api/1.0/series/28597/revisions/1/mbox/

Test gem_exec_flush:
        Subgroup basic-batch-kernel-default-uc:
                fail       -> PASS       (fi-snb-2600) fdo#100007
Test kms_pipe_crc_basic:
        Subgroup suspend-read-crc-pipe-b:
                dmesg-warn -> PASS       (fi-byt-n2820) fdo#101705

fdo#100007 https://bugs.freedesktop.org/show_bug.cgi?id=100007
fdo#101705 https://bugs.freedesktop.org/show_bug.cgi?id=101705

fi-bdw-5557u     total:279  pass:268  dwarn:0   dfail:0   fail:0   skip:11  time:433s
fi-bdw-gvtdvm    total:279  pass:265  dwarn:0   dfail:0   fail:0   skip:14  time:420s
fi-blb-e6850     total:279  pass:224  dwarn:1   dfail:0   fail:0   skip:54  time:353s
fi-bsw-n3050     total:279  pass:243  dwarn:0   dfail:0   fail:0   skip:36  time:497s
fi-bxt-j4205     total:279  pass:260  dwarn:0   dfail:0   fail:0   skip:19  time:486s
fi-byt-j1900     total:279  pass:254  dwarn:1   dfail:0   fail:0   skip:24  time:524s
fi-byt-n2820     total:279  pass:251  dwarn:0   dfail:0   fail:0   skip:28  time:516s
fi-glk-2a        total:279  pass:260  dwarn:0   dfail:0   fail:0   skip:19  time:586s
fi-hsw-4770      total:279  pass:263  dwarn:0   dfail:0   fail:0   skip:16  time:429s
fi-hsw-4770r     total:279  pass:263  dwarn:0   dfail:0   fail:0   skip:16  time:409s
fi-ilk-650       total:279  pass:229  dwarn:0   dfail:0   fail:0   skip:50  time:416s
fi-ivb-3520m     total:279  pass:261  dwarn:0   dfail:0   fail:0   skip:18  time:511s
fi-ivb-3770      total:279  pass:261  dwarn:0   dfail:0   fail:0   skip:18  time:477s
fi-kbl-7500u     total:279  pass:261  dwarn:0   dfail:0   fail:0   skip:18  time:457s
fi-kbl-7560u     total:279  pass:269  dwarn:0   dfail:0   fail:0   skip:10  time:567s
fi-kbl-r         total:279  pass:261  dwarn:0   dfail:0   fail:0   skip:18  time:589s
fi-pnv-d510      total:279  pass:223  dwarn:1   dfail:0   fail:0   skip:55  time:528s
fi-skl-6260u     total:279  pass:269  dwarn:0   dfail:0   fail:0   skip:10  time:450s
fi-skl-6700k     total:279  pass:261  dwarn:0   dfail:0   fail:0   skip:18  time:643s
fi-skl-6770hq    total:279  pass:269  dwarn:0   dfail:0   fail:0   skip:10  time:460s
fi-skl-gvtdvm    total:279  pass:266  dwarn:0   dfail:0   fail:0   skip:13  time:427s
fi-skl-x1585l    total:279  pass:269  dwarn:0   dfail:0   fail:0   skip:10  time:484s
fi-snb-2520m     total:279  pass:251  dwarn:0   dfail:0   fail:0   skip:28  time:548s
fi-snb-2600      total:279  pass:250  dwarn:0   dfail:0   fail:0   skip:29  time:407s

2d0288b5b28c0d67460f0258a41bb4f78b812f29 drm-tip: 2017y-08m-09d-18h-09m-54s UTC integration manifest
03ce4244fb9f drm/i915/vbt: Assume port A is connected to eDP when there's no VBT

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5362/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915/vbt: Assume port A is connected to eDP when there's no VBT

[rodrigo.vivi]

> On Aug 9, 2017, at 8:20 PM, Dhinakaran Pandiyan <dhnkrn@gmail.com> wrote:
> 
> We currently assume port A is connected to a DP sink when VBT is absent,
> instead assume it is connected to an eDP sink, which seems like a more
> common configuration. Although I don't have data to back this up,
> it is still just as valid as asumming port A is not eDP.

I also don't have enough data, but it is the most common configuration on the rvp boards that I see around...
Also the missing vbt case is more for dev platforms anyways right?!


> This reverts to
> the behavior before a98d9c1 ("drm/i915/ddi: Rely on VBT DDI port info for
> eDP detection") except only when there is no VBT. Knowing whether a panel
> is eDP or not from the panel itself would have been nicer, but I cannot
> find any DPCD registers that provide this reliably.
> 
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Imre Deak <imre.deak@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Clint Taylor <clinton.a.taylor@intel.com>

+Joe
Does this fix the issue Joe has on his GLK B0?

> 
> Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> ---
> drivers/gpu/drm/i915/intel_bios.c | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios.c
> index 82b144c..89a405e 100644
> --- a/drivers/gpu/drm/i915/intel_bios.c
> +++ b/drivers/gpu/drm/i915/intel_bios.c
> @@ -1403,6 +1403,7 @@ init_vbt_missing_defaults(struct drm_i915_private *dev_priv)
>        info->supports_dvi = (port != PORT_A && port != PORT_E);
>        info->supports_hdmi = info->supports_dvi;
>        info->supports_dp = (port != PORT_E);
> +        info->supports_edp = (port == PORT_A);

>    }
> }
> 
> -- 
> 2.7.4
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915/vbt: Assume port A is connected to eDP when there's no VBT

[Jani Nikula]

On Thu, 10 Aug 2017, rodrigo.vivi@gmail.com wrote:
>> On Aug 9, 2017, at 8:20 PM, Dhinakaran Pandiyan <dhnkrn@gmail.com> wrote:
>> 
>> We currently assume port A is connected to a DP sink when VBT is absent,
>> instead assume it is connected to an eDP sink, which seems like a more
>> common configuration. Although I don't have data to back this up,
>> it is still just as valid as asumming port A is not eDP.
>
> I also don't have enough data, but it is the most common configuration on the rvp boards that I see around...
> Also the missing vbt case is more for dev platforms anyways right?!

I presume certain chromebooks. Maybe. I really wish we'd never added
this kind of "helpful" defaults, because turns out we may end up getting
stuck with them [1]. Please refrain from applying this patch until that
bug is resolved; we may need to revert.

BR,
Jani.


[1] https://bugs.freedesktop.org/show_bug.cgi?id=101745



>
>
>> This reverts to
>> the behavior before a98d9c1 ("drm/i915/ddi: Rely on VBT DDI port info for
>> eDP detection") except only when there is no VBT. Knowing whether a panel
>> is eDP or not from the panel itself would have been nicer, but I cannot
>> find any DPCD registers that provide this reliably.
>> 
>> Cc: Jani Nikula <jani.nikula@intel.com>
>> Cc: Imre Deak <imre.deak@intel.com>
>> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>> Cc: Clint Taylor <clinton.a.taylor@intel.com>
>
> +Joe
> Does this fix the issue Joe has on his GLK B0?
>
>> 
>> Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
>> ---
>> drivers/gpu/drm/i915/intel_bios.c | 1 +
>> 1 file changed, 1 insertion(+)
>> 
>> diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios.c
>> index 82b144c..89a405e 100644
>> --- a/drivers/gpu/drm/i915/intel_bios.c
>> +++ b/drivers/gpu/drm/i915/intel_bios.c
>> @@ -1403,6 +1403,7 @@ init_vbt_missing_defaults(struct drm_i915_private *dev_priv)
>>        info->supports_dvi = (port != PORT_A && port != PORT_E);
>>        info->supports_hdmi = info->supports_dvi;
>>        info->supports_dp = (port != PORT_E);
>> +        info->supports_edp = (port == PORT_A);
>
>>    }
>> }
>> 
>> -- 
>> 2.7.4
>> 
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915/vbt: Assume port A is connected to eDP when there's no VBT

[Navare, Manasi D]

We currently assume port A is connected to a DP sink when VBT is absent, instead assume it is connected to an eDP sink, which seems like a more common configuration. Although I don't have data to back this up, it is still just as valid as asumming port A is not eDP. This reverts to the behavior before a98d9c1 ("drm/i915/ddi: Rely on VBT DDI port info for eDP detection") except only when there is no VBT. Knowing whether a panel is eDP or not from the panel itself would have been nicer, but I cannot find any DPCD registers that provide this reliably.

Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Imre Deak <imre.deak@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Clint Taylor <clinton.a.taylor@intel.com>

Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>

Is this patch trying to fix a specific bug? Where do you plan to use supports_edp flag? 
I guess I am trying to understand the need for this in the vbt missing defaults and what this patch is trying to solve here. 

Manasi


---
 drivers/gpu/drm/i915/intel_bios.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios.c
index 82b144c..89a405e 100644
--- a/drivers/gpu/drm/i915/intel_bios.c
+++ b/drivers/gpu/drm/i915/intel_bios.c
@@ -1403,6 +1403,7 @@ init_vbt_missing_defaults(struct drm_i915_private *dev_priv)
 		info->supports_dvi = (port != PORT_A && port != PORT_E);
 		info->supports_hdmi = info->supports_dvi;
 		info->supports_dp = (port != PORT_E);
+		info->supports_edp = (port == PORT_A);

 	}
 }
 
--
2.7.4

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915/vbt: Assume port A is connected to eDP when there's no VBT

[Jani Nikula]

On Thu, 10 Aug 2017, "Navare, Manasi D" <manasi.d.navare@intel.com> wrote:
> We currently assume port A is connected to a DP sink when VBT is absent, instead assume it is connected to an eDP sink, which seems like a more common configuration. Although I don't have data to back this up, it is still just as valid as asumming port A is not eDP. This reverts to the behavior before a98d9c1 ("drm/i915/ddi: Rely on VBT DDI port info for eDP detection") except only when there is no VBT. Knowing whether a panel is eDP or not from the panel itself would have been nicer, but I cannot find any DPCD registers that provide this reliably.
>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Imre Deak <imre.deak@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Clint Taylor <clinton.a.taylor@intel.com>
>
> Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
>
> Is this patch trying to fix a specific bug? Where do you plan to use supports_edp flag? 
> I guess I am trying to understand the need for this in the vbt missing defaults and what this patch is trying to solve here. 

Hate to be a nag, but your reply quoting is broken again. So much so
that patchwork tripped over [1]. Please try to get it fixed.

BR,
Jani.


[1] https://patchwork.freedesktop.org/series/28597/


>
> Manasi
>
>
> ---
>  drivers/gpu/drm/i915/intel_bios.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios.c
> index 82b144c..89a405e 100644
> --- a/drivers/gpu/drm/i915/intel_bios.c
> +++ b/drivers/gpu/drm/i915/intel_bios.c
> @@ -1403,6 +1403,7 @@ init_vbt_missing_defaults(struct drm_i915_private *dev_priv)
>  		info->supports_dvi = (port != PORT_A && port != PORT_E);
>  		info->supports_hdmi = info->supports_dvi;
>  		info->supports_dp = (port != PORT_E);
> +		info->supports_edp = (port == PORT_A);
>
>  	}
>  }
>  
> --
> 2.7.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915/vbt: Assume port A is connected to eDP when there's no VBT

[Manasi Navare]

On Thu, Aug 10, 2017 at 05:56:52PM +0300, Jani Nikula wrote:
> On Thu, 10 Aug 2017, "Navare, Manasi D" <manasi.d.navare@intel.com> wrote:
> > We currently assume port A is connected to a DP sink when VBT is absent, instead assume it is connected to an eDP sink, which seems like a more common configuration. Although I don't have data to back this up, it is still just as valid as asumming port A is not eDP. This reverts to the behavior before a98d9c1 ("drm/i915/ddi: Rely on VBT DDI port info for eDP detection") except only when there is no VBT. Knowing whether a panel is eDP or not from the panel itself would have been nicer, but I cannot find any DPCD registers that provide this reliably.
> >
> > Cc: Jani Nikula <jani.nikula@intel.com>
> > Cc: Imre Deak <imre.deak@intel.com>
> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > Cc: Clint Taylor <clinton.a.taylor@intel.com>
> >
> > Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> >
> > Is this patch trying to fix a specific bug? Where do you plan to use supports_edp flag? 
> > I guess I am trying to understand the need for this in the vbt missing defaults and what this patch is trying to solve here. 
> 
> Hate to be a nag, but your reply quoting is broken again. So much so
> that patchwork tripped over [1]. Please try to get it fixed.
> 
> BR,
> Jani.
> 
>

Yea I am sorry I knew it would mess up the formatting. For some reason I was having issues
connecting to the server with mutt so had to reply using Outlook and that probably
messed it up really bad. But with my mutt client its usually fine.

Regards
Manasi
 
> [1] https://patchwork.freedesktop.org/series/28597/
> 
> 
> >
> > Manasi
> >
> >
> > ---
> >  drivers/gpu/drm/i915/intel_bios.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios.c
> > index 82b144c..89a405e 100644
> > --- a/drivers/gpu/drm/i915/intel_bios.c
> > +++ b/drivers/gpu/drm/i915/intel_bios.c
> > @@ -1403,6 +1403,7 @@ init_vbt_missing_defaults(struct drm_i915_private *dev_priv)
> >  		info->supports_dvi = (port != PORT_A && port != PORT_E);
> >  		info->supports_hdmi = info->supports_dvi;
> >  		info->supports_dp = (port != PORT_E);
> > +		info->supports_edp = (port == PORT_A);
> >
> >  	}
> >  }
> >  
> > --
> > 2.7.4
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> 
> -- 
> Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915/vbt: Assume port A is connected to eDP when there's no VBT

[Pandiyan, Dhinakaran]

On Thu, 2017-08-10 at 05:47 +0000, Navare, Manasi D wrote:
> We currently assume port A is connected to a DP sink when VBT is absent, instead assume it is connected to an eDP sink, which seems like a more common configuration. Although I don't have data to back this up, it is still just as valid as asumming port A is not eDP. This reverts to the behavior before a98d9c1 ("drm/i915/ddi: Rely on VBT DDI port info for eDP detection") except only when there is no VBT. Knowing whether a panel is eDP or not from the panel itself would have been nicer, but I cannot find any DPCD registers that provide this reliably.
> 
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Imre Deak <imre.deak@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Clint Taylor <clinton.a.taylor@intel.com>
> 
> Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> 
> Is this patch trying to fix a specific bug? 

Yes, we have a platform without vbt that has an eDP.

> Where do you plan to use supports_edp flag? 

No plans, this is not a new flag. The vbt info is used when when dp
connectors are initialized.

> I guess I am trying to understand the need for this in the vbt missing defaults and what this patch is trying to solve here. 

Assuming port A is not connected an eDP display when it actually is
messes up connector status detection. 


> 
> Manasi
> 
> 
> ---
>  drivers/gpu/drm/i915/intel_bios.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios.c
> index 82b144c..89a405e 100644
> --- a/drivers/gpu/drm/i915/intel_bios.c
> +++ b/drivers/gpu/drm/i915/intel_bios.c
> @@ -1403,6 +1403,7 @@ init_vbt_missing_defaults(struct drm_i915_private *dev_priv)
>  		info->supports_dvi = (port != PORT_A && port != PORT_E);
>  		info->supports_hdmi = info->supports_dvi;
>  		info->supports_dp = (port != PORT_E);
> +		info->supports_edp = (port == PORT_A);
> 
>  	}
>  }
>  
> --
> 2.7.4
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915/vbt: Assume port A is connected to eDP when there's no VBT

[Jani Nikula]

On Thu, 10 Aug 2017, "Pandiyan, Dhinakaran" <dhinakaran.pandiyan@intel.com> wrote:
> On Thu, 2017-08-10 at 05:47 +0000, Navare, Manasi D wrote:
>> We currently assume port A is connected to a DP sink when VBT is absent, instead assume it is connected to an eDP sink, which seems like a more common configuration. Although I don't have data to back this up, it is still just as valid as asumming port A is not eDP. This reverts to the behavior before a98d9c1 ("drm/i915/ddi: Rely on VBT DDI port info for eDP detection") except only when there is no VBT. Knowing whether a panel is eDP or not from the panel itself would have been nicer, but I cannot find any DPCD registers that provide this reliably.
>> 
>> Cc: Jani Nikula <jani.nikula@intel.com>
>> Cc: Imre Deak <imre.deak@intel.com>
>> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>> Cc: Clint Taylor <clinton.a.taylor@intel.com>
>> 
>> Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
>> 
>> Is this patch trying to fix a specific bug? 
>
> Yes, we have a platform without vbt that has an eDP.
>
>> Where do you plan to use supports_edp flag? 
>
> No plans, this is not a new flag. The vbt info is used when when dp
> connectors are initialized.
>
>> I guess I am trying to understand the need for this in the vbt missing defaults and what this patch is trying to solve here. 
>
> Assuming port A is not connected an eDP display when it actually is
> messes up connector status detection. 

This might be a reasonable default assumption.

Regardless, please have a look at [1]; I seem to have forgotten to push
it... could use a tested-by. :)

BR,
Jani.

[1] http://patchwork.freedesktop.org/patch/msgid/20170531151739.26500-1-jani.nikula@intel.com




>
>
>> 
>> Manasi
>> 
>> 
>> ---
>>  drivers/gpu/drm/i915/intel_bios.c | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>> diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios.c
>> index 82b144c..89a405e 100644
>> --- a/drivers/gpu/drm/i915/intel_bios.c
>> +++ b/drivers/gpu/drm/i915/intel_bios.c
>> @@ -1403,6 +1403,7 @@ init_vbt_missing_defaults(struct drm_i915_private *dev_priv)
>>  		info->supports_dvi = (port != PORT_A && port != PORT_E);
>>  		info->supports_hdmi = info->supports_dvi;
>>  		info->supports_dp = (port != PORT_E);
>> +		info->supports_edp = (port == PORT_A);
>> 
>>  	}
>>  }
>>  
>> --
>> 2.7.4
>> 
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx