From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH 5/8] drm/i915: Check error return when converting pipe to connector Date: Wed, 26 Apr 2017 17:53:52 +0300 Message-ID: <87shkvrzi7.fsf@intel.com> References: <1493214013-15580-1-git-send-email-imre.deak@intel.com> <1493214013-15580-6-git-send-email-imre.deak@intel.com> <87vaprs1f3.fsf@intel.com> <20170426142011.GA15301@ideak-desk.fi.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 88E8C898A7 for ; Wed, 26 Apr 2017 14:51:23 +0000 (UTC) In-Reply-To: <20170426142011.GA15301@ideak-desk.fi.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: imre.deak@intel.com Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCAyNiBBcHIgMjAxNywgSW1yZSBEZWFrIDxpbXJlLmRlYWtAaW50ZWwuY29tPiB3cm90 ZToKPiBPbiBXZWQsIEFwciAyNiwgMjAxNyBhdCAwNToxMjozMlBNICswMzAwLCBKYW5pIE5pa3Vs YSB3cm90ZToKPj4gT24gV2VkLCAyNiBBcHIgMjAxNywgSW1yZSBEZWFrIDxpbXJlLmRlYWtAaW50 ZWwuY29tPiB3cm90ZToKPj4gPiBBbiBlcnJvciBmcm9tIGludGVsX2dldF9waXBlX2Zyb21fY29u bmVjdG9yKCkgd291bGQgbWVhbiBhIGJ1ZyBzb21ld2hlcmUKPj4gPiBlbHNlLCBidXQgd2Ugc3Rp bGwgc2hvdWxkIGNoZWNrIGZvciBpdCB0byBwcmV2ZW50IHNvbWUgb3RoZXIgbW9yZQo+PiA+IG9i c2N1cmUgYnVnIGxhdGVyLgo+PiAKPj4gRG8gY2hlY2sgZm9yIGludmFsaWQgcGlwZSwgYnV0IHBs ZWFzZSBqdXN0IGxpbXAgb24gaW5zdGVhZCBvZiBiYWlsaW5nCj4+IG91dCBvZiB0aGUgZnVuY3Rp b25zLiBTZWUgbm90ZXMgaW5saW5lLgo+PiAKPj4gQlIsCj4+IEphbmkuCj4+IAo+PiA+Cj4+ID4g U2lnbmVkLW9mZi1ieTogSW1yZSBEZWFrIDxpbXJlLmRlYWtAaW50ZWwuY29tPgo+PiA+IC0tLQo+ PiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wYW5lbC5jIHwgMTQgKysrKysrKysrKysr LS0KPj4gPiAgMSBmaWxlIGNoYW5nZWQsIDEyIGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0p Cj4+ID4KPj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcGFuZWwu YyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BhbmVsLmMKPj4gPiBpbmRleCBjYjUwYzUy Li5kYmUwNWVjIDEwMDY0NAo+PiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Bh bmVsLmMKPj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wYW5lbC5jCj4+ID4g QEAgLTg4OCwxMCArODg4LDE0IEBAIHN0YXRpYyB2b2lkIHBjaF9lbmFibGVfYmFja2xpZ2h0KHN0 cnVjdCBpbnRlbF9jb25uZWN0b3IgKmNvbm5lY3RvcikKPj4gPiAgCXN0cnVjdCBkcm1faTkxNV9w cml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoY29ubmVjdG9yLT5iYXNlLmRldik7Cj4+ID4gIAlz dHJ1Y3QgaW50ZWxfcGFuZWwgKnBhbmVsID0gJmNvbm5lY3Rvci0+cGFuZWw7Cj4+ID4gIAllbnVt IHBpcGUgcGlwZSA9IGludGVsX2dldF9waXBlX2Zyb21fY29ubmVjdG9yKGNvbm5lY3Rvcik7Cj4+ ID4gLQllbnVtIHRyYW5zY29kZXIgY3B1X3RyYW5zY29kZXIgPQo+PiA+IC0JCWludGVsX3BpcGVf dG9fY3B1X3RyYW5zY29kZXIoZGV2X3ByaXYsIHBpcGUpOwo+PiA+ICsJZW51bSB0cmFuc2NvZGVy IGNwdV90cmFuc2NvZGVyOwo+PiA+ICAJdTMyIGNwdV9jdGwyLCBwY2hfY3RsMSwgcGNoX2N0bDI7 Cj4+ID4gIAo+PiA+ICsJaWYgKFdBUk5fT05fT05DRShwaXBlID09IElOVkFMSURfUElQRSkpCj4+ ID4gKwkJcmV0dXJuOwo+PiAKPj4gUGxlYXNlIGp1c3QgYXNzaWduIGUuZy4gVFJBTlNDT0RFUl9F RFAgdG8gY3B1X3RyYW5zY29kZXIgaW4gdGhpcyBjYXNlLAo+PiBnbyBvbiwgYW5kIGhvcGUgZm9y IHRoZSBiZXN0LiBEbyBsZWF2ZSB0aGUgd2FybiBpbiBwbGFjZSB0aG91Z2guCj4+IAo+PiA+ICsK Pj4gPiArCWNwdV90cmFuc2NvZGVyID0gaW50ZWxfcGlwZV90b19jcHVfdHJhbnNjb2RlcihkZXZf cHJpdiwgcGlwZSk7Cj4+ID4gKwo+PiA+ICAJY3B1X2N0bDIgPSBJOTE1X1JFQUQoQkxDX1BXTV9D UFVfQ1RMMik7Cj4+ID4gIAlpZiAoY3B1X2N0bDIgJiBCTE1fUFdNX0VOQUJMRSkgewo+PiA+ICAJ CURSTV9ERUJVR19LTVMoImNwdSBiYWNrbGlnaHQgYWxyZWFkeSBlbmFibGVkXG4iKTsKPj4gPiBA QCAtOTczLDYgKzk3Nyw5IEBAIHN0YXRpYyB2b2lkIGk5NjVfZW5hYmxlX2JhY2tsaWdodChzdHJ1 Y3QgaW50ZWxfY29ubmVjdG9yICpjb25uZWN0b3IpCj4+ID4gIAllbnVtIHBpcGUgcGlwZSA9IGlu dGVsX2dldF9waXBlX2Zyb21fY29ubmVjdG9yKGNvbm5lY3Rvcik7Cj4+ID4gIAl1MzIgY3RsLCBj dGwyLCBmcmVxOwo+PiA+ICAKPj4gPiArCWlmIChXQVJOX09OX09OQ0UocGlwZSA9PSBJTlZBTElE X1BJUEUpKQo+PiA+ICsJCXJldHVybjsKPj4gCj4+IFNhbWUgaGVyZSwgcGxlYXNlIGp1c3QgYXNz aWduIGUuZy4gUElQRV9BIGhlcmUgd2l0aCB0aGUgd2FybmluZywgYW5kCj4+IGxpbXAgb24uCj4+ IAo+PiA+ICsKPj4gPiAgCWN0bDIgPSBJOTE1X1JFQUQoQkxDX1BXTV9DVEwyKTsKPj4gPiAgCWlm IChjdGwyICYgQkxNX1BXTV9FTkFCTEUpIHsKPj4gPiAgCQlEUk1fREVCVUdfS01TKCJiYWNrbGln aHQgYWxyZWFkeSBlbmFibGVkXG4iKTsKPj4gPiBAQCAtMTA5Myw2ICsxMTAwLDkgQEAgdm9pZCBp bnRlbF9wYW5lbF9lbmFibGVfYmFja2xpZ2h0KHN0cnVjdCBpbnRlbF9jb25uZWN0b3IgKmNvbm5l Y3RvcikKPj4gPiAgCWlmICghcGFuZWwtPmJhY2tsaWdodC5wcmVzZW50KQo+PiA+ICAJCXJldHVy bjsKPj4gPiAgCj4+ID4gKwlpZiAoV0FSTl9PTl9PTkNFKHBpcGUgPT0gSU5WQUxJRF9QSVBFKSkK Pj4gPiArCQlyZXR1cm47Cj4+IAo+PiBIZXJlLCBwaXBlIGlzIG9ubHkgdXNlZCBmb3IgdGhlIGRl YnVnIGxvZ2dpbmcsIGp1c3Qgc2tpcCB0aGF0IGluc3RlYWQuCj4KPiBPaywgY2FuIGRvLiBUaGlz IHdvdWxkIG1ha2UgdGhpbmdzIGluY29uc2lzdGVudCB3cnQuCj4gdmx2X2VuYWJsZS9kaXNhYmxl X2JhY2tsaWdodCgpIHRob3VnaCwgc28gYXJlIHlvdSBvayBpZiBJIGNoYW5nZSB0aG9zZQo+IHRv byBhY2NvcmRpbmdseT8KClRob3NlIGFyZSBkaWZmZXJlbnQgaW4gdGhlIHNlbnNlIHRoYXQgdGhl ICpyZWdpc3RlcnMqIGFyZSBjaG9zZW4gYmFzZWQKb24gdGhlIHBpcGUsIHNvIGl0ICptdXN0KiBi ZSBvbmUgb2YgQSBvciBCLiBCdXQgaW4gdGhlIHBhdGhzIGNoYW5nZWQKaGVyZSwgcGlwZSBpcyBv bmx5IHVzZWQgZm9yIHNvbWUgYml0IGZpZWxkcyBvZiB0aGUgcmVnaXN0ZXJzIGJlaW5nCnVwZGF0 ZWQuIElJUkMgdGhleSBhcmUgbm90IGV2ZW4gY3J1Y2lhbCBmb3IgZnVuZGFtZW50YWwgb3BlcmF0 aW9uIG9mIHRoZQpiYWNrbGlnaHQuIFNvIEkgZG9uJ3Qgd2FudCB0byBiYWlsIG91dCB1bmxlc3Mg d2UgcmVhbGx5IGNhbid0IHByb2NlZWQuCgpCUiwKSmFuaS4KCgo+Cj4gLS1JbXJlCj4KPj4gCj4+ ID4gKwo+PiA+ICAJRFJNX0RFQlVHX0tNUygicGlwZSAlY1xuIiwgcGlwZV9uYW1lKHBpcGUpKTsK Pj4gPiAgCj4+ID4gIAltdXRleF9sb2NrKCZkZXZfcHJpdi0+YmFja2xpZ2h0X2xvY2spOwo+PiAK Pj4gLS0gCj4+IEphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5IENlbnRl cgoKLS0gCkphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5IENlbnRlcgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZngg bWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK