From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm/i915: Fix nesting of filelist_mutex vs struct_mutex in i915_ppgtt_info Date: Mon, 22 Aug 2016 15:09:48 +0300 Message-ID: <87shtxt377.fsf@intel.com> References: <20160822113526.23553-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6FD626E0FF for ; Mon, 22 Aug 2016 12:19:12 +0000 (UTC) In-Reply-To: <20160822113526.23553-1-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCAyMiBBdWcgMjAxNiwgQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28u dWs+IHdyb3RlOgo+IFsgIDI4NC45MjIzNDldID09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQo+IFsgIDI4NC45MjIzNTVdIFsgSU5GTzogcG9zc2li bGUgY2lyY3VsYXIgbG9ja2luZyBkZXBlbmRlbmN5IGRldGVjdGVkIF0KPiBbICAyODQuOTIyMzYx XSA0LjguMC1yYzIrICM0MzAgVGFpbnRlZDogRyAgICAgICAgVwo+IFsgIDI4NC45MjIzNjZdIC0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiBb ICAyODQuOTIyMzcxXSBjYXQvMTE5NyBpcyB0cnlpbmcgdG8gYWNxdWlyZSBsb2NrOgo+IFsgIDI4 NC45MjIzNzZdICAoJmRldi0+ZmlsZWxpc3RfbXV0ZXgpeysuKy4uLn0sIGF0OiBbPGZmZmZmZmZm YTAwNTViYTI+XSBpOTE1X3BwZ3R0X2luZm8rMHg4Mi8weDM5MCBbaTkxNV0KPiBbICAyODQuOTIy NDIzXQo+IFsgIDI4NC45MjI0MjNdIGJ1dCB0YXNrIGlzIGFscmVhZHkgaG9sZGluZyBsb2NrOgo+ IFsgIDI4NC45MjI0MjldICAoJmRldi0+c3RydWN0X211dGV4KXsrLisuKy59LCBhdDogWzxmZmZm ZmZmZmEwMDU1YjU1Pl0gaTkxNV9wcGd0dF9pbmZvKzB4MzUvMHgzOTAgW2k5MTVdCj4gWyAgMjg0 LjkyMjQ2NV0KPiBbICAyODQuOTIyNDY1XSB3aGljaCBsb2NrIGFscmVhZHkgZGVwZW5kcyBvbiB0 aGUgbmV3IGxvY2suCj4gWyAgMjg0LjkyMjQ2NV0KPiBbICAyODQuOTIyNDcxXQo+IFsgIDI4NC45 MjI0NzFdIHRoZSBleGlzdGluZyBkZXBlbmRlbmN5IGNoYWluIChpbiByZXZlcnNlIG9yZGVyKSBp czoKPiBbICAyODQuOTIyNDc3XQo+IC0+ICMxICgmZGV2LT5zdHJ1Y3RfbXV0ZXgpeysuKy4rLn06 Cj4gWyAgMjg0LjkyMjQ5M10gICAgICAgIFs8ZmZmZmZmZmY4MTA4NzcxMD5dIGxvY2tfYWNxdWly ZSsweDYwLzB4ODAKPiBbICAyODQuOTIyNTA1XSAgICAgICAgWzxmZmZmZmZmZjgxNDNlOTZmPl0g bXV0ZXhfbG9ja19uZXN0ZWQrMHg1Zi8weDM2MAo+IFsgIDI4NC45MjI1MjBdICAgICAgICBbPGZm ZmZmZmZmYTAwNGY4Nzc+XSBwcmludF9jb250ZXh0X3N0YXRzKzB4MzcvMHhmMCBbaTkxNV0KPiBb ICAyODQuOTIyNTQ5XSAgICAgICAgWzxmZmZmZmZmZmEwMDUzNWY1Pl0gaTkxNV9nZW1fb2JqZWN0 X2luZm8rMHgyNjUvMHg0OTAgW2k5MTVdCj4gWyAgMjg0LjkyMjU4MV0gICAgICAgIFs8ZmZmZmZm ZmY4MTE0NDQ5MT5dIHNlcV9yZWFkKzB4ZTEvMHgzYjAKPiBbICAyODQuOTIyNTkyXSAgICAgICAg WzxmZmZmZmZmZjgxMWY3N2IzPl0gZnVsbF9wcm94eV9yZWFkKzB4ODMvMHhiMAo+IFsgIDI4NC45 MjI2MDRdICAgICAgICBbPGZmZmZmZmZmODExMWJhMDM+XSBfX3Zmc19yZWFkKzB4MjMvMHgxMTAK PiBbICAyODQuOTIyNjE2XSAgICAgICAgWzxmZmZmZmZmZjgxMTFjOWI5Pl0gdmZzX3JlYWQrMHg4 OS8weDExMAo+IFsgIDI4NC45MjI2MjZdICAgICAgICBbPGZmZmZmZmZmODExMWRiZjQ+XSBTeVNf cmVhZCsweDQ0LzB4YTAKPiBbICAyODQuOTIyNjM2XSAgICAgICAgWzxmZmZmZmZmZjgxNDQyYmU5 Pl0gZW50cnlfU1lTQ0FMTF82NF9mYXN0cGF0aCsweDFjLzB4YWMKPiBbICAyODQuOTIyNjQ4XQo+ IC0+ICMwICgmZGV2LT5maWxlbGlzdF9tdXRleCl7Ky4rLi4ufToKPiBbICAyODQuOTIyNjY3XSAg ICAgICAgWzxmZmZmZmZmZjgxMDg3MWZjPl0gX19sb2NrX2FjcXVpcmUrMHgxMGZjLzB4MTI3MAo+ IFsgIDI4NC45MjI2NzhdICAgICAgICBbPGZmZmZmZmZmODEwODc3MTA+XSBsb2NrX2FjcXVpcmUr MHg2MC8weDgwCj4gWyAgMjg0LjkyMjY4OV0gICAgICAgIFs8ZmZmZmZmZmY4MTQzZTk2Zj5dIG11 dGV4X2xvY2tfbmVzdGVkKzB4NWYvMHgzNjAKPiBbICAyODQuOTIyNzAxXSAgICAgICAgWzxmZmZm ZmZmZmEwMDU1YmEyPl0gaTkxNV9wcGd0dF9pbmZvKzB4ODIvMHgzOTAgW2k5MTVdCj4gWyAgMjg0 LjkyMjcyOV0gICAgICAgIFs8ZmZmZmZmZmY4MTE0NDQ5MT5dIHNlcV9yZWFkKzB4ZTEvMHgzYjAK PiBbICAyODQuOTIyNzM5XSAgICAgICAgWzxmZmZmZmZmZjgxMWY3N2IzPl0gZnVsbF9wcm94eV9y ZWFkKzB4ODMvMHhiMAo+IFsgIDI4NC45MjI3NTBdICAgICAgICBbPGZmZmZmZmZmODExMWJhMDM+ XSBfX3Zmc19yZWFkKzB4MjMvMHgxMTAKPiBbICAyODQuOTIyNzYxXSAgICAgICAgWzxmZmZmZmZm ZjgxMTFjOWI5Pl0gdmZzX3JlYWQrMHg4OS8weDExMAo+IFsgIDI4NC45MjI3NzFdICAgICAgICBb PGZmZmZmZmZmODExMWRiZjQ+XSBTeVNfcmVhZCsweDQ0LzB4YTAKPiBbICAyODQuOTIyNzgxXSAg ICAgICAgWzxmZmZmZmZmZjgxNDQyYmU5Pl0gZW50cnlfU1lTQ0FMTF82NF9mYXN0cGF0aCsweDFj LzB4YWMKPiBbICAyODQuOTIyNzkzXQo+IFsgIDI4NC45MjI3OTNdIG90aGVyIGluZm8gdGhhdCBt aWdodCBoZWxwIHVzIGRlYnVnIHRoaXM6Cj4gWyAgMjg0LjkyMjc5M10KPiBbICAyODQuOTIyODA5 XSAgUG9zc2libGUgdW5zYWZlIGxvY2tpbmcgc2NlbmFyaW86Cj4gWyAgMjg0LjkyMjgwOV0KPiBb ICAyODQuOTIyODE4XSAgICAgICAgQ1BVMCAgICAgICAgICAgICAgICAgICAgQ1BVMQo+IFsgIDI4 NC45MjI4MjVdICAgICAgICAtLS0tICAgICAgICAgICAgICAgICAgICAtLS0tCj4gWyAgMjg0Ljky MjgzMV0gICBsb2NrKCZkZXYtPnN0cnVjdF9tdXRleCk7Cj4gWyAgMjg0LjkyMjg0Ml0gICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIGxvY2soJmRldi0+ZmlsZWxpc3RfbXV0ZXgpOwo+IFsg IDI4NC45MjI4NTRdICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBsb2NrKCZkZXYtPnN0 cnVjdF9tdXRleCk7Cj4gWyAgMjg0LjkyMjg2NV0gICBsb2NrKCZkZXYtPmZpbGVsaXN0X211dGV4 KTsKPiBbICAyODQuOTIyODc1XQo+IFsgIDI4NC45MjI4NzVdICAqKiogREVBRExPQ0sgKioqCj4g WyAgMjg0LjkyMjg3NV0KPiBbICAyODQuOTIyODg4XSAzIGxvY2tzIGhlbGQgYnkgY2F0LzExOTc6 Cj4gWyAgMjg0LjkyMjg5NV0gICMwOiAgKGRlYnVnZnNfc3JjdSl7Li4uLi4ufSwgYXQ6IFs8ZmZm ZmZmZmY4MTFmNzczMD5dIGZ1bGxfcHJveHlfcmVhZCsweDAvMHhiMAo+IFsgIDI4NC45MjI5MTld ICAjMTogICgmcC0+bG9jayl7Ky4rLisufSwgYXQ6IFs8ZmZmZmZmZmY4MTE0NDNlOD5dIHNlcV9y ZWFkKzB4MzgvMHgzYjAKPiBbICAyODQuOTIyOTQyXSAgIzI6ICAoJmRldi0+c3RydWN0X211dGV4 KXsrLisuKy59LCBhdDogWzxmZmZmZmZmZmEwMDU1YjU1Pl0gaTkxNV9wcGd0dF9pbmZvKzB4MzUv MHgzOTAgW2k5MTVdCj4gWyAgMjg0LjkyMjk4M10KCkRvIHdlIGhhdmUgYSByZWdyZXNzaW5nIGNv bW1pdCByZWZlcmVuY2U/CgpCUiwKSmFuaS4KCj4KPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxz b24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5 MTUvaTkxNV9kZWJ1Z2ZzLmMgfCAxNiArKysrKysrKystLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2Vk LCA5IGluc2VydGlvbnMoKyksIDcgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaTkxNV9kZWJ1Z2ZzLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1 X2RlYnVnZnMuYwo+IGluZGV4IDUxOTNiMDQ0NzA2Ni4uYzVlZjEzMmY4YjUxIDEwMDY0NAo+IC0t LSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZGVidWdmcy5jCj4gKysrIGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaTkxNV9kZWJ1Z2ZzLmMKPiBAQCAtMjI5MSwxMCArMjI5MSwxMyBAQCBzdGF0 aWMgaW50IGk5MTVfcHBndHRfaW5mbyhzdHJ1Y3Qgc2VxX2ZpbGUgKm0sIHZvaWQgKmRhdGEpCj4g IAlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2ID0gbm9kZS0+bWlub3ItPmRldjsKPiAgCXN0cnVjdCBk cm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoZGV2KTsKPiAgCXN0cnVjdCBkcm1f ZmlsZSAqZmlsZTsKPiArCWludCByZXQ7Cj4gIAo+IC0JaW50IHJldCA9IG11dGV4X2xvY2tfaW50 ZXJydXB0aWJsZSgmZGV2LT5zdHJ1Y3RfbXV0ZXgpOwo+ICsJbXV0ZXhfbG9jaygmZGV2LT5maWxl bGlzdF9tdXRleCk7Cj4gKwlyZXQgPSBtdXRleF9sb2NrX2ludGVycnVwdGlibGUoJmRldi0+c3Ry dWN0X211dGV4KTsKPiAgCWlmIChyZXQpCj4gLQkJcmV0dXJuIHJldDsKPiArCQlnb3RvIG91dF91 bmxvY2s7Cj4gKwo+ICAJaW50ZWxfcnVudGltZV9wbV9nZXQoZGV2X3ByaXYpOwo+ICAKPiAgCWlm IChJTlRFTF9JTkZPKGRldiktPmdlbiA+PSA4KQo+IEBAIC0yMzAyLDcgKzIzMDUsNiBAQCBzdGF0 aWMgaW50IGk5MTVfcHBndHRfaW5mbyhzdHJ1Y3Qgc2VxX2ZpbGUgKm0sIHZvaWQgKmRhdGEpCj4g IAllbHNlIGlmIChJTlRFTF9JTkZPKGRldiktPmdlbiA+PSA2KQo+ICAJCWdlbjZfcHBndHRfaW5m byhtLCBkZXYpOwo+ICAKPiAtCW11dGV4X2xvY2soJmRldi0+ZmlsZWxpc3RfbXV0ZXgpOwo+ICAJ bGlzdF9mb3JfZWFjaF9lbnRyeV9yZXZlcnNlKGZpbGUsICZkZXYtPmZpbGVsaXN0LCBsaGVhZCkg ewo+ICAJCXN0cnVjdCBkcm1faTkxNV9maWxlX3ByaXZhdGUgKmZpbGVfcHJpdiA9IGZpbGUtPmRy aXZlcl9wcml2Owo+ICAJCXN0cnVjdCB0YXNrX3N0cnVjdCAqdGFzazsKPiBAQCAtMjMxMCwxOSAr MjMxMiwxOSBAQCBzdGF0aWMgaW50IGk5MTVfcHBndHRfaW5mbyhzdHJ1Y3Qgc2VxX2ZpbGUgKm0s IHZvaWQgKmRhdGEpCj4gIAkJdGFzayA9IGdldF9waWRfdGFzayhmaWxlLT5waWQsIFBJRFRZUEVf UElEKTsKPiAgCQlpZiAoIXRhc2spIHsKPiAgCQkJcmV0ID0gLUVTUkNIOwo+IC0JCQlnb3RvIG91 dF91bmxvY2s7Cj4gKwkJCWdvdG8gb3V0X3JwbTsKPiAgCQl9Cj4gIAkJc2VxX3ByaW50ZihtLCAi XG5wcm9jOiAlc1xuIiwgdGFzay0+Y29tbSk7Cj4gIAkJcHV0X3Rhc2tfc3RydWN0KHRhc2spOwo+ ICAJCWlkcl9mb3JfZWFjaCgmZmlsZV9wcml2LT5jb250ZXh0X2lkciwgcGVyX2ZpbGVfY3R4LAo+ ICAJCQkgICAgICh2b2lkICopKHVuc2lnbmVkIGxvbmcpbSk7Cj4gIAl9Cj4gLW91dF91bmxvY2s6 Cj4gLQltdXRleF91bmxvY2soJmRldi0+ZmlsZWxpc3RfbXV0ZXgpOwo+ICAKPiArb3V0X3JwbToK PiAgCWludGVsX3J1bnRpbWVfcG1fcHV0KGRldl9wcml2KTsKPiAgCW11dGV4X3VubG9jaygmZGV2 LT5zdHJ1Y3RfbXV0ZXgpOwo+IC0KPiArb3V0X3VubG9jazoKPiArCW11dGV4X3VubG9jaygmZGV2 LT5maWxlbGlzdF9tdXRleCk7Cj4gIAlyZXR1cm4gcmV0Owo+ICB9CgotLSAKSmFuaSBOaWt1bGEs IEludGVsIE9wZW4gU291cmNlIFRlY2hub2xvZ3kgQ2VudGVyCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwt Z2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=