Re: [PATCH maintainer-tools 2/2] dim: Refuse to commit patches that modify files outside of i915

Daniel Vetter
2016-04-28T14:04:47Z

On Thu, Apr 28, 2016 at 02:32:20PM +0300, Joonas Lahtinen wrote:
> Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> ---
> dim | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/dim b/dim
> index dbcb7d9..1c258be 100755
> --- a/dim
> +++ b/dim
> @@ -691,6 +691,11 @@ function checkpatch_commit
> if test "$bug_lines" -eq 1; then
> warn_or_fail "New BUG macro added"
> fi
> +
> + local non_i915_files=$(git diff-tree --no-commit-id --name-only -r HEAD | grep -v "^\(drivers/gpu/drm/i915/\|include/drm/i915\|include/uapi/drm/i915\)")
> + if [ -n "$non_i915_files" ]; then
> + warn_or_fail "The following files are outside of i915 maintenance scope:\n$non_i915_files\n\nConfirm you have appropriate Acked-by and Reviewed-by for above files"
> + fi
> }

You need to restrict this to the drm-intel-next-queued branch. And I think
asking the user instead of warn_or_fail would be nice, but not directly
needed. Otherwise lgtm for both patches.
-Daniel

>
> # turn $1 in to a git commit range
> --
> 2.5.5
>

--
Daniel Vetter
Software Engineer, Intel Corporation