From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH 08/17] drm/i915: Don't look at pg_dirty_rings for aliasing ppgtt Date: Fri, 17 Apr 2015 16:49:18 +0300 Message-ID: <87siby27c1.fsf@gaia.fi.intel.com> References: <1429025727-15380-1-git-send-email-daniel.vetter@ffwll.ch> <1429025727-15380-9-git-send-email-daniel.vetter@ffwll.ch> <20150414160636.GH16216@nuc-i3427.alporthouse.com> <20150414171125.GK6092@phenom.ffwll.local> <20150414175341.GM16216@nuc-i3427.alporthouse.com> <20150415104429.GZ6092@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 1936C6EB64 for ; Fri, 17 Apr 2015 06:49:32 -0700 (PDT) In-Reply-To: <20150415104429.GZ6092@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter , Chris Wilson Daniel Vetter , Daniel Vetter , Intel Graphics Development , Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org RGFuaWVsIFZldHRlciA8ZGFuaWVsQGZmd2xsLmNoPiB3cml0ZXM6Cgo+IE9uIFR1ZSwgQXByIDE0 LCAyMDE1IGF0IDA2OjUzOjQxUE0gKzAxMDAsIENocmlzIFdpbHNvbiB3cm90ZToKPj4gT24gVHVl LCBBcHIgMTQsIDIwMTUgYXQgMDc6MTE6MjVQTSArMDIwMCwgRGFuaWVsIFZldHRlciB3cm90ZToK Pj4gPiBPbiBUdWUsIEFwciAxNCwgMjAxNSBhdCAwNTowNjozNlBNICswMTAwLCBDaHJpcyBXaWxz b24gd3JvdGU6Cj4+ID4gPiBPbiBUdWUsIEFwciAxNCwgMjAxNSBhdCAwNTozNToxOFBNICswMjAw LCBEYW5pZWwgVmV0dGVyIHdyb3RlOgo+PiA+ID4gPiBXZSBsb2FkIHRoZSBwcGd0dCBwdGVzIG9u Y2UgcGVyIGdwdSByZXNldC9kcml2ZXIgbG9hZC9yZXN1bWUgYW5kCj4+ID4gPiA+IHRoYXQncyBh bGwgdGhhdCdzIG5lZWRlZC4gTm90ZSB0aGF0IHRoaXMgb25seSBibG93cyB1cCB3aGVuIHdlJ3Jl Cj4+ID4gPiA+IHVzaW5nIHRoZSBhbGxvY2F0ZV92YV9yYW5nZSBmdW5jcyBhbmQgbm90IHRoZSBz cGVjaWFsLXB1cnBvc2Ugb25lcwo+PiA+ID4gPiB1c2VkLiBXaXRoIHRoaXMgY2hhbmdlIHdlIGNh biBnZXQgcmlkIG9mIHRoYXQgZHVwbGljYXRpb24uCj4+ID4gPiAKPj4gPiA+IEhvbmVzdGx5LCBJ IHdvdWxkIHByZWZlciB0aGUgdGVzdCB0byBiZSByZXdyaXR0ZW4gc28gdGhhdCB0aGUKPj4gPiA+ IGluZm9ybWF0aW9uIG9uIHdoaWNoIHZtIHdhcyBiZWluZyB1c2VkIHdhcyBwYXNzZWQgYWxvbmcg YW5kIG5vdCB0aGF0Cj4+ID4gPiBtYWdpYyBzcHJpbmtsZWQgaW4gdGhlIG1pZGRsZSBvZiBub3do ZXJlLiBlLmcuIGV4ZWNidWZmZXIga25vd3MgZXhhY3RseQo+PiA+ID4gd2hhdCB2bSBpdCBib3Vu ZCB0aGUgb2JqZWN0cyBpbnRvLCBhbmQgeWV0IHRvd2FyZHMgdGhlIGVuZCB3ZSBkZWNpZGUgdG8K Pj4gPiA+IGd1ZXNzIGFnYWluLiBBbHNvLCBJIHdvdWxkIHJhdGhlciB0aGUgZXhlY2J1ZmZlciB0 ZXN0IGJlIG1vdmVkIHRvCj4+ID4gPiBpOTE1X2dlbV9jb250ZXh0IHNpbmNlIGl0IGlzIHNjYXR0 ZXJpbmcgaW50ZXJuYWwga25vd2xlZGdlIGFib3V0Lgo+PiA+IAo+PiA+IFllYWggSSBhZ3JlZSB0 aGF0IHRoZXJlJ3MgbW9yZSByb29tIGZvciBjbGVhbnVwLiBJJ3ZlIGRvbmUgdGhpcyBtaW5pbWFs Cj4+ID4gcGF0Y2ggcHVyZWx5IHRvIHNodXQgdXAgdGhlIGJvZ3VzIFdBUk5fT05zIHdoZW4gSSB0 cmllZCB0byB1bmlmeSB0aGUKPj4gPiBnZW42LzcgcHQgYWxsb2MgY29kZSBpbiB0aGUgbmV4dCBw YXRjaC4gU2luY2UgaXQncyBib2d1cy4KPj4gCj4+IEhvdyBhYm91dDoKPgo+IFllYWgsIGJ1dCBp bW8gdGhlcmUncyBhbHNvIG1vcmUuIEkgdHJpZWQgdG8gdW5kZXJzdGFuZCB0aGUgZ2VuOCBsZWdh Y3kgY3R4Cj4gc3dpdGNoIGxvZ2ljIGFuZCBmYWlsZWQsIGFuZCBJIHdhc24ndCBmdWxseSBjb252 aW5jZWQgdGhhdCB0aGUgZ2VuNyBvbmUKPiB3b24ndCBXQVJOIGlmIHdlIGFjdHVhbGx5IGVuYWJs ZSBmdWxsIHBwZ3R0LiBHaXZlbiBhbGwgdGhhdCBJIGRlY2lkZWQgdG8KPiBnbyB3aXRoIHRoZSBt b3N0IG1pbmltYWwgcGF0Y2ggYW5kIGp1c3QgcmVtb3ZlZCB0aGUgb2ZmZW5kaW5nIGJvZ3VzIFdB Uk4uCj4gQnV0IE1pa2EvTWljaGVsIHByb21pc2VkIHRvIGhhbmcgYXJvdW5kIGZvciBldmVudHVh bCBjbGVhbnVwcz8KClllcy4gVGhlcmUgaXMgbW9yZSB0byBjb21lIGFmdGVyIHRoaXMgc2VyaWVz LgpJIGNhbiBpbmNsdWRlIENocmlzJ3Mgc3VnZ2VzdGlvbi4KCi1NaWthCgo+IC1EYW5pZWwKPgo+ PiAKPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2NvbnRleHQu YyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2NvbnRleHQuYwo+PiBpbmRleCBlZDky MzIxMjY2NDQuLmJlMGY0NzVlZTFlNSAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaTkxNV9nZW1fY29udGV4dC5jCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf Z2VtX2NvbnRleHQuYwo+PiBAQCAtNjM4LDIyICs2MzgsMTQgQEAgbWlfc2V0X2NvbnRleHQoc3Ry dWN0IGludGVsX2VuZ2luZV9jcyAqcmluZywKPj4gIAo+PiAgc3RhdGljIGlubGluZSBib29sIHNo b3VsZF9za2lwX3N3aXRjaChzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICpyaW5nLAo+PiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0cnVjdCBpbnRlbF9jb250ZXh0ICpmcm9t LAo+PiAtICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0cnVjdCBpbnRlbF9j b250ZXh0ICp0bykKPj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzdHJ1 Y3QgaW50ZWxfY29udGV4dCAqdG8sCj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgc3RydWN0IGk5MTVfaHdfcHBndHQgKnBwZ3R0KQo+PiAgewo+PiAtICAgICAgIHN0cnVj dCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHJpbmctPmRldi0+ZGV2X3ByaXZhdGU7Cj4+ IC0KPj4gICAgICAgICBpZiAodG8tPnJlbWFwX3NsaWNlKQo+PiAgICAgICAgICAgICAgICAgcmV0 dXJuIGZhbHNlOwo+PiAgCj4+IC0gICAgICAgaWYgKHRvLT5wcGd0dCkgewo+PiAtICAgICAgICAg ICAgICAgaWYgKGZyb20gPT0gdG8gJiYgIXRlc3RfYml0KHJpbmctPmlkLAo+PiAtICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICZ0by0+cHBndHQtPnBkX2RpcnR5X3JpbmdzKSkKPj4gLSAg ICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIHRydWU7Cj4+IC0gICAgICAgfSBlbHNlIGlmIChk ZXZfcHJpdi0+bW0uYWxpYXNpbmdfcHBndHQpIHsKPj4gLSAgICAgICAgICAgICAgIGlmIChmcm9t ID09IHRvICYmICF0ZXN0X2JpdChyaW5nLT5pZCwKPj4gLSAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAmZGV2X3ByaXYtPm1tLmFsaWFzaW5nX3BwZ3R0LT5wZF9kaXJ0eV9yaW5ncykpCj4+ IC0gICAgICAgICAgICAgICAgICAgICAgIHJldHVybiB0cnVlOwo+PiAtICAgICAgIH0KPj4gKyAg ICAgICBpZiAoZnJvbSA9PSB0byAmJiAhdGVzdF9iaXQocmluZy0+aWQsICZwcGd0dC0+cGRfZGly dHlfcmluZ3MpKQo+PiArICAgICAgICAgICAgICAgcmV0dXJuIHRydWU7Cj4+ICAKPj4gICAgICAg ICByZXR1cm4gZmFsc2U7Cj4+ICB9Cj4+IEBAIC02NjEsMTUgKzY1MywxMyBAQCBzdGF0aWMgaW5s aW5lIGJvb2wgc2hvdWxkX3NraXBfc3dpdGNoKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKnJpbmcs Cj4+ICBzdGF0aWMgYm9vbAo+PiAgbmVlZHNfcGRfbG9hZF9wcmUoc3RydWN0IGludGVsX2VuZ2lu ZV9jcyAqcmluZywgc3RydWN0IGludGVsX2NvbnRleHQgKnRvKQo+PiAgewo+PiAtICAgICAgIHN0 cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHJpbmctPmRldi0+ZGV2X3ByaXZhdGU7 Cj4+IC0KPj4gICAgICAgICBpZiAoIXRvLT5wcGd0dCkKPj4gICAgICAgICAgICAgICAgIHJldHVy biBmYWxzZTsKPj4gIAo+PiAgICAgICAgIGlmIChJTlRFTF9JTkZPKHJpbmctPmRldiktPmdlbiA8 IDgpCj4+ICAgICAgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKPj4gIAo+PiAtICAgICAgIGlmIChy aW5nICE9ICZkZXZfcHJpdi0+cmluZ1tSQ1NdKQo+PiArICAgICAgIGlmIChyaW5nLT5pZCAhPSBS Q1MpCj4+ICAgICAgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKPj4gIAo+PiAgICAgICAgIHJldHVy biBmYWxzZTsKPj4gQEAgLTY3OSwxNSArNjY5LDEzIEBAIHN0YXRpYyBib29sCj4+ICBuZWVkc19w ZF9sb2FkX3Bvc3Qoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqcmluZywgc3RydWN0IGludGVsX2Nv bnRleHQgKnRvLAo+PiAgICAgICAgICAgICAgICAgdTMyIGh3X2ZsYWdzKQo+PiAgewo+PiAtICAg ICAgIHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHJpbmctPmRldi0+ZGV2X3By aXZhdGU7Cj4+IC0KPj4gICAgICAgICBpZiAoIXRvLT5wcGd0dCkKPj4gICAgICAgICAgICAgICAg IHJldHVybiBmYWxzZTsKPj4gIAo+PiAgICAgICAgIGlmICghSVNfR0VOOChyaW5nLT5kZXYpKQo+ PiAgICAgICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwo+PiAgCj4+IC0gICAgICAgaWYgKHJpbmcg IT0gJmRldl9wcml2LT5yaW5nW1JDU10pCj4+ICsgICAgICAgaWYgKHJpbmctPmlkICE9IFJDUykK Pj4gICAgICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKPj4gIAo+PiAgICAgICAgIGlmIChod19m bGFncyAmIE1JX1JFU1RPUkVfSU5ISUJJVCkKPj4gQEAgLTcwMSwxNCArNjg5LDE1IEBAIHN0YXRp YyBpbnQgZG9fc3dpdGNoKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKnJpbmcsCj4+ICB7Cj4+ICAg ICAgICAgc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gcmluZy0+ZGV2LT5kZXZf cHJpdmF0ZTsKPj4gICAgICAgICBzdHJ1Y3QgaW50ZWxfY29udGV4dCAqZnJvbSA9IHJpbmctPmxh c3RfY29udGV4dDsKPj4gKyAgICAgICBzdHJ1Y3QgaTkxNV9od19wcGd0dCAqcHBndHQgPSB0by0+ cHBndHQgPzogZGV2X3ByaXYtPm1tLmFsaWFzaW5nX3BwZ3R0Owo+PiAgICAgICAgIHUzMiBod19m bGFncyA9IDA7Cj4+ICAgICAgICAgYm9vbCB1bmluaXRpYWxpemVkID0gZmFsc2U7Cj4+ICAgICAg ICAgaW50IHJldCwgaTsKPj4gIAo+PiAtICAgICAgIGlmIChmcm9tICE9IE5VTEwgJiYgcmluZyA9 PSAmZGV2X3ByaXYtPnJpbmdbUkNTXSkKPj4gKyAgICAgICBpZiAoZnJvbSAhPSBOVUxMICYmIHJp bmctPmlkID09IFJDUykKPj4gICAgICAgICAgICAgICAgIEJVR19PTihmcm9tLT5sZWdhY3lfaHdf Y3R4LnJjc192bWEgPT0gTlVMTCk7Cj4+ICAKPj4gLSAgICAgICBpZiAoc2hvdWxkX3NraXBfc3dp dGNoKHJpbmcsIGZyb20sIHRvKSkKPj4gKyAgICAgICBpZiAoc2hvdWxkX3NraXBfc3dpdGNoKHJp bmcsIGZyb20sIHRvLCBwcGd0dCkpCj4+ICAgICAgICAgICAgICAgICByZXR1cm4gMDsKPj4gIAo+ PiAgICAgICAgIC8qIFRyeWluZyB0byBwaW4gZmlyc3QgbWFrZXMgZXJyb3IgaGFuZGxpbmcgZWFz aWVyLiAqLwo+PiBAQCAtODUxLDYgKzg0MCw5IEBAIGRvbmU6Cj4+ICAgICAgICAgaTkxNV9nZW1f Y29udGV4dF9yZWZlcmVuY2UodG8pOwo+PiAgICAgICAgIHJpbmctPmxhc3RfY29udGV4dCA9IHRv Owo+PiAgCj4+ICsgICAgICAgV0FSTihwcGd0dC0+cGRfZGlydHlfcmluZ3MgJiAoMTw8cmluZy0+ aWQpLAo+PiArICAgICAgICAgICAgIiVzIGRpZG4ndCBjbGVhciByZWxvYWRcbiIsIHJpbmctPm5h bWUpOwo+PiArCj4+ICAgICAgICAgaWYgKHVuaW5pdGlhbGl6ZWQpIHsKPj4gICAgICAgICAgICAg ICAgIGlmIChyaW5nLT5pbml0X2NvbnRleHQpIHsKPj4gICAgICAgICAgICAgICAgICAgICAgICAg cmV0ID0gcmluZy0+aW5pdF9jb250ZXh0KHJpbmcsIHRvKTsKPj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2V4ZWNidWZmZXIuYyBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2k5MTVfZ2VtX2V4ZWNidWZmZXIuYwo+PiBpbmRleCBlZjY0NGU3ZWFhYzAuLjU5NWRhZWNi MzI4MyAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fZXhlY2J1 ZmZlci5jCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2V4ZWNidWZmZXIu Ywo+PiBAQCAtMTM4NSwxMyArMTM4NSw2IEBAIGk5MTVfZ2VtX3JpbmdidWZmZXJfc3VibWlzc2lv bihzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCBzdHJ1Y3QgZHJtX2ZpbGUgKmZpbGUsCj4+ICAgICAg ICAgaWYgKHJldCkKPj4gICAgICAgICAgICAgICAgIGdvdG8gZXJyb3I7Cj4+ICAKPj4gLSAgICAg ICBpZiAoY3R4LT5wcGd0dCkKPj4gLSAgICAgICAgICAgICAgIFdBUk4oY3R4LT5wcGd0dC0+cGRf ZGlydHlfcmluZ3MgJiAoMTw8cmluZy0+aWQpLAo+PiAtICAgICAgICAgICAgICAgICAgICAgICAi JXMgZGlkbid0IGNsZWFyIHJlbG9hZFxuIiwgcmluZy0+bmFtZSk7Cj4+IC0gICAgICAgZWxzZSBp ZiAoZGV2X3ByaXYtPm1tLmFsaWFzaW5nX3BwZ3R0KQo+PiAtICAgICAgICAgICAgICAgV0FSTihk ZXZfcHJpdi0+bW0uYWxpYXNpbmdfcHBndHQtPnBkX2RpcnR5X3JpbmdzICYKPj4gLSAgICAgICAg ICAgICAgICAgICAgICAgKDE8PHJpbmctPmlkKSwgIiVzIGRpZG4ndCBjbGVhciByZWxvYWRcbiIs IHJpbmctPm5hbWUpOwo+PiAtCj4+ICAgICAgICAgaW5zdHBfbW9kZSA9IGFyZ3MtPmZsYWdzICYg STkxNV9FWEVDX0NPTlNUQU5UU19NQVNLOwo+PiAgICAgICAgIGluc3RwX21hc2sgPSBJOTE1X0VY RUNfQ09OU1RBTlRTX01BU0s7Cj4+ICAgICAgICAgc3dpdGNoIChpbnN0cF9tb2RlKSB7Cj4+IAo+ PiAKPj4gSXQgZ2V0cyByaWQgb2YgdGhlIGludGVybmFsIGtub3dsZWRnZSBvZiBhZGRyZXNzIHNw YWNlcyBmcm9tIHRoZSBleGVjYnVmCj4+IGNvZGUsIGFuZCBrZWVwcyB0aGUgc3ltbWV0cnkgYmV0 d2VlbiBoYW5kbGluZyBhbGlhc2luZ19wcGd0dCBhbmQKPj4gZnVsbF9wcGd0dC4gKFRoZSBmb3Jt ZXIgc2hvdWxkIGp1c3QgYmUgYSBkZWdlbmVyYXRlIGNhc2Ugd2hlcmUgdGhlIFBECj4+IGFyZSBh bGwgcHJlbG9hZGVkKS4KPj4gLUNocmlzCj4+IAo+PiAtLSAKPj4gQ2hyaXMgV2lsc29uLCBJbnRl bCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5IENlbnRyZQo+Cj4gLS0gCj4gRGFuaWVsIFZldHRlcgo+ IFNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgo+IGh0dHA6Ly9ibG9nLmZmd2xs LmNoCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBJ bnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ IGh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK