From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm/i915: Keep ring->active_list and ring->requests_list consistent Date: Wed, 25 Mar 2015 13:43:01 +0200 Message-ID: <87sictmhfe.fsf@intel.com> References: <1426702762-6490-1-git-send-email-chris@chris-wilson.co.uk> <20150323084915.GJ1349@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id D95736E055 for ; Wed, 25 Mar 2015 04:44:11 -0700 (PDT) In-Reply-To: <20150323084915.GJ1349@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter , Chris Wilson Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCAyMyBNYXIgMjAxNSwgRGFuaWVsIFZldHRlciA8ZGFuaWVsQGZmd2xsLmNoPiB3cm90 ZToKPiBPbiBXZWQsIE1hciAxOCwgMjAxNSBhdCAwNjoxOToyMlBNICswMDAwLCBDaHJpcyBXaWxz b24gd3JvdGU6Cj4+IElmIHdlIHJldGlyZSByZXF1ZXN0cyBsYXN0LCB3ZSBtYXkgdXNlIGEgbGF0 ZXIgc2Vxbm8gYW5kIHNvIGNsZWFyCj4+IHRoZSByZXF1ZXN0cyBsaXN0cyB3aXRob3V0IGNsZWFy aW5nIHRoZSBhY3RpdmUgbGlzdCwgbGVhZGluZyB0bwo+PiBjb25mdXNpb24uIEhlbmNlIHdlIHNo b3VsZCByZXRpcmUgcmVxdWVzdHMgZmlyc3QgZm9yIGNvbnNpc3RlbmN5IHdpdGgKPj4gdGhlIGVh cmx5IHJldHVybi4gVGhlIG9yZGVyIHVzZWQgdG8gYmUgaW1wb3J0YW50IGFzIHRoZSBsaWZlY3lj bGUgZm9yCj4+IHRoZSBvYmplY3Qgb24gdGhlIGFjdGl2ZSBsaXN0IHdhcyBkZXRlcm1pbmVkIGJ5 IHJlcXVlc3QtPnNlcW5vLiBIb3dldmVyLAo+PiB0aGUgcmVxdWVzdHMgdGhlbXNlbHZlcyBhcmUg bm93IHJlZmVyZW5jZSBjb3VudGVkIHJlbW92aW5nIHRoZQo+PiBjb25zdHJhaW50IGZyb20gdGhl IG9yZGVyIG9mIHJldGlyZW1lbnQuCj4+IAo+PiBGaXhlcyByZWdyZXNzaW9uIGZyb20KPj4gCj4+ IGNvbW1pdCAxYjVhNDMzYTRkZDk2N2IxMjUxMzFkYTQyYjg5YjVjYzBkNWIxZjU3Cj4+IEF1dGhv cjogSm9obiBIYXJyaXNvbiA8Sm9obi5DLkhhcnJpc29uQEludGVsLmNvbT4KPj4gRGF0ZTogICBN b24gTm92IDI0IDE4OjQ5OjQyIDIwMTQgKzAwMDAKPj4gCj4+ICAgICBkcm0vaTkxNTogQ29udmVy dCAnaTkxNV9zZXFub19wYXNzZWQnIGNhbGxzIGludG8gJ2k5MTVfZ2VtX3JlcXVlc3RfY29tcGxl dGVkCj4+ICcKPj4gCj4+IGFuZCBhCj4+IAo+PiAJV0FSTklORzogQ1BVOiAwIFBJRDogMTM4MyBh dCBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9ldmljdC5jOjI3OSBpOTE1X2dlbV9ldmlj dF92bSsweDEwYy8weDE0MCgpCj4+IAlXQVJOX09OKCFsaXN0X2VtcHR5KCZ2bS0+YWN0aXZlX2xp c3QpKQo+PiAKPj4gSWRlbnRpZmllZCBieSB1cGRhdGluZyBXQVRDSF9MSVNUUzoKPj4gCj4+IAlb ZHJtOmk5MTVfdmVyaWZ5X2xpc3RzXSAqRVJST1IqIGJsaXR0ZXIgcmluZzogYWN0aXZlIGxpc3Qg bm90IGVtcHR5LCBidXQgbm8gcmVxdWVzdHMKPj4gCVdBUk5JTkc6IENQVTogMCBQSUQ6IDY4MSBh dCBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jOjI3NTEgaTkxNV9nZW1fcmV0aXJlX3Jl cXVlc3RzX3JpbmcrMHgxNDkvMHgyMzAoKQo+PiAJV0FSTl9PTihpOTE1X3ZlcmlmeV9saXN0cyhy aW5nLT5kZXYpKQo+PiAKPj4gU2lnbmVkLW9mZi1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJp cy13aWxzb24uY28udWs+Cj4+IENjOiBKb2huIEhhcnJpc29uIDxKb2huLkMuSGFycmlzb25ASW50 ZWwuY29tPgo+PiBDYzogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KPgo+ IEluIGNhc2UgaXQncyBidXJyaWVkIHRvbyBtdWNoIGluIHRoZSB0aHJlYWQ6Cj4KPiBSZXZpZXdl ZC1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KPgo+IEFkZGFkZW5k dW0gZm9yIHRoZSBjb21taXQ6Cj4KPiAiTm90ZSB0aGF0IHRoaXMgaXMgb25seSBhIHByb2JsZW0g aW4gZXZpY3Rfdm0gd2hlcmUgdGhlIGZvbGxvd2luZyBoYXBwZW5zCj4gYWZ0ZXIgYSByZXRpcmVf cmVxdWVzdCBoYXMgY2xlYW5lZCBvdXQgYWxsIHJlcXVlc3RzLCBidXQgbm90IGFsbCBhY3RpdmUK PiBibzoKPiAtIGludGVsX3JpbmdfaWRsZSBjYWxsZWQgZnJvbSBpOTE1X2dwdV9pZGxlIG5vdGlj ZXMgdGhhdCBubyByZXF1ZXN0cyBhcmUKPiAgIG91dHN0YW5kaW5nIGFuZCBpbW1lZGlhdGVseSBy ZXR1cm5zLgo+IC0gaTkxNV9nZW1fcmV0aXJlX3JlcXVlc3RzX3JpbmcgY2FsbGVkIGZyb20gaTkx NV9nZW1fcmV0aXJlX3JlcXVlc3RzIGFsc28KPiAgIGltbWVkaWF0ZWx5IHJldHVybnMgd2hlbiB0 aGVyZSdzIG5vIHJlcXVlc3QsIHN0aWxsIGxlYXZpbmcgdGhlIGJvIG9uIHRoZQo+ICAgYWN0aXZl IGxpc3QuCj4gLSBldmljdF92bSBoaXRzIHRoZSBXQVJOX09OKCFsaXN0X2VtcHR5KCZ2bS0+YWN0 aXZlX2xpc3QpKSBhZnRlciBldmljdGluZwo+ICAgYWxsIGFjdGl2ZSBvYmplY3RzIHRoYXQgdGhl cmUncyBzdGlsbCBzdHVmZiBsZWZ0IHRoYXQgc2hvdWxkbid0IGJlCj4gICB0aGVyZS4iCgpQdXNo ZWQgdG8gZHJtLWludGVsLWZpeGVzIHdpdGggdGhlIGFib3ZlIG5vdGUgYWRkZWQuIFRoYW5rcyBm b3IgdGhlCnBhdGNoIGFuZCByZXZpZXcuCgpCUiwKSmFuaS4KCgo+Cj4gQ2hyaXMsIGlzIHRoYXQg YW4gYWNjdXJhdGUgZW5vdWdoIGRlc2NyaXB0aW9uIGZvciBKYW5pIHRvIGFkZCB0byB0aGUKPiBw YXRjaD8KPiAtRGFuaWVsCj4+IC0tLQo+PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0u YyB8IDM4ICsrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tCj4+ICAxIGZpbGUg Y2hhbmdlZCwgMjEgaW5zZXJ0aW9ucygrKSwgMTcgZGVsZXRpb25zKC0pCj4+IAo+PiBkaWZmIC0t Z2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYyBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2k5MTVfZ2VtLmMKPj4gaW5kZXggMDkyZjI1Y2ZiOGQ1Li43YTk1ODlmMzhiYmMgMTAwNjQ0 Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMKPj4gKysrIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+PiBAQCAtMjY2MCwyNCArMjY2MCwxMSBAQCBpOTE1 X2dlbV9yZXRpcmVfcmVxdWVzdHNfcmluZyhzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICpyaW5nKQo+ PiAgCj4+ICAJV0FSTl9PTihpOTE1X3ZlcmlmeV9saXN0cyhyaW5nLT5kZXYpKTsKPj4gIAo+PiAt CS8qIE1vdmUgYW55IGJ1ZmZlcnMgb24gdGhlIGFjdGl2ZSBsaXN0IHRoYXQgYXJlIG5vIGxvbmdl ciByZWZlcmVuY2VkCj4+IC0JICogYnkgdGhlIHJpbmdidWZmZXIgdG8gdGhlIGZsdXNoaW5nL2lu YWN0aXZlIGxpc3RzIGFzIGFwcHJvcHJpYXRlLAo+PiAtCSAqIGJlZm9yZSB3ZSBmcmVlIHRoZSBj b250ZXh0IGFzc29jaWF0ZWQgd2l0aCB0aGUgcmVxdWVzdHMuCj4+ICsJLyogUmV0aXJlIHJlcXVl c3RzIGZpcnN0IGFzIHdlIHVzZSBpdCBhYm92ZSBmb3IgdGhlIGVhcmx5IHJldHVybi4KPj4gKwkg KiBJZiB3ZSByZXRpcmUgcmVxdWVzdHMgbGFzdCwgd2UgbWF5IHVzZSBhIGxhdGVyIHNlcW5vIGFu ZCBzbyBjbGVhcgo+PiArCSAqIHRoZSByZXF1ZXN0cyBsaXN0cyB3aXRob3V0IGNsZWFyaW5nIHRo ZSBhY3RpdmUgbGlzdCwgbGVhZGluZyB0bwo+PiArCSAqIGNvbmZ1c2lvbi4KPj4gIAkgKi8KPj4g LQl3aGlsZSAoIWxpc3RfZW1wdHkoJnJpbmctPmFjdGl2ZV9saXN0KSkgewo+PiAtCQlzdHJ1Y3Qg ZHJtX2k5MTVfZ2VtX29iamVjdCAqb2JqOwo+PiAtCj4+IC0JCW9iaiA9IGxpc3RfZmlyc3RfZW50 cnkoJnJpbmctPmFjdGl2ZV9saXN0LAo+PiAtCQkJCSAgICAgIHN0cnVjdCBkcm1faTkxNV9nZW1f b2JqZWN0LAo+PiAtCQkJCSAgICAgIHJpbmdfbGlzdCk7Cj4+IC0KPj4gLQkJaWYgKCFpOTE1X2dl bV9yZXF1ZXN0X2NvbXBsZXRlZChvYmotPmxhc3RfcmVhZF9yZXEsIHRydWUpKQo+PiAtCQkJYnJl YWs7Cj4+IC0KPj4gLQkJaTkxNV9nZW1fb2JqZWN0X21vdmVfdG9faW5hY3RpdmUob2JqKTsKPj4g LQl9Cj4+IC0KPj4gLQo+PiAgCXdoaWxlICghbGlzdF9lbXB0eSgmcmluZy0+cmVxdWVzdF9saXN0 KSkgewo+PiAgCQlzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnJlcXVlc3Q7Cj4+ICAKPj4g QEAgLTI3MDAsNiArMjY4NywyMyBAQCBpOTE1X2dlbV9yZXRpcmVfcmVxdWVzdHNfcmluZyhzdHJ1 Y3QgaW50ZWxfZW5naW5lX2NzICpyaW5nKQo+PiAgCQlpOTE1X2dlbV9mcmVlX3JlcXVlc3QocmVx dWVzdCk7Cj4+ICAJfQo+PiAgCj4+ICsJLyogTW92ZSBhbnkgYnVmZmVycyBvbiB0aGUgYWN0aXZl IGxpc3QgdGhhdCBhcmUgbm8gbG9uZ2VyIHJlZmVyZW5jZWQKPj4gKwkgKiBieSB0aGUgcmluZ2J1 ZmZlciB0byB0aGUgZmx1c2hpbmcvaW5hY3RpdmUgbGlzdHMgYXMgYXBwcm9wcmlhdGUsCj4+ICsJ ICogYmVmb3JlIHdlIGZyZWUgdGhlIGNvbnRleHQgYXNzb2NpYXRlZCB3aXRoIHRoZSByZXF1ZXN0 cy4KPj4gKwkgKi8KPj4gKwl3aGlsZSAoIWxpc3RfZW1wdHkoJnJpbmctPmFjdGl2ZV9saXN0KSkg ewo+PiArCQlzdHJ1Y3QgZHJtX2k5MTVfZ2VtX29iamVjdCAqb2JqOwo+PiArCj4+ICsJCW9iaiA9 IGxpc3RfZmlyc3RfZW50cnkoJnJpbmctPmFjdGl2ZV9saXN0LAo+PiArCQkJCSAgICAgIHN0cnVj dCBkcm1faTkxNV9nZW1fb2JqZWN0LAo+PiArCQkJCSAgICAgIHJpbmdfbGlzdCk7Cj4+ICsKPj4g KwkJaWYgKCFpOTE1X2dlbV9yZXF1ZXN0X2NvbXBsZXRlZChvYmotPmxhc3RfcmVhZF9yZXEsIHRy dWUpKQo+PiArCQkJYnJlYWs7Cj4+ICsKPj4gKwkJaTkxNV9nZW1fb2JqZWN0X21vdmVfdG9faW5h Y3RpdmUob2JqKTsKPj4gKwl9Cj4+ICsKPj4gIAlpZiAodW5saWtlbHkocmluZy0+dHJhY2VfaXJx X3JlcSAmJgo+PiAgCQkgICAgIGk5MTVfZ2VtX3JlcXVlc3RfY29tcGxldGVkKHJpbmctPnRyYWNl X2lycV9yZXEsIHRydWUpKSkgewo+PiAgCQlyaW5nLT5pcnFfcHV0KHJpbmcpOwo+PiAtLSAKPj4g Mi4xLjQKPj4gCj4KPiAtLSAKPiBEYW5pZWwgVmV0dGVyCj4gU29mdHdhcmUgRW5naW5lZXIsIElu dGVsIENvcnBvcmF0aW9uCj4gaHR0cDovL2Jsb2cuZmZ3bGwuY2gKPiBfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QK PiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cDovL2xpc3RzLmZyZWVkZXNr dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAoKLS0gCkphbmkgTmlrdWxhLCBJbnRl bCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5IENlbnRlcgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2ludGVsLWdmeAo=