From: Jani Nikula <jani.nikula@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>,
Xion Zhang <xiong.y.zhang@intel.com>,
Guo Jinxian <jinxianx.guo@intel.com>,
Stable <stable@vger.kernel.org>
Subject: Re: [PATCH] drm/i915: BDW Fix Halo PCI IDs marked as ULT.
Date: Wed, 21 Jan 2015 21:12:07 +0200 [thread overview]
Message-ID: <87sif43q48.fsf@intel.com> (raw)
In-Reply-To: <1421712975-2452-1-git-send-email-rodrigo.vivi@intel.com>
On Tue, 20 Jan 2015, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
> BDW with PCI-IDs ended in "2" aren't ULT, but HALO.
> Let's fix it and at least allow VGA to work on this units.
>
> v2: forgot ammend and v1 doesn't compile
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=87220
> Cc: Xion Zhang <xiong.y.zhang@intel.com>
> Cc: Guo Jinxian <jinxianx.guo@intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Stable <stable@vger.kernel.org>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Pushed to drm-intel-fixes, thanks for the patch.
BR,
Jani.
> ---
> drivers/gpu/drm/i915/i915_drv.h | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index 0be7d40..276320e 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -2292,8 +2292,7 @@ struct drm_i915_cmd_table {
> #define IS_HSW_EARLY_SDV(dev) (IS_HASWELL(dev) && \
> (INTEL_DEVID(dev) & 0xFF00) == 0x0C00)
> #define IS_BDW_ULT(dev) (IS_BROADWELL(dev) && \
> - ((INTEL_DEVID(dev) & 0xf) == 0x2 || \
> - (INTEL_DEVID(dev) & 0xf) == 0x6 || \
> + ((INTEL_DEVID(dev) & 0xf) == 0x6 || \
> (INTEL_DEVID(dev) & 0xf) == 0xe))
> #define IS_BDW_GT3(dev) (IS_BROADWELL(dev) && \
> (INTEL_DEVID(dev) & 0x00F0) == 0x0020)
> --
> 2.1.0
>
--
Jani Nikula, Intel Open Source Technology Center
prev parent reply other threads:[~2015-01-21 19:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-19 21:57 [PATCH] drm/i915: BDW Fix Halo PCI IDs marked as ULT Rodrigo Vivi
2015-01-20 0:16 ` Rodrigo Vivi
2015-01-20 10:36 ` shuang.he
2015-01-21 19:12 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sif43q48.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jinxianx.guo@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=stable@vger.kernel.org \
--cc=xiong.y.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox