From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH 2/2] drm/i915: Reorder hw init to avoid executing with invalid context/mm state Date: Tue, 20 Jan 2015 16:55:56 +0200 Message-ID: <87sif5mrgj.fsf@gaia.fi.intel.com> References: <1417788922-1564-1-git-send-email-chris@chris-wilson.co.uk> <1417788922-1564-2-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 27CB36E16C for ; Tue, 20 Jan 2015 06:57:07 -0800 (PST) In-Reply-To: <1417788922-1564-2-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+IHdyaXRlczoKCj4gQ3VycmVu dGx5IHdlIGluaXRpYWxpc2UgdGhlIHJpbmdzLCBhZGQgdGhlIGZpcnN0IGNvbnRleHQgc3dpdGNo IHRvIHRoZQo+IHJpbmcgYW5kIGV4ZWN1dGUgb3VyIGdvbGRlbiBzdGF0ZSB0aGVuIGVuYWJsZSAo YWxpYXNpbmcgb3IgZnVsbCkgcHBndHQuCj4gSG93ZXZlciwgYXMgd2UgZW5hYmxlIHBwZ3R0IHVz aW5nIGRpcmVjdCBNTUlPIGJ1dCBsb2FkIHRoZSBQRCB1c2luZwo+IE1JX0xSSSwgd2UgZW5kIHVw IGV4ZWN1dGluZyB0aGUgY29udGV4dCBzd2l0Y2ggYW5kIGdvbGRlbiByZW5kZXIgc3RhdGUKPiB3 aXRoIGFuIGludmFsaWQgUEQgZ2VuZXJhdGluZyBwYWdlIGZhdWx0cy4gVG8gc29sdmUgdGhpcyBp c3N1ZSwgZmlyc3QgZG8KPiB0aGUgcHBndHQgUEQgc2V0dXAsIHRoZW4gc2V0IHRoZSBkZWZhdWx0 IGNvbnRleHQgYW5kIHdyaXRlIHRoZSBjb21tYW5kcwo+IHRvIHJ1biB0aGUgcmVuZGVyIHN0YXRl IGludG8gdGhlIHJpbmcsIGJlZm9yZSB3ZSBhY3RpdmF0ZSB0aGUgcmluZy4gVGhpcwo+IGFsbG93 cyB1cyB0byBiZSBzdXJlIHRoYXQgdGhlIHJlZ2lzdGVyIHN0YXRlIGlzIHZhbGlkIGJlZm9yZSB3 ZSBiZWdpbgo+IGV4ZWN1dGlvbi4KPgo+IFRoaXMgd2FzIHNwb3R0ZWQgd2hlbiB3cml0aW5nIHRo ZSBzZXFuby9yZXF1ZXN0IGNvbnZlcnNpb24sIGJ1dCBvbmx5IHdpdGgKPiB0aGUgRVJST1IgY2Fw dHVyZSBkaWQgSSByZWFsaXNlIHRoYXQgaXQgd2FzIGEgbmVjZXNzaXR5IG5vdy4KPgo+IFJGQzog Y2xlYW51cCB0aGUgZXJyb3IgaGFuZGxpbmcgaW4gaTkxNV9nZW1faW5pdF9ody4KPgo+IFNpZ25l ZC1vZmYtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+IC0tLQo+ ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jICAgICAgICAgfCAyMCArKysrKysrKysr LS0tLS0tLS0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmMgfCAg OSArKysrKystLS0KPiAgMiBmaWxlcyBjaGFuZ2VkLCAxNiBpbnNlcnRpb25zKCspLCAxMyBkZWxl dGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5j IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+IGluZGV4IGMxYzExNDE4MjMxYi4u YzEzODQyZDNjYmM5IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2Vt LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4gQEAgLTQ3OTYsMTUg KzQ3OTYsMTUgQEAgaTkxNV9nZW1faW5pdF9odyhzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ICAJ ICovCj4gIAlpbml0X3VudXNlZF9yaW5ncyhkZXYpOwo+ICAKPiAtCWZvcl9lYWNoX3Jpbmcocmlu ZywgZGV2X3ByaXYsIGkpIHsKPiAtCQlyZXQgPSByaW5nLT5pbml0X2h3KHJpbmcpOwo+IC0JCWlm IChyZXQpCj4gLQkJCXJldHVybiByZXQ7Cj4gLQl9Cj4gLQo+ICAJZm9yIChpID0gMDsgaSA8IE5V TV9MM19TTElDRVMoZGV2KTsgaSsrKQo+ICAJCWk5MTVfZ2VtX2wzX3JlbWFwKCZkZXZfcHJpdi0+ cmluZ1tSQ1NdLCBpKTsKPiAgCgpTaG91bGQgd2UgbW92ZSB0aGlzIGFmdGVyIHRoZSBwcGd0dCBo YXMgYmVlbiBpbml0PyAob3IgYWx0ZXJuYXRpdmVseQpsZXQgZG9fc3dpdGNoIGhhbmRsZSBpdCkK Cj4gKwlyZXQgPSBpOTE1X3BwZ3R0X2luaXRfaHcoZGV2KTsKPiArCWlmIChyZXQgJiYgcmV0ICE9 IC1FSU8pIHsKPiArCQlEUk1fRVJST1IoIlBQR1RUIGVuYWJsZSBmYWlsZWQgJWRcbiIsIHJldCk7 Cj4gKwkJaTkxNV9nZW1fY2xlYW51cF9yaW5nYnVmZmVyKGRldik7Cj4gKwl9Cj4gKwo+ICAJLyoK PiAgCSAqIFhYWDogQ29udGV4dHMgc2hvdWxkIG9ubHkgYmUgaW5pdGlhbGl6ZWQgb25jZS4gRG9p bmcgYSBzd2l0Y2ggdG8gdGhlCj4gIAkgKiBkZWZhdWx0IGNvbnRleHQgc3dpdGNoIGhvd2V2ZXIg aXMgc29tZXRoaW5nIHdlJ2QgbGlrZSB0byBkbyBhZnRlcgo+IEBAIC00ODIwLDEwICs0ODIwLDEw IEBAIGk5MTVfZ2VtX2luaXRfaHcoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiAgCQlyZXR1cm4g cmV0Owo+ICAJfQoKVGhlIGNvbW1lbnQgbmVlZHMgdHdlYWtpbmcgYXMgaXQgcmVhZHMgCgovKiBD b250ZXh0IHN3aXRjaGluZyByZXF1aXJlcyByaW5ncyAoZm9yICogdGhlIGRvX3N3aXRjaCksIGJ1 dCBiZWZvcmUKICogZW5hYmxpbmcgUFBHVFQuIFNvIGRvbid0IG1vdmUgdGhpcy4iCiovCgpJZiBJ IHJlYWQgdGhlIHBhdGNoIGNvcnJlY3RseSB5b3Ugd2FudCB0byBrZWVwIHRoZSByaW5nIGhlYWQv dGFpbApib29ra2VlcGluZyBpbnRhY3Qgc28gdGhhdCB5b3UgY2FuIHB1c2ggdGhlIGN0eF9zd2l0 Y2ggaW50byB0aGUgYnVmZmVyCmJlZm9yZSB0aGUgYWN0dWFsIHJpbmcgaHcgaXMgYWN0aXZhdGVk PwoKRG9lcyB0aGlzIHRoZW4gZW5hYmxlIHlvdSB0byBnZXQgcmlkIG9mIHRoZSB3aG9sZSBwcmUg ZW1pdHRpbmcgb2YKbDNyZW1hcCBzdHVmZiBhbmQganVzdCBsZXQgdGhlIGRvX3N3aXRjaCBoYW5k bGUgbDNyZW1hcD8KCi1NaWthCgo+IC0JcmV0ID0gaTkxNV9wcGd0dF9pbml0X2h3KGRldik7Cj4g LQlpZiAocmV0ICYmIHJldCAhPSAtRUlPKSB7Cj4gLQkJRFJNX0VSUk9SKCJQUEdUVCBlbmFibGUg ZmFpbGVkICVkXG4iLCByZXQpOwo+IC0JCWk5MTVfZ2VtX2NsZWFudXBfcmluZ2J1ZmZlcihkZXYp Owo+ICsJZm9yX2VhY2hfcmluZyhyaW5nLCBkZXZfcHJpdiwgaSkgewo+ICsJCXJldCA9IHJpbmct PmluaXRfaHcocmluZyk7Cj4gKwkJaWYgKHJldCkKPiArCQkJcmV0dXJuIHJldDsKPiAgCX0KPiAg Cj4gIAlyZXR1cm4gcmV0Owo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9yaW5nYnVmZmVyLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmMK PiBpbmRleCBkZTM4YjA0MTM1ZDIuLjk1ZWJjZTczZDQ2ZCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9yaW5nYnVmZmVyLmMKPiBAQCAtNTg1LDYgKzU4NSw5IEBAIHN0YXRpYyBpbnQg aW5pdF9yaW5nX2NvbW1vbihzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICpyaW5nKQo+ICAJSTkxNV9X UklURV9IRUFEKHJpbmcsIDApOwo+ICAJKHZvaWQpSTkxNV9SRUFEX0hFQUQocmluZyk7Cj4gIAo+ ICsJSTkxNV9XUklURV9IRUFEKHJpbmcsIHJpbmdidWYtPmhlYWQpOwo+ICsJSTkxNV9XUklURV9U QUlMKHJpbmcsIHJpbmdidWYtPmhlYWQpOwo+ICsKPiAgCUk5MTVfV1JJVEVfQ1RMKHJpbmcsCj4g IAkJCSgocmluZ2J1Zi0+c2l6ZSAtIFBBR0VfU0laRSkgJiBSSU5HX05SX1BBR0VTKQo+ICAJCQl8 IFJJTkdfVkFMSUQpOwo+IEBAIC01OTIsNyArNTk1LDcgQEAgc3RhdGljIGludCBpbml0X3Jpbmdf Y29tbW9uKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKnJpbmcpCj4gIAkvKiBJZiB0aGUgaGVhZCBp cyBzdGlsbCBub3QgemVybywgdGhlIHJpbmcgaXMgZGVhZCAqLwo+ICAJaWYgKHdhaXRfZm9yKChJ OTE1X1JFQURfQ1RMKHJpbmcpICYgUklOR19WQUxJRCkgIT0gMCAmJgo+ICAJCSAgICAgSTkxNV9S RUFEX1NUQVJUKHJpbmcpID09IGk5MTVfZ2VtX29ial9nZ3R0X29mZnNldChvYmopICYmCj4gLQkJ ICAgICAoSTkxNV9SRUFEX0hFQUQocmluZykgJiBIRUFEX0FERFIpID09IDAsIDUwKSkgewo+ICsJ CSAgICAgKEk5MTVfUkVBRF9IRUFEKHJpbmcpICYgSEVBRF9BRERSKSA9PSByaW5nYnVmLT5oZWFk LCA1MCkpIHsKPiAgCQlEUk1fRVJST1IoIiVzIGluaXRpYWxpemF0aW9uIGZhaWxlZCAiCj4gIAkJ CSAgImN0bCAlMDh4ICh2YWxpZD8gJWQpIGhlYWQgJTA4eCB0YWlsICUwOHggc3RhcnQgJTA4eCBb ZXhwZWN0ZWQgJTA4bHhdXG4iLAo+ICAJCQkgIHJpbmctPm5hbWUsCj4gQEAgLTYwMyw5ICs2MDYs OSBAQCBzdGF0aWMgaW50IGluaXRfcmluZ19jb21tb24oc3RydWN0IGludGVsX2VuZ2luZV9jcyAq cmluZykKPiAgCQlnb3RvIG91dDsKPiAgCX0KPiAgCj4gKwlJOTE1X1dSSVRFX1RBSUwocmluZywg cmluZ2J1Zi0+dGFpbCk7Cj4gKwo+ICAJcmluZ2J1Zi0+bGFzdF9yZXRpcmVkX2hlYWQgPSAtMTsK PiAtCXJpbmdidWYtPmhlYWQgPSBJOTE1X1JFQURfSEVBRChyaW5nKTsKPiAtCXJpbmdidWYtPnRh aWwgPSBJOTE1X1JFQURfVEFJTChyaW5nKSAmIFRBSUxfQUREUjsKPiAgCWludGVsX3JpbmdfdXBk YXRlX3NwYWNlKHJpbmdidWYpOwo+ICAKPiAgCW1lbXNldCgmcmluZy0+aGFuZ2NoZWNrLCAwLCBz aXplb2YocmluZy0+aGFuZ2NoZWNrKSk7Cj4gLS0gCj4gMi4xLjMKPgo+IF9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlz dAo+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwt Z2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==