From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH 1/5] drm/i915: Print captured bo for all VM in error state Date: Thu, 14 Aug 2014 13:18:46 +0300 Message-ID: <87sikzxtkp.fsf@gaia.fi.intel.com> References: <1407870351-6064-1-git-send-email-chris@chris-wilson.co.uk> <87lhqs1m0x.fsf@gaia.fi.intel.com> <20140814065045.GJ10052@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 3D1996E31F for ; Thu, 14 Aug 2014 03:18:50 -0700 (PDT) In-Reply-To: <20140814065045.GJ10052@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Chris Wilson writes: > On Wed, Aug 13, 2014 at 05:50:38PM +0300, Mika Kuoppala wrote: >> Chris Wilson writes: >> >> > The current error state harks back to the era of just a single VM. For >> > full-ppgtt, we capture every bo on every VM. It behoves us to then print >> > every bo for every VM, which we currently fail to do and so miss vital >> > information in the error state. >> > >> > v2: Use the vma address rather than -1! >> > >> > Signed-off-by: Chris Wilson >> >> Offsets can collide between different vm areas. >> >> If we add vm index also to the captured batchbuffer objects, >> we could print it part of the offset '%d:0x%x' that would easily >> identify vm and we would immediately see what vm was active on a ring. > > The offsets are printed out per-vm. You want to be more specific in your > complaint. Based on earlier discussion, I think you just want to know > the guilty vm. > -Chris Yes. And it can be done as a follow up too. 1/5: Reviewed-by: Mika Kuoppala