From: Jani Nikula <jani.nikula@intel.com>
To: David Woodhouse <dwmw2@infradead.org>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2 for -fixes] drm/i915: Disable stolen memory when DMAR is active
Date: Thu, 20 Mar 2014 11:23:43 +0200 [thread overview]
Message-ID: <87siqdw7ds.fsf@intel.com> (raw)
In-Reply-To: <1395301759.19007.66.camel@shinybook.infradead.org>
On Thu, 20 Mar 2014, David Woodhouse <dwmw2@infradead.org> wrote:
> On Thu, 2014-03-20 at 09:36 +0200, Jani Nikula wrote:
>>
>> Or an additional knob, in case it's really not working and people want
>> to get other things depending on prelim hw support done.
>
> Yeah. Perhaps the best answer is a 'disable_silicon_workarounds' option,
> to disable *all* workarounds for silicon bugs. Couple that with a printk
> telling the user that workarounds are disabled *and* VT-d is enabled.
>
> That's a nice simple thing for the chipset validation folks to be
> looking for. Unless they see that and have no issues with either
> framebuffer or X, the chipset hasn't been tested.
>
> That aside, I'm also unhappy with your patch on general principles. As a
> rule I'd like to see references to a *specific* published erratum, for
> anything we disable. Otherwise we're just admitting that life is too
> hard and we *never* bother to test our silicon before we ship it and we
> *expect* it to be broken.
>
> If we chase broken hardware to the point where errata are published, we
> should hopefully ensure that the problem feeds back to the validation
> folks who haven't done their job properly. Every time.
>
> (Pondered making this an internal email, but hey — *you're* the one who
> said "our hardware is always broken and we don't even bother to track
> individual brokenness". I'm just translating it into English from what's
> in your patch :)
I'll have to dodge this particular discussion, just because it was
really Chris' patch which I merely repainted with colours requested by
our resident interior designer Daniel. ;)
BR,
Jani.
>
> --
> dwmw2
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2014-03-20 9:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-28 12:14 [PATCH] drm/i915: Disable stolen memory when DMAR is active Chris Wilson
2014-03-05 15:17 ` Daniel Vetter
2014-03-05 15:32 ` Chris Wilson
2014-03-05 17:39 ` Daniel Vetter
2014-03-14 13:10 ` Jani Nikula
2014-03-18 12:59 ` [PATCH v2 for -fixes] " Jani Nikula
2014-03-18 16:48 ` Daniel Vetter
2014-03-18 16:50 ` Daniel Vetter
2014-03-19 9:07 ` Jani Nikula
2014-03-19 20:51 ` David Woodhouse
2014-03-20 7:36 ` Jani Nikula
2014-03-20 7:49 ` David Woodhouse
2014-03-20 9:23 ` Jani Nikula [this message]
2014-03-20 9:45 ` Daniel Vetter
2014-03-20 10:21 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87siqdw7ds.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=dwmw2@infradead.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox