From: Jani Nikula <jani.nikula@linux.intel.com>
To: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH] drm/i915: Remove erronous WARN in the vlv pipe crc code
Date: Thu, 13 Mar 2014 19:52:45 +0200 [thread overview]
Message-ID: <87siqm56ky.fsf@intel.com> (raw)
In-Reply-To: <1394729162-23133-1-git-send-email-daniel.vetter@ffwll.ch>
On Thu, 13 Mar 2014, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> It's been in there since forever, and no one cared. Doesn't put a too
> good light onto our bug handling and QA efforts really ...
>
> References: https://bugs.freedesktop.org/attachment.cgi?id=90970
Is there a bug report for this, or did you just spot this in an
unrelated bug?
BR,
Jani.
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
> drivers/gpu/drm/i915/i915_debugfs.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> index d90a70744d93..92eea70ed7b8 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -2559,8 +2559,6 @@ static int vlv_pipe_crc_ctl_reg(struct drm_device *dev,
> if (need_stable_symbols) {
> uint32_t tmp = I915_READ(PORT_DFT2_G4X);
>
> - WARN_ON(!IS_G4X(dev));
> -
> tmp |= DC_BALANCE_RESET_VLV;
> if (pipe == PIPE_A)
> tmp |= PIPE_A_SCRAMBLE_RESET;
> --
> 1.8.5.2
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Technology Center
next prev parent reply other threads:[~2014-03-13 17:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-13 16:46 [PATCH] drm/i915: Remove erronous WARN in the vlv pipe crc code Daniel Vetter
2014-03-13 17:52 ` Jani Nikula [this message]
2014-03-13 18:43 ` Daniel Vetter
2014-03-14 13:07 ` Jani Nikula
2014-03-14 13:55 ` Daniel Vetter
2014-03-14 14:17 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87siqm56ky.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox