* [PATCH] drm/i915: Remove erronous WARN in the vlv pipe crc code
@ 2014-03-13 16:46 Daniel Vetter
2014-03-13 17:52 ` Jani Nikula
0 siblings, 1 reply; 6+ messages in thread
From: Daniel Vetter @ 2014-03-13 16:46 UTC (permalink / raw)
To: Intel Graphics Development; +Cc: Daniel Vetter
It's been in there since forever, and no one cared. Doesn't put a too
good light onto our bug handling and QA efforts really ...
References: https://bugs.freedesktop.org/attachment.cgi?id=90970
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
drivers/gpu/drm/i915/i915_debugfs.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
index d90a70744d93..92eea70ed7b8 100644
--- a/drivers/gpu/drm/i915/i915_debugfs.c
+++ b/drivers/gpu/drm/i915/i915_debugfs.c
@@ -2559,8 +2559,6 @@ static int vlv_pipe_crc_ctl_reg(struct drm_device *dev,
if (need_stable_symbols) {
uint32_t tmp = I915_READ(PORT_DFT2_G4X);
- WARN_ON(!IS_G4X(dev));
-
tmp |= DC_BALANCE_RESET_VLV;
if (pipe == PIPE_A)
tmp |= PIPE_A_SCRAMBLE_RESET;
--
1.8.5.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] drm/i915: Remove erronous WARN in the vlv pipe crc code
2014-03-13 16:46 [PATCH] drm/i915: Remove erronous WARN in the vlv pipe crc code Daniel Vetter
@ 2014-03-13 17:52 ` Jani Nikula
2014-03-13 18:43 ` Daniel Vetter
0 siblings, 1 reply; 6+ messages in thread
From: Jani Nikula @ 2014-03-13 17:52 UTC (permalink / raw)
To: Intel Graphics Development; +Cc: Daniel Vetter
On Thu, 13 Mar 2014, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> It's been in there since forever, and no one cared. Doesn't put a too
> good light onto our bug handling and QA efforts really ...
>
> References: https://bugs.freedesktop.org/attachment.cgi?id=90970
Is there a bug report for this, or did you just spot this in an
unrelated bug?
BR,
Jani.
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
> drivers/gpu/drm/i915/i915_debugfs.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> index d90a70744d93..92eea70ed7b8 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -2559,8 +2559,6 @@ static int vlv_pipe_crc_ctl_reg(struct drm_device *dev,
> if (need_stable_symbols) {
> uint32_t tmp = I915_READ(PORT_DFT2_G4X);
>
> - WARN_ON(!IS_G4X(dev));
> -
> tmp |= DC_BALANCE_RESET_VLV;
> if (pipe == PIPE_A)
> tmp |= PIPE_A_SCRAMBLE_RESET;
> --
> 1.8.5.2
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drm/i915: Remove erronous WARN in the vlv pipe crc code
2014-03-13 17:52 ` Jani Nikula
@ 2014-03-13 18:43 ` Daniel Vetter
2014-03-14 13:07 ` Jani Nikula
0 siblings, 1 reply; 6+ messages in thread
From: Daniel Vetter @ 2014-03-13 18:43 UTC (permalink / raw)
To: Jani Nikula; +Cc: Daniel Vetter, Intel Graphics Development
On Thu, Mar 13, 2014 at 07:52:45PM +0200, Jani Nikula wrote:
> On Thu, 13 Mar 2014, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> > It's been in there since forever, and no one cared. Doesn't put a too
> > good light onto our bug handling and QA efforts really ...
> >
> > References: https://bugs.freedesktop.org/attachment.cgi?id=90970
>
> Is there a bug report for this, or did you just spot this in an
> unrelated bug?
The bug report complains that the crc stuff doesn't work on byt edp, but
dmesg contains a pile of these WARNs. Hence just references, since this
likely won't fix the actual bug.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915: Remove erronous WARN in the vlv pipe crc code
2014-03-13 18:43 ` Daniel Vetter
@ 2014-03-14 13:07 ` Jani Nikula
2014-03-14 13:55 ` Daniel Vetter
0 siblings, 1 reply; 6+ messages in thread
From: Jani Nikula @ 2014-03-14 13:07 UTC (permalink / raw)
To: Daniel Vetter; +Cc: Daniel Vetter, Intel Graphics Development
On Thu, 13 Mar 2014, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Thu, Mar 13, 2014 at 07:52:45PM +0200, Jani Nikula wrote:
>> On Thu, 13 Mar 2014, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
>> > It's been in there since forever, and no one cared. Doesn't put a too
>> > good light onto our bug handling and QA efforts really ...
>> >
>> > References: https://bugs.freedesktop.org/attachment.cgi?id=90970
>>
>> Is there a bug report for this, or did you just spot this in an
>> unrelated bug?
>
> The bug report complains that the crc stuff doesn't work on byt edp, but
> dmesg contains a pile of these WARNs. Hence just references, since this
> likely won't fix the actual bug.
Pushed to -fixes, thanks for the patch.
BR,
Jani.
> -Daniel
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> +41 (0) 79 365 57 48 - http://blog.ffwll.ch
--
Jani Nikula, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915: Remove erronous WARN in the vlv pipe crc code
2014-03-14 13:07 ` Jani Nikula
@ 2014-03-14 13:55 ` Daniel Vetter
2014-03-14 14:17 ` Jani Nikula
0 siblings, 1 reply; 6+ messages in thread
From: Daniel Vetter @ 2014-03-14 13:55 UTC (permalink / raw)
To: Jani Nikula; +Cc: Intel Graphics Development
On Fri, Mar 14, 2014 at 2:07 PM, Jani Nikula
<jani.nikula@linux.intel.com> wrote:
>> The bug report complains that the crc stuff doesn't work on byt edp, but
>> dmesg contains a pile of these WARNs. Hence just references, since this
>> likely won't fix the actual bug.
>
> Pushed to -fixes, thanks for the patch.
Imo not -fixes material, since only our own validation tools can hit
this. And only through debugfs, so not even nasty userspace can
trigger this without being root.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915: Remove erronous WARN in the vlv pipe crc code
2014-03-14 13:55 ` Daniel Vetter
@ 2014-03-14 14:17 ` Jani Nikula
0 siblings, 0 replies; 6+ messages in thread
From: Jani Nikula @ 2014-03-14 14:17 UTC (permalink / raw)
To: Daniel Vetter; +Cc: Intel Graphics Development
On Fri, 14 Mar 2014, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Fri, Mar 14, 2014 at 2:07 PM, Jani Nikula
> <jani.nikula@linux.intel.com> wrote:
>>> The bug report complains that the crc stuff doesn't work on byt edp, but
>>> dmesg contains a pile of these WARNs. Hence just references, since this
>>> likely won't fix the actual bug.
>>
>> Pushed to -fixes, thanks for the patch.
>
> Imo not -fixes material, since only our own validation tools can hit
> this. And only through debugfs, so not even nasty userspace can
> trigger this without being root.
Pulled back from -fixes. It didn't happen.
Jani.
--
Jani Nikula, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-03-14 14:17 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-13 16:46 [PATCH] drm/i915: Remove erronous WARN in the vlv pipe crc code Daniel Vetter
2014-03-13 17:52 ` Jani Nikula
2014-03-13 18:43 ` Daniel Vetter
2014-03-14 13:07 ` Jani Nikula
2014-03-14 13:55 ` Daniel Vetter
2014-03-14 14:17 ` Jani Nikula
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox