From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2E233C5478C for ; Tue, 27 Feb 2024 09:15:51 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AEEE410F2C6; Tue, 27 Feb 2024 09:15:50 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="ZRwrWTdo"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) by gabe.freedesktop.org (Postfix) with ESMTPS id BD21710F2C6 for ; Tue, 27 Feb 2024 09:15:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709025350; x=1740561350; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=HTgM0AeUatLQMrLyirvVPv0xssurYTYs9wyfX2RyZ1w=; b=ZRwrWTdogq+VkhNA3xQgQFy5fMDB3UW/n7WqUW1i/iNDt7V0VvczImEK mkjtD5O5qU8gDYtu4VW0sEThMXsDX4bLPuzejj7BTHbGtQFxIAQO4vIZH Wm/TH+AjEe1PS1WCsI7BTCX7XmxT7O819eOhI/0X3JIBS41nwyCuLPCdO qH76ZwdX6BzcvRc6iGkmHT7+gJMa4KhzSNdQg9Mn9btfM0QbxLlqGjppS tslO1yJLpsmszj2615zw1gFcrc5t1H46Hf3UsQHtLkcF/NYlzXotbfODi 1lMzVefoDIVxUU0ydmvZtl1mc9+S2SEduZCftNsD+V6PIyS9rXZ9y97M8 w==; X-IronPort-AV: E=McAfee;i="6600,9927,10996"; a="3229951" X-IronPort-AV: E=Sophos;i="6.06,187,1705392000"; d="scan'208";a="3229951" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Feb 2024 01:15:49 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,187,1705392000"; d="scan'208";a="6912397" Received: from bdallmer-mobl1.ger.corp.intel.com (HELO localhost) ([10.252.49.187]) by fmviesa009-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Feb 2024 01:15:47 -0800 From: Jani Nikula To: "Lisovskiy, Stanislav" Cc: intel-gfx@lists.freedesktop.org, jani.saarinen@intel.com, ville.syrjala@linux.intel.com, vidya.srinivas@intel.com Subject: Re: [PATCH 3/3] drm/i915: Fix bigjoiner case for DP2.0 In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20240221192010.25413-1-stanislav.lisovskiy@intel.com> <20240221192010.25413-4-stanislav.lisovskiy@intel.com> <87o7c3knj9.fsf@intel.com> Date: Tue, 27 Feb 2024 11:15:43 +0200 Message-ID: <87ttlujmio.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, 27 Feb 2024, "Lisovskiy, Stanislav" wrote: > On Mon, Feb 26, 2024 at 09:56:10PM +0200, Jani Nikula wrote: >> On Wed, 21 Feb 2024, Stanislav Lisovskiy wrote: >> > Patch calculates bigjoiner pipes in mst compute. >> > Patch also passes bigjoiner bool to validate plane >> > max size. >> >> Please use the imperative mood in commit messages, e.g. "calculate" >> intead of "calculates". >> >> Please do not refer to "patch". We know it's a patch, until it isn't, >> and then it's a commit. >> >> Please explain *why* the changes are being done, not just *what* is >> being done. >> >> In the subject, what is "bigjoiner case for DP2.0"? DP 2.0 is a spec >> version, and as such irrelevant for the changes being done. >> >> > Signed-off-by: vsrini4 >> >> ? > > Hi Jani, I just added that patch from Vidya to my series, to be honest, > didn't have time at all to look much into it. > Looks like its me who is going to fix that. Should the original authorship be preserved? If not, please add Co-developed-by. Just having the Signed-off-by is not enough. BR, Jani. > >> >> > Signed-off-by: Stanislav Lisovskiy >> > --- >> > drivers/gpu/drm/i915/display/intel_dp_mst.c | 19 ++++++++++++------- >> > 1 file changed, 12 insertions(+), 7 deletions(-) >> > >> > diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c b/drivers/gpu/drm/i915/display/intel_dp_mst.c >> > index 5307ddd4edcf5..fd27d9976c050 100644 >> > --- a/drivers/gpu/drm/i915/display/intel_dp_mst.c >> > +++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c >> > @@ -523,6 +523,7 @@ static int intel_dp_mst_compute_config(struct intel_encoder *encoder, >> > struct drm_connector_state *conn_state) >> > { >> > struct drm_i915_private *dev_priv = to_i915(encoder->base.dev); >> > + struct intel_crtc *crtc = to_intel_crtc(pipe_config->uapi.crtc); >> > struct intel_dp_mst_encoder *intel_mst = enc_to_mst(encoder); >> > struct intel_dp *intel_dp = &intel_mst->primary->dp; >> > const struct intel_connector *connector = >> > @@ -540,6 +541,10 @@ static int intel_dp_mst_compute_config(struct intel_encoder *encoder, >> > if (adjusted_mode->flags & DRM_MODE_FLAG_DBLSCAN) >> > return -EINVAL; >> > >> > + if (intel_dp_need_bigjoiner(intel_dp, adjusted_mode->crtc_hdisplay, >> > + adjusted_mode->crtc_clock)) >> > + pipe_config->bigjoiner_pipes = GENMASK(crtc->pipe + 1, crtc->pipe); >> > + >> > pipe_config->sink_format = INTEL_OUTPUT_FORMAT_RGB; >> > pipe_config->output_format = INTEL_OUTPUT_FORMAT_RGB; >> > pipe_config->has_pch_encoder = false; >> > @@ -1318,12 +1323,6 @@ intel_dp_mst_mode_valid_ctx(struct drm_connector *connector, >> > * corresponding link capabilities of the sink) in case the >> > * stream is uncompressed for it by the last branch device. >> > */ >> > - if (mode_rate > max_rate || mode->clock > max_dotclk || >> > - drm_dp_calc_pbn_mode(mode->clock, min_bpp << 4) > port->full_pbn) { >> > - *status = MODE_CLOCK_HIGH; >> > - return 0; >> > - } >> > - >> > if (mode->clock < 10000) { >> > *status = MODE_CLOCK_LOW; >> > return 0; >> > @@ -1343,6 +1342,12 @@ intel_dp_mst_mode_valid_ctx(struct drm_connector *connector, >> > return 0; >> > } >> > >> > + if (mode_rate > max_rate || mode->clock > max_dotclk || >> > + drm_dp_calc_pbn_mode(mode->clock, min_bpp << 4) > port->full_pbn) { >> > + *status = MODE_CLOCK_HIGH; >> > + return 0; >> > + } >> > + >> > if (DISPLAY_VER(dev_priv) >= 10 && >> > drm_dp_sink_supports_dsc(intel_connector->dp.dsc_dpcd)) { >> > /* >> > @@ -1385,7 +1390,7 @@ intel_dp_mst_mode_valid_ctx(struct drm_connector *connector, >> > return 0; >> > } >> > >> > - *status = intel_mode_valid_max_plane_size(dev_priv, mode, false); >> > + *status = intel_mode_valid_max_plane_size(dev_priv, mode, bigjoiner); >> > return 0; >> > } >> >> -- >> Jani Nikula, Intel -- Jani Nikula, Intel