* [Intel-gfx] [PATCH v4] drm/i915/slpc: Optmize waitboost for SLPC
@ 2022-10-22 0:24 Vinay Belgaumkar
2022-10-22 0:57 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/slpc: Optmize waitboost for SLPC (rev4) Patchwork
` (3 more replies)
0 siblings, 4 replies; 8+ messages in thread
From: Vinay Belgaumkar @ 2022-10-22 0:24 UTC (permalink / raw)
To: intel-gfx, dri-devel
Waitboost (when SLPC is enabled) results in a H2G message. This can result
in thousands of messages during a stress test and fill up an already full
CTB. There is no need to request for RP0 if boost_freq and the min softlimit
are the same.
v2: Add the tracing back, and check requested freq
in the worker thread (Tvrtko)
v3: Check requested freq in dec_waiters as well
v4: Only check min_softlimit against boost_freq. Limit this
optimization for server parts for now.
Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
---
drivers/gpu/drm/i915/gt/intel_rps.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_rps.c b/drivers/gpu/drm/i915/gt/intel_rps.c
index fc23c562d9b2..32e1f5dde5bb 100644
--- a/drivers/gpu/drm/i915/gt/intel_rps.c
+++ b/drivers/gpu/drm/i915/gt/intel_rps.c
@@ -1016,9 +1016,15 @@ void intel_rps_boost(struct i915_request *rq)
if (rps_uses_slpc(rps)) {
slpc = rps_to_slpc(rps);
+ if (slpc->min_freq_softlimit == slpc->boost_freq)
+ return;
+
/* Return if old value is non zero */
- if (!atomic_fetch_inc(&slpc->num_waiters))
+ if (!atomic_fetch_inc(&slpc->num_waiters)) {
+ GT_TRACE(rps_to_gt(rps), "boost fence:%llx:%llx\n",
+ rq->fence.context, rq->fence.seqno);
schedule_work(&slpc->boost_work);
+ }
return;
}
--
2.35.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/slpc: Optmize waitboost for SLPC (rev4)
2022-10-22 0:24 [Intel-gfx] [PATCH v4] drm/i915/slpc: Optmize waitboost for SLPC Vinay Belgaumkar
@ 2022-10-22 0:57 ` Patchwork
2022-10-22 1:19 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
` (2 subsequent siblings)
3 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2022-10-22 0:57 UTC (permalink / raw)
To: Vinay Belgaumkar; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/slpc: Optmize waitboost for SLPC (rev4)
URL : https://patchwork.freedesktop.org/series/109840/
State : warning
== Summary ==
Error: dim checkpatch failed
b3036f6cf9d0 drm/i915/slpc: Optmize waitboost for SLPC
-:8: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#8:
CTB. There is no need to request for RP0 if boost_freq and the min softlimit
total: 0 errors, 1 warnings, 0 checks, 16 lines checked
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/slpc: Optmize waitboost for SLPC (rev4)
2022-10-22 0:24 [Intel-gfx] [PATCH v4] drm/i915/slpc: Optmize waitboost for SLPC Vinay Belgaumkar
2022-10-22 0:57 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/slpc: Optmize waitboost for SLPC (rev4) Patchwork
@ 2022-10-22 1:19 ` Patchwork
2022-10-22 2:11 ` [Intel-gfx] [PATCH v4] drm/i915/slpc: Optmize waitboost for SLPC Dixit, Ashutosh
2022-10-22 22:33 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/slpc: Optmize waitboost for SLPC (rev4) Patchwork
3 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2022-10-22 1:19 UTC (permalink / raw)
To: Vinay Belgaumkar; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 7980 bytes --]
== Series Details ==
Series: drm/i915/slpc: Optmize waitboost for SLPC (rev4)
URL : https://patchwork.freedesktop.org/series/109840/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12277 -> Patchwork_109840v4
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/index.html
Participating hosts (43 -> 41)
------------------------------
Missing (2): fi-ctg-p8600 fi-bdw-samus
Known issues
------------
Here are the changes found in Patchwork_109840v4 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_gttfill@basic:
- fi-pnv-d510: [PASS][1] -> [FAIL][2] ([i915#7229])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12277/fi-pnv-d510/igt@gem_exec_gttfill@basic.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/fi-pnv-d510/igt@gem_exec_gttfill@basic.html
* igt@gem_tiled_blits@basic:
- fi-pnv-d510: [PASS][3] -> [SKIP][4] ([fdo#109271]) +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12277/fi-pnv-d510/igt@gem_tiled_blits@basic.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/fi-pnv-d510/igt@gem_tiled_blits@basic.html
* igt@i915_selftest@live@hangcheck:
- fi-hsw-4770: [PASS][5] -> [INCOMPLETE][6] ([i915#4785])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12277/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-bdw-5557u: NOTRUN -> [SKIP][7] ([fdo#109271] / [fdo#111827])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/fi-bdw-5557u/igt@kms_chamelium@common-hpd-after-suspend.html
- bat-adlp-4: NOTRUN -> [SKIP][8] ([fdo#111827])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/bat-adlp-4/igt@kms_chamelium@common-hpd-after-suspend.html
* igt@kms_pipe_crc_basic@suspend-read-crc:
- bat-adlp-4: NOTRUN -> [SKIP][9] ([i915#3546])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/bat-adlp-4/igt@kms_pipe_crc_basic@suspend-read-crc.html
* igt@runner@aborted:
- fi-hsw-4770: NOTRUN -> [FAIL][10] ([fdo#109271] / [i915#4312] / [i915#5594])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/fi-hsw-4770/igt@runner@aborted.html
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s0@smem:
- {bat-adlm-1}: [DMESG-WARN][11] ([i915#2867]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12277/bat-adlm-1/igt@gem_exec_suspend@basic-s0@smem.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/bat-adlm-1/igt@gem_exec_suspend@basic-s0@smem.html
* igt@gem_exec_suspend@basic-s3@smem:
- {bat-rplp-1}: [DMESG-WARN][13] ([i915#2867]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12277/bat-rplp-1/igt@gem_exec_suspend@basic-s3@smem.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/bat-rplp-1/igt@gem_exec_suspend@basic-s3@smem.html
* igt@gem_huc_copy@huc-copy:
- {bat-atsm-1}: [FAIL][15] ([i915#7029]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12277/bat-atsm-1/igt@gem_huc_copy@huc-copy.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/bat-atsm-1/igt@gem_huc_copy@huc-copy.html
* igt@i915_module_load@load:
- {bat-dg2-8}: [FAIL][17] -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12277/bat-dg2-8/igt@i915_module_load@load.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/bat-dg2-8/igt@i915_module_load@load.html
* igt@i915_selftest@live@migrate:
- bat-adlp-4: [INCOMPLETE][19] ([i915#7308]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12277/bat-adlp-4/igt@i915_selftest@live@migrate.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/bat-adlp-4/igt@i915_selftest@live@migrate.html
* igt@i915_selftest@live@reset:
- {bat-rpls-1}: [DMESG-FAIL][21] ([i915#4983]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12277/bat-rpls-1/igt@i915_selftest@live@reset.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/bat-rpls-1/igt@i915_selftest@live@reset.html
* igt@i915_suspend@basic-s3-without-i915:
- fi-bdw-5557u: [INCOMPLETE][23] ([i915#146]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12277/fi-bdw-5557u/igt@i915_suspend@basic-s3-without-i915.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/fi-bdw-5557u/igt@i915_suspend@basic-s3-without-i915.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#146]: https://gitlab.freedesktop.org/drm/intel/issues/146
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4785]: https://gitlab.freedesktop.org/drm/intel/issues/4785
[i915#4873]: https://gitlab.freedesktop.org/drm/intel/issues/4873
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190
[i915#5274]: https://gitlab.freedesktop.org/drm/intel/issues/5274
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#5537]: https://gitlab.freedesktop.org/drm/intel/issues/5537
[i915#5594]: https://gitlab.freedesktop.org/drm/intel/issues/5594
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6645]: https://gitlab.freedesktop.org/drm/intel/issues/6645
[i915#6687]: https://gitlab.freedesktop.org/drm/intel/issues/6687
[i915#7029]: https://gitlab.freedesktop.org/drm/intel/issues/7029
[i915#7229]: https://gitlab.freedesktop.org/drm/intel/issues/7229
[i915#7308]: https://gitlab.freedesktop.org/drm/intel/issues/7308
Build changes
-------------
* Linux: CI_DRM_12277 -> Patchwork_109840v4
CI-20190529: 20190529
CI_DRM_12277: 382f329699fb46e1fccb50f6ada2af090d07686d @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7022: d73b21e653555d2e0370789071799aa0037049c1 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_109840v4: 382f329699fb46e1fccb50f6ada2af090d07686d @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
805b12bfd54d drm/i915/slpc: Optmize waitboost for SLPC
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/index.html
[-- Attachment #2: Type: text/html, Size: 7703 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH v4] drm/i915/slpc: Optmize waitboost for SLPC
2022-10-22 0:24 [Intel-gfx] [PATCH v4] drm/i915/slpc: Optmize waitboost for SLPC Vinay Belgaumkar
2022-10-22 0:57 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/slpc: Optmize waitboost for SLPC (rev4) Patchwork
2022-10-22 1:19 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
@ 2022-10-22 2:11 ` Dixit, Ashutosh
2022-10-22 17:56 ` Belgaumkar, Vinay
2022-10-22 22:33 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/slpc: Optmize waitboost for SLPC (rev4) Patchwork
3 siblings, 1 reply; 8+ messages in thread
From: Dixit, Ashutosh @ 2022-10-22 2:11 UTC (permalink / raw)
To: Vinay Belgaumkar; +Cc: intel-gfx, dri-devel
On Fri, 21 Oct 2022 17:24:52 -0700, Vinay Belgaumkar wrote:
>
Hi Vinay,
> Waitboost (when SLPC is enabled) results in a H2G message. This can result
> in thousands of messages during a stress test and fill up an already full
> CTB. There is no need to request for RP0 if boost_freq and the min softlimit
> are the same.
>
> v2: Add the tracing back, and check requested freq
> in the worker thread (Tvrtko)
> v3: Check requested freq in dec_waiters as well
> v4: Only check min_softlimit against boost_freq. Limit this
> optimization for server parts for now.
Sorry I didn't follow. Why are we saying limit this only to server? This:
if (slpc->min_freq_softlimit == slpc->boost_freq)
return;
The condition above should work for client too if it is true? But yes it is
typically true automatically for server but not for client. Is that what
you mean?
>
> Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
> ---
> drivers/gpu/drm/i915/gt/intel_rps.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_rps.c b/drivers/gpu/drm/i915/gt/intel_rps.c
> index fc23c562d9b2..32e1f5dde5bb 100644
> --- a/drivers/gpu/drm/i915/gt/intel_rps.c
> +++ b/drivers/gpu/drm/i915/gt/intel_rps.c
> @@ -1016,9 +1016,15 @@ void intel_rps_boost(struct i915_request *rq)
> if (rps_uses_slpc(rps)) {
> slpc = rps_to_slpc(rps);
>
> + if (slpc->min_freq_softlimit == slpc->boost_freq)
> + return;
nit but is it possible that 'slpc->min_freq_softlimit > slpc->boost_freq'
(looks possible to me from the code though we might not have intended it)?
Then we can change this to:
if (slpc->min_freq_softlimit >= slpc->boost_freq)
return;
> +
> /* Return if old value is non zero */
> - if (!atomic_fetch_inc(&slpc->num_waiters))
> + if (!atomic_fetch_inc(&slpc->num_waiters)) {
> + GT_TRACE(rps_to_gt(rps), "boost fence:%llx:%llx\n",
> + rq->fence.context, rq->fence.seqno);
Another possibility would have been to add the trace to slpc_boost_work but
this is matches host turbo so I think it is fine here.
> schedule_work(&slpc->boost_work);
> + }
>
> return;
> }
Thanks.
--
Ashutosh
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH v4] drm/i915/slpc: Optmize waitboost for SLPC
2022-10-22 2:11 ` [Intel-gfx] [PATCH v4] drm/i915/slpc: Optmize waitboost for SLPC Dixit, Ashutosh
@ 2022-10-22 17:56 ` Belgaumkar, Vinay
2022-10-22 19:22 ` Dixit, Ashutosh
0 siblings, 1 reply; 8+ messages in thread
From: Belgaumkar, Vinay @ 2022-10-22 17:56 UTC (permalink / raw)
To: Dixit, Ashutosh; +Cc: intel-gfx, dri-devel
On 10/21/2022 7:11 PM, Dixit, Ashutosh wrote:
> On Fri, 21 Oct 2022 17:24:52 -0700, Vinay Belgaumkar wrote:
> Hi Vinay,
>
>> Waitboost (when SLPC is enabled) results in a H2G message. This can result
>> in thousands of messages during a stress test and fill up an already full
>> CTB. There is no need to request for RP0 if boost_freq and the min softlimit
>> are the same.
>>
>> v2: Add the tracing back, and check requested freq
>> in the worker thread (Tvrtko)
>> v3: Check requested freq in dec_waiters as well
>> v4: Only check min_softlimit against boost_freq. Limit this
>> optimization for server parts for now.
> Sorry I didn't follow. Why are we saying limit this only to server? This:
>
> if (slpc->min_freq_softlimit == slpc->boost_freq)
> return;
>
> The condition above should work for client too if it is true? But yes it is
> typically true automatically for server but not for client. Is that what
> you mean?
yes. For client, min_freq_softlimit would typically be RPn.
>
>> Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
>> ---
>> drivers/gpu/drm/i915/gt/intel_rps.c | 8 +++++++-
>> 1 file changed, 7 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/gt/intel_rps.c b/drivers/gpu/drm/i915/gt/intel_rps.c
>> index fc23c562d9b2..32e1f5dde5bb 100644
>> --- a/drivers/gpu/drm/i915/gt/intel_rps.c
>> +++ b/drivers/gpu/drm/i915/gt/intel_rps.c
>> @@ -1016,9 +1016,15 @@ void intel_rps_boost(struct i915_request *rq)
>> if (rps_uses_slpc(rps)) {
>> slpc = rps_to_slpc(rps);
>>
>> + if (slpc->min_freq_softlimit == slpc->boost_freq)
>> + return;
> nit but is it possible that 'slpc->min_freq_softlimit > slpc->boost_freq'
> (looks possible to me from the code though we might not have intended it)?
> Then we can change this to:
>
> if (slpc->min_freq_softlimit >= slpc->boost_freq)
> return;
>
>
>> +
>> /* Return if old value is non zero */
>> - if (!atomic_fetch_inc(&slpc->num_waiters))
>> + if (!atomic_fetch_inc(&slpc->num_waiters)) {
>> + GT_TRACE(rps_to_gt(rps), "boost fence:%llx:%llx\n",
>> + rq->fence.context, rq->fence.seqno);
> Another possibility would have been to add the trace to slpc_boost_work but
> this is matches host turbo so I think it is fine here.
>
>> schedule_work(&slpc->boost_work);
>> + }
>>
>> return;
>> }
> Thanks.
> --
> Ashutosh
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH v4] drm/i915/slpc: Optmize waitboost for SLPC
2022-10-22 17:56 ` Belgaumkar, Vinay
@ 2022-10-22 19:22 ` Dixit, Ashutosh
2022-10-24 16:17 ` Belgaumkar, Vinay
0 siblings, 1 reply; 8+ messages in thread
From: Dixit, Ashutosh @ 2022-10-22 19:22 UTC (permalink / raw)
To: Belgaumkar, Vinay; +Cc: intel-gfx, dri-devel
On Sat, 22 Oct 2022 10:56:03 -0700, Belgaumkar, Vinay wrote:
>
Hi Vinay,
> >> diff --git a/drivers/gpu/drm/i915/gt/intel_rps.c b/drivers/gpu/drm/i915/gt/intel_rps.c
> >> index fc23c562d9b2..32e1f5dde5bb 100644
> >> --- a/drivers/gpu/drm/i915/gt/intel_rps.c
> >> +++ b/drivers/gpu/drm/i915/gt/intel_rps.c
> >> @@ -1016,9 +1016,15 @@ void intel_rps_boost(struct i915_request *rq)
> >> if (rps_uses_slpc(rps)) {
> >> slpc = rps_to_slpc(rps);
> >>
> >> + if (slpc->min_freq_softlimit == slpc->boost_freq)
> >> + return;
> > nit but is it possible that 'slpc->min_freq_softlimit > slpc->boost_freq'
> > (looks possible to me from the code though we might not have intended it)?
> > Then we can change this to:
> >
> > if (slpc->min_freq_softlimit >= slpc->boost_freq)
> > return;
Any comment about this? It looks clearly possible to me from the code.
So with the above change this is:
Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/slpc: Optmize waitboost for SLPC (rev4)
2022-10-22 0:24 [Intel-gfx] [PATCH v4] drm/i915/slpc: Optmize waitboost for SLPC Vinay Belgaumkar
` (2 preceding siblings ...)
2022-10-22 2:11 ` [Intel-gfx] [PATCH v4] drm/i915/slpc: Optmize waitboost for SLPC Dixit, Ashutosh
@ 2022-10-22 22:33 ` Patchwork
3 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2022-10-22 22:33 UTC (permalink / raw)
To: Belgaumkar, Vinay; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 35503 bytes --]
== Series Details ==
Series: drm/i915/slpc: Optmize waitboost for SLPC (rev4)
URL : https://patchwork.freedesktop.org/series/109840/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12277_full -> Patchwork_109840v4_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_109840v4_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_109840v4_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Participating hosts (11 -> 11)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_109840v4_full:
### IGT changes ###
#### Possible regressions ####
* igt@gem_ctx_isolation@preservation-s3@rcs0:
- shard-tglb: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12277/shard-tglb2/igt@gem_ctx_isolation@preservation-s3@rcs0.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-tglb5/igt@gem_ctx_isolation@preservation-s3@rcs0.html
* igt@sysfs_preempt_timeout@timeout@vecs0:
- shard-skl: [PASS][3] -> [FAIL][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12277/shard-skl9/igt@sysfs_preempt_timeout@timeout@vecs0.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-skl9/igt@sysfs_preempt_timeout@timeout@vecs0.html
Known issues
------------
Here are the changes found in Patchwork_109840v4_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_persistence@smoketest:
- shard-apl: [PASS][5] -> [FAIL][6] ([i915#5099])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12277/shard-apl6/igt@gem_ctx_persistence@smoketest.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-apl6/igt@gem_ctx_persistence@smoketest.html
* igt@gem_exec_balancer@parallel:
- shard-iclb: [PASS][7] -> [SKIP][8] ([i915#4525])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12277/shard-iclb2/igt@gem_exec_balancer@parallel.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-iclb7/igt@gem_exec_balancer@parallel.html
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-glk: [PASS][9] -> [FAIL][10] ([i915#2842])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12277/shard-glk7/igt@gem_exec_fair@basic-pace-solo@rcs0.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-glk8/igt@gem_exec_fair@basic-pace-solo@rcs0.html
* igt@gem_exec_fair@basic-pace@vcs0:
- shard-iclb: [PASS][11] -> [FAIL][12] ([i915#2842])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12277/shard-iclb2/igt@gem_exec_fair@basic-pace@vcs0.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-iclb7/igt@gem_exec_fair@basic-pace@vcs0.html
* igt@gem_huc_copy@huc-copy:
- shard-tglb: [PASS][13] -> [SKIP][14] ([i915#2190])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12277/shard-tglb2/igt@gem_huc_copy@huc-copy.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-tglb6/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@random:
- shard-glk: NOTRUN -> [SKIP][15] ([fdo#109271] / [i915#4613])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-glk9/igt@gem_lmem_swapping@random.html
- shard-apl: NOTRUN -> [SKIP][16] ([fdo#109271] / [i915#4613])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-apl2/igt@gem_lmem_swapping@random.html
* igt@gen7_exec_parse@basic-allowed:
- shard-apl: NOTRUN -> [SKIP][17] ([fdo#109271]) +56 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-apl6/igt@gen7_exec_parse@basic-allowed.html
* igt@i915_pm_rc6_residency@rc6-idle@vcs0:
- shard-skl: [PASS][18] -> [WARN][19] ([i915#1804])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12277/shard-skl6/igt@i915_pm_rc6_residency@rc6-idle@vcs0.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-skl7/igt@i915_pm_rc6_residency@rc6-idle@vcs0.html
* igt@kms_ccs@pipe-a-bad-aux-stride-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][20] ([fdo#109271] / [i915#3886]) +2 similar issues
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-apl2/igt@kms_ccs@pipe-a-bad-aux-stride-y_tiled_gen12_mc_ccs.html
- shard-glk: NOTRUN -> [SKIP][21] ([fdo#109271] / [i915#3886])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-glk9/igt@kms_ccs@pipe-a-bad-aux-stride-y_tiled_gen12_mc_ccs.html
* igt@kms_chamelium@hdmi-aspect-ratio:
- shard-skl: NOTRUN -> [SKIP][22] ([fdo#109271] / [fdo#111827])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-skl6/igt@kms_chamelium@hdmi-aspect-ratio.html
* igt@kms_color_chamelium@ctm-0-75:
- shard-apl: NOTRUN -> [SKIP][23] ([fdo#109271] / [fdo#111827]) +3 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-apl2/igt@kms_color_chamelium@ctm-0-75.html
- shard-glk: NOTRUN -> [SKIP][24] ([fdo#109271] / [fdo#111827])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-glk9/igt@kms_color_chamelium@ctm-0-75.html
* igt@kms_content_protection@atomic-dpms@pipe-a-dp-1:
- shard-apl: NOTRUN -> [INCOMPLETE][25] ([i915#7121] / [i915#7173])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-apl6/igt@kms_content_protection@atomic-dpms@pipe-a-dp-1.html
* igt@kms_cursor_crc@cursor-offscreen-512x170:
- shard-glk: NOTRUN -> [SKIP][26] ([fdo#109271]) +10 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-glk9/igt@kms_cursor_crc@cursor-offscreen-512x170.html
* igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size:
- shard-glk: [PASS][27] -> [FAIL][28] ([i915#2346])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12277/shard-glk2/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-glk9/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1:
- shard-skl: [PASS][29] -> [FAIL][30] ([i915#79]) +1 similar issue
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12277/shard-skl10/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-skl6/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@c-hdmi-a1:
- shard-glk: [PASS][31] -> [FAIL][32] ([i915#79])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12277/shard-glk1/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-hdmi-a1.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-glk3/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-hdmi-a1.html
* igt@kms_flip@flip-vs-expired-vblank@c-dp1:
- shard-apl: [PASS][33] -> [FAIL][34] ([i915#79])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12277/shard-apl8/igt@kms_flip@flip-vs-expired-vblank@c-dp1.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-apl2/igt@kms_flip@flip-vs-expired-vblank@c-dp1.html
* igt@kms_flip@flip-vs-suspend-interruptible@b-dp1:
- shard-apl: [PASS][35] -> [DMESG-WARN][36] ([i915#180])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12277/shard-apl3/igt@kms_flip@flip-vs-suspend-interruptible@b-dp1.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-apl6/igt@kms_flip@flip-vs-suspend-interruptible@b-dp1.html
* igt@kms_flip@plain-flip-fb-recreate-interruptible@b-hdmi-a1:
- shard-glk: [PASS][37] -> [FAIL][38] ([i915#2122])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12277/shard-glk7/igt@kms_flip@plain-flip-fb-recreate-interruptible@b-hdmi-a1.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-glk8/igt@kms_flip@plain-flip-fb-recreate-interruptible@b-hdmi-a1.html
* igt@kms_flip@plain-flip-fb-recreate@b-edp1:
- shard-skl: [PASS][39] -> [FAIL][40] ([i915#2122]) +2 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12277/shard-skl9/igt@kms_flip@plain-flip-fb-recreate@b-edp1.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-skl9/igt@kms_flip@plain-flip-fb-recreate@b-edp1.html
* igt@kms_flip_scaled_crc@flip-32bpp-yftileccs-to-64bpp-yftile-downscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][41] ([i915#2672])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-yftileccs-to-64bpp-yftile-downscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tiledg2rcccs-downscaling@pipe-a-valid-mode:
- shard-iclb: NOTRUN -> [SKIP][42] ([i915#2587] / [i915#2672]) +1 similar issue
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-iclb7/igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tiledg2rcccs-downscaling@pipe-a-valid-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-linear-to-32bpp-linear-downscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][43] ([i915#3555])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-iclb2/igt@kms_flip_scaled_crc@flip-64bpp-linear-to-32bpp-linear-downscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-valid-mode:
- shard-iclb: NOTRUN -> [SKIP][44] ([i915#2672] / [i915#3555])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-iclb8/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-valid-mode.html
* igt@kms_plane_alpha_blend@alpha-opaque-fb@pipe-a-dp-1:
- shard-apl: NOTRUN -> [FAIL][45] ([i915#4573]) +2 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-apl6/igt@kms_plane_alpha_blend@alpha-opaque-fb@pipe-a-dp-1.html
* igt@kms_psr@psr2_dpms:
- shard-iclb: [PASS][46] -> [SKIP][47] ([fdo#109441])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12277/shard-iclb2/igt@kms_psr@psr2_dpms.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-iclb7/igt@kms_psr@psr2_dpms.html
* igt@perf@polling-parameterized:
- shard-skl: [PASS][48] -> [FAIL][49] ([i915#5639])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12277/shard-skl10/igt@perf@polling-parameterized.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-skl6/igt@perf@polling-parameterized.html
* igt@syncobj_wait@wait-for-submit-delayed-submit:
- shard-skl: [PASS][50] -> [DMESG-WARN][51] ([i915#1982])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12277/shard-skl4/igt@syncobj_wait@wait-for-submit-delayed-submit.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-skl4/igt@syncobj_wait@wait-for-submit-delayed-submit.html
* igt@sysfs_clients@fair-3:
- shard-apl: NOTRUN -> [SKIP][52] ([fdo#109271] / [i915#2994]) +1 similar issue
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-apl2/igt@sysfs_clients@fair-3.html
- shard-glk: NOTRUN -> [SKIP][53] ([fdo#109271] / [i915#2994])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-glk9/igt@sysfs_clients@fair-3.html
* igt@sysfs_heartbeat_interval@mixed@vcs0:
- shard-skl: [PASS][54] -> [FAIL][55] ([i915#1731])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12277/shard-skl9/igt@sysfs_heartbeat_interval@mixed@vcs0.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-skl10/igt@sysfs_heartbeat_interval@mixed@vcs0.html
#### Possible fixes ####
* igt@gem_ctx_persistence@legacy-engines-hang@blt:
- {shard-rkl}: [SKIP][56] ([i915#6252]) -> [PASS][57]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12277/shard-rkl-5/igt@gem_ctx_persistence@legacy-engines-hang@blt.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-rkl-1/igt@gem_ctx_persistence@legacy-engines-hang@blt.html
* igt@gem_ctx_persistence@many-contexts:
- {shard-rkl}: [FAIL][58] ([i915#2410]) -> [PASS][59]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12277/shard-rkl-4/igt@gem_ctx_persistence@many-contexts.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-rkl-5/igt@gem_ctx_persistence@many-contexts.html
* igt@gem_exec_balancer@parallel-keep-in-fence:
- shard-iclb: [SKIP][60] ([i915#4525]) -> [PASS][61] +2 similar issues
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12277/shard-iclb7/igt@gem_exec_balancer@parallel-keep-in-fence.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-iclb2/igt@gem_exec_balancer@parallel-keep-in-fence.html
* igt@gem_exec_endless@dispatch@bcs0:
- {shard-rkl}: [SKIP][62] ([i915#6247]) -> [PASS][63]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12277/shard-rkl-5/igt@gem_exec_endless@dispatch@bcs0.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-rkl-1/igt@gem_exec_endless@dispatch@bcs0.html
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-iclb: [FAIL][64] ([i915#2842]) -> [PASS][65]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12277/shard-iclb2/igt@gem_exec_fair@basic-throttle@rcs0.html
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-iclb7/igt@gem_exec_fair@basic-throttle@rcs0.html
- {shard-rkl}: [FAIL][66] ([i915#2842]) -> [PASS][67]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12277/shard-rkl-3/igt@gem_exec_fair@basic-throttle@rcs0.html
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-rkl-5/igt@gem_exec_fair@basic-throttle@rcs0.html
* igt@gem_exec_reloc@basic-wc-read-noreloc:
- {shard-rkl}: [SKIP][68] ([i915#3281]) -> [PASS][69] +9 similar issues
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12277/shard-rkl-4/igt@gem_exec_reloc@basic-wc-read-noreloc.html
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-rkl-5/igt@gem_exec_reloc@basic-wc-read-noreloc.html
* igt@gem_tiled_partial_pwrite_pread@writes:
- {shard-rkl}: [SKIP][70] ([i915#3282]) -> [PASS][71] +1 similar issue
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12277/shard-rkl-3/igt@gem_tiled_partial_pwrite_pread@writes.html
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-rkl-5/igt@gem_tiled_partial_pwrite_pread@writes.html
* igt@gem_workarounds@suspend-resume-fd:
- shard-apl: [DMESG-WARN][72] ([i915#180]) -> [PASS][73] +2 similar issues
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12277/shard-apl8/igt@gem_workarounds@suspend-resume-fd.html
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-apl7/igt@gem_workarounds@suspend-resume-fd.html
* igt@i915_hangman@gt-engine-error@bcs0:
- {shard-rkl}: [SKIP][74] ([i915#6258]) -> [PASS][75]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12277/shard-rkl-5/igt@i915_hangman@gt-engine-error@bcs0.html
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-rkl-1/igt@i915_hangman@gt-engine-error@bcs0.html
* igt@i915_pipe_stress@stress-xrgb8888-ytiled:
- {shard-rkl}: [SKIP][76] ([i915#4098]) -> [PASS][77] +1 similar issue
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12277/shard-rkl-4/igt@i915_pipe_stress@stress-xrgb8888-ytiled.html
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-rkl-6/igt@i915_pipe_stress@stress-xrgb8888-ytiled.html
* igt@i915_pm_backlight@fade_with_suspend:
- {shard-rkl}: [SKIP][78] ([i915#3012]) -> [PASS][79]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12277/shard-rkl-4/igt@i915_pm_backlight@fade_with_suspend.html
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-rkl-6/igt@i915_pm_backlight@fade_with_suspend.html
* igt@i915_pm_dc@dc9-dpms:
- {shard-rkl}: [SKIP][80] ([i915#3361]) -> [PASS][81]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12277/shard-rkl-5/igt@i915_pm_dc@dc9-dpms.html
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-rkl-1/igt@i915_pm_dc@dc9-dpms.html
* igt@i915_pm_rpm@cursor:
- {shard-rkl}: [SKIP][82] ([i915#1849]) -> [PASS][83]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12277/shard-rkl-4/igt@i915_pm_rpm@cursor.html
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-rkl-6/igt@i915_pm_rpm@cursor.html
* igt@i915_pm_rpm@drm-resources-equal:
- {shard-rkl}: [SKIP][84] ([fdo#109308]) -> [PASS][85]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12277/shard-rkl-4/igt@i915_pm_rpm@drm-resources-equal.html
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-rkl-6/igt@i915_pm_rpm@drm-resources-equal.html
* igt@i915_pm_sseu@full-enable:
- {shard-rkl}: [SKIP][86] ([i915#4387]) -> [PASS][87]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12277/shard-rkl-3/igt@i915_pm_sseu@full-enable.html
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-rkl-5/igt@i915_pm_sseu@full-enable.html
* igt@i915_selftest@live@gt_pm:
- {shard-rkl}: [DMESG-FAIL][88] ([i915#4258]) -> [PASS][89]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12277/shard-rkl-6/igt@i915_selftest@live@gt_pm.html
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-rkl-1/igt@i915_selftest@live@gt_pm.html
* igt@kms_async_flips@alternate-sync-async-flip@pipe-c-edp-1:
- shard-skl: [FAIL][90] ([i915#2521]) -> [PASS][91]
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12277/shard-skl10/igt@kms_async_flips@alternate-sync-async-flip@pipe-c-edp-1.html
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-skl6/igt@kms_async_flips@alternate-sync-async-flip@pipe-c-edp-1.html
* igt@kms_async_flips@async-flip-with-page-flip-events@pipe-b-edp-1:
- shard-skl: [FAIL][92] -> [PASS][93] +1 similar issue
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12277/shard-skl7/igt@kms_async_flips@async-flip-with-page-flip-events@pipe-b-edp-1.html
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-skl9/igt@kms_async_flips@async-flip-with-page-flip-events@pipe-b-edp-1.html
* igt@kms_cursor_legacy@flip-vs-cursor@toggle:
- shard-iclb: [FAIL][94] ([i915#2346]) -> [PASS][95] +3 similar issues
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12277/shard-iclb7/igt@kms_cursor_legacy@flip-vs-cursor@toggle.html
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-iclb2/igt@kms_cursor_legacy@flip-vs-cursor@toggle.html
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-blt:
- shard-glk: [FAIL][96] ([i915#2546]) -> [PASS][97]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12277/shard-glk1/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-blt.html
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-glk3/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-blt.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-move:
- {shard-rkl}: [SKIP][98] ([i915#1849] / [i915#4098]) -> [PASS][99] +10 similar issues
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12277/shard-rkl-4/igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-move.html
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-rkl-6/igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-move.html
* igt@kms_plane_alpha_blend@constant-alpha-min@pipe-a-edp-1:
- shard-skl: [FAIL][100] ([i915#4573]) -> [PASS][101]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12277/shard-skl6/igt@kms_plane_alpha_blend@constant-alpha-min@pipe-a-edp-1.html
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-skl7/igt@kms_plane_alpha_blend@constant-alpha-min@pipe-a-edp-1.html
* igt@kms_properties@plane-properties-legacy:
- shard-glk: [DMESG-WARN][102] ([i915#118]) -> [PASS][103]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12277/shard-glk1/igt@kms_properties@plane-properties-legacy.html
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-glk3/igt@kms_properties@plane-properties-legacy.html
* igt@kms_psr@psr2_primary_blt:
- shard-iclb: [SKIP][104] ([fdo#109441]) -> [PASS][105]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12277/shard-iclb7/igt@kms_psr@psr2_primary_blt.html
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-iclb2/igt@kms_psr@psr2_primary_blt.html
* igt@kms_vblank@pipe-b-wait-busy-hang:
- {shard-rkl}: [SKIP][106] ([i915#1845] / [i915#4098]) -> [PASS][107] +13 similar issues
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12277/shard-rkl-4/igt@kms_vblank@pipe-b-wait-busy-hang.html
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-rkl-6/igt@kms_vblank@pipe-b-wait-busy-hang.html
* igt@perf@gen12-oa-tlb-invalidate:
- {shard-rkl}: [SKIP][108] ([fdo#109289]) -> [PASS][109] +1 similar issue
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12277/shard-rkl-5/igt@perf@gen12-oa-tlb-invalidate.html
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-rkl-2/igt@perf@gen12-oa-tlb-invalidate.html
* igt@perf@stress-open-close:
- shard-glk: [INCOMPLETE][110] ([i915#5213]) -> [PASS][111]
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12277/shard-glk2/igt@perf@stress-open-close.html
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-glk9/igt@perf@stress-open-close.html
#### Warnings ####
* igt@gem_exec_balancer@parallel-ordering:
- shard-iclb: [FAIL][112] ([i915#6117]) -> [SKIP][113] ([i915#4525])
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12277/shard-iclb2/igt@gem_exec_balancer@parallel-ordering.html
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-iclb7/igt@gem_exec_balancer@parallel-ordering.html
* igt@gem_pwrite@basic-exhaustion:
- shard-glk: [INCOMPLETE][114] ([i915#7248]) -> [WARN][115] ([i915#2658])
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12277/shard-glk8/igt@gem_pwrite@basic-exhaustion.html
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-glk9/igt@gem_pwrite@basic-exhaustion.html
* igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-fully-sf:
- shard-iclb: [SKIP][116] ([i915#658]) -> [SKIP][117] ([i915#2920])
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12277/shard-iclb3/igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-fully-sf.html
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-iclb2/igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-fully-sf.html
* igt@kms_psr2_sf@overlay-plane-move-continuous-sf:
- shard-iclb: [SKIP][118] ([i915#2920]) -> [SKIP][119] ([i915#658])
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12277/shard-iclb2/igt@kms_psr2_sf@overlay-plane-move-continuous-sf.html
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-iclb7/igt@kms_psr2_sf@overlay-plane-move-continuous-sf.html
* igt@kms_psr2_sf@overlay-plane-update-continuous-sf:
- shard-iclb: [SKIP][120] ([fdo#111068] / [i915#658]) -> [SKIP][121] ([i915#2920])
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12277/shard-iclb7/igt@kms_psr2_sf@overlay-plane-update-continuous-sf.html
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-iclb2/igt@kms_psr2_sf@overlay-plane-update-continuous-sf.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area:
- shard-iclb: [SKIP][122] ([i915#2920]) -> [SKIP][123] ([fdo#111068] / [i915#658]) +1 similar issue
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12277/shard-iclb2/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area.html
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-iclb7/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area.html
* igt@runner@aborted:
- shard-apl: ([FAIL][124], [FAIL][125], [FAIL][126], [FAIL][127], [FAIL][128], [FAIL][129], [FAIL][130], [FAIL][131]) ([fdo#109271] / [i915#180] / [i915#3002] / [i915#4312]) -> ([FAIL][132], [FAIL][133], [FAIL][134], [FAIL][135], [FAIL][136], [FAIL][137]) ([i915#180] / [i915#3002] / [i915#4312])
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12277/shard-apl7/igt@runner@aborted.html
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12277/shard-apl6/igt@runner@aborted.html
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12277/shard-apl8/igt@runner@aborted.html
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12277/shard-apl8/igt@runner@aborted.html
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12277/shard-apl8/igt@runner@aborted.html
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12277/shard-apl1/igt@runner@aborted.html
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12277/shard-apl3/igt@runner@aborted.html
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12277/shard-apl3/igt@runner@aborted.html
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-apl3/igt@runner@aborted.html
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-apl8/igt@runner@aborted.html
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-apl7/igt@runner@aborted.html
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-apl6/igt@runner@aborted.html
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-apl3/igt@runner@aborted.html
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-apl3/igt@runner@aborted.html
- shard-iclb: ([FAIL][138], [FAIL][139], [FAIL][140], [FAIL][141], [FAIL][142], [FAIL][143]) ([i915#3002] / [i915#4312] / [i915#7300]) -> ([FAIL][144], [FAIL][145], [FAIL][146], [FAIL][147], [FAIL][148], [FAIL][149]) ([i915#3002] / [i915#4312])
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12277/shard-iclb2/igt@runner@aborted.html
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12277/shard-iclb4/igt@runner@aborted.html
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12277/shard-iclb3/igt@runner@aborted.html
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12277/shard-iclb8/igt@runner@aborted.html
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12277/shard-iclb5/igt@runner@aborted.html
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12277/shard-iclb4/igt@runner@aborted.html
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-iclb3/igt@runner@aborted.html
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-iclb6/igt@runner@aborted.html
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-iclb8/igt@runner@aborted.html
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-iclb6/igt@runner@aborted.html
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-iclb7/igt@runner@aborted.html
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/shard-iclb3/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
[fdo#109309]: https://bugs.freedesktop.org/show_bug.cgi?id=109309
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110542]: https://bugs.freedesktop.org/show_bug.cgi?id=110542
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1731]: https://gitlab.freedesktop.org/drm/intel/issues/1731
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1804]: https://gitlab.freedesktop.org/drm/intel/issues/1804
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2410]: https://gitlab.freedesktop.org/drm/intel/issues/2410
[i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2546]: https://gitlab.freedesktop.org/drm/intel/issues/2546
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3361]: https://gitlab.freedesktop.org/drm/intel/issues/3361
[i915#3536]: https://gitlab.freedesktop.org/drm/intel/issues/3536
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4258]: https://gitlab.freedesktop.org/drm/intel/issues/4258
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4387]: https://gitlab.freedesktop.org/drm/intel/issues/4387
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#4573]: https://gitlab.freedesktop.org/drm/intel/issues/4573
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#5099]: https://gitlab.freedesktop.org/drm/intel/issues/5099
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5213]: https://gitlab.freedesktop.org/drm/intel/issues/5213
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#5327]: https://gitlab.freedesktop.org/drm/intel/issues/5327
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
[i915#5639]: https://gitlab.freedesktop.org/drm/intel/issues/5639
[i915#5939]: https://gitlab.freedesktop.org/drm/intel/issues/5939
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6117]: https://gitlab.freedesktop.org/drm/intel/issues/6117
[i915#6247]: https://gitlab.freedesktop.org/drm/intel/issues/6247
[i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
[i915#6252]: https://gitlab.freedesktop.org/drm/intel/issues/6252
[i915#6258]: https://gitlab.freedesktop.org/drm/intel/issues/6258
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6946]: https://gitlab.freedesktop.org/drm/intel/issues/6946
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#7121]: https://gitlab.freedesktop.org/drm/intel/issues/7121
[i915#7142]: https://gitlab.freedesktop.org/drm/intel/issues/7142
[i915#7173]: https://gitlab.freedesktop.org/drm/intel/issues/7173
[i915#7248]: https://gitlab.freedesktop.org/drm/intel/issues/7248
[i915#7300]: https://gitlab.freedesktop.org/drm/intel/issues/7300
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
Build changes
-------------
* Linux: CI_DRM_12277 -> Patchwork_109840v4
CI-20190529: 20190529
CI_DRM_12277: 382f329699fb46e1fccb50f6ada2af090d07686d @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7022: d73b21e653555d2e0370789071799aa0037049c1 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_109840v4: 382f329699fb46e1fccb50f6ada2af090d07686d @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109840v4/index.html
[-- Attachment #2: Type: text/html, Size: 38779 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH v4] drm/i915/slpc: Optmize waitboost for SLPC
2022-10-22 19:22 ` Dixit, Ashutosh
@ 2022-10-24 16:17 ` Belgaumkar, Vinay
0 siblings, 0 replies; 8+ messages in thread
From: Belgaumkar, Vinay @ 2022-10-24 16:17 UTC (permalink / raw)
To: Dixit, Ashutosh; +Cc: intel-gfx, dri-devel
On 10/22/2022 12:22 PM, Dixit, Ashutosh wrote:
> On Sat, 22 Oct 2022 10:56:03 -0700, Belgaumkar, Vinay wrote:
> Hi Vinay,
>
>>>> diff --git a/drivers/gpu/drm/i915/gt/intel_rps.c b/drivers/gpu/drm/i915/gt/intel_rps.c
>>>> index fc23c562d9b2..32e1f5dde5bb 100644
>>>> --- a/drivers/gpu/drm/i915/gt/intel_rps.c
>>>> +++ b/drivers/gpu/drm/i915/gt/intel_rps.c
>>>> @@ -1016,9 +1016,15 @@ void intel_rps_boost(struct i915_request *rq)
>>>> if (rps_uses_slpc(rps)) {
>>>> slpc = rps_to_slpc(rps);
>>>>
>>>> + if (slpc->min_freq_softlimit == slpc->boost_freq)
>>>> + return;
>>> nit but is it possible that 'slpc->min_freq_softlimit > slpc->boost_freq'
>>> (looks possible to me from the code though we might not have intended it)?
>>> Then we can change this to:
>>>
>>> if (slpc->min_freq_softlimit >= slpc->boost_freq)
>>> return;
> Any comment about this? It looks clearly possible to me from the code.
>
> So with the above change this is:
>
> Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
Agree.
Thanks,
Vinay.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-10-24 16:17 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-22 0:24 [Intel-gfx] [PATCH v4] drm/i915/slpc: Optmize waitboost for SLPC Vinay Belgaumkar
2022-10-22 0:57 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/slpc: Optmize waitboost for SLPC (rev4) Patchwork
2022-10-22 1:19 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-10-22 2:11 ` [Intel-gfx] [PATCH v4] drm/i915/slpc: Optmize waitboost for SLPC Dixit, Ashutosh
2022-10-22 17:56 ` Belgaumkar, Vinay
2022-10-22 19:22 ` Dixit, Ashutosh
2022-10-24 16:17 ` Belgaumkar, Vinay
2022-10-22 22:33 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/slpc: Optmize waitboost for SLPC (rev4) Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox