From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 113D6C433FE for ; Sat, 22 Oct 2022 19:22:14 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 35FFA10E00D; Sat, 22 Oct 2022 19:22:13 +0000 (UTC) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 74A0610E00D; Sat, 22 Oct 2022 19:22:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666466527; x=1698002527; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=z10eW25qva8bpYC3IDwJ5cIgEz20wIf+5sxOzXpuG5Q=; b=BjP//wbkPx/1i/GVQV8x4gv6IfWjOOnSbPU8Ir4ycIrJDX/gyYNCtVuQ EoFRZjTlf6px+Ht8F2YRkGBJRAO49oQdi/MC0JGUl6HaJkwAWeaAf+pe8 p12AcbFUUgdRG4lgIzP8O5806w4hfGWn4XSe56Yywfxv7nsc0jw/0+DB7 avuxbYh7J5ukYg6tKojPOaNLBxRxLPmUNtI0paWmA37MQLaGZZYFOAWRe cxbFEEz39JMIyYKIGHDgazaQEVvBS/KB4QHf+cANTWJBXpNdRlDawFzCu vyV2KhbzHiXgOVc31H6m681NCRa5SMjD01Ub9Tskk2lmnPNWnM4JpX9dY g==; X-IronPort-AV: E=McAfee;i="6500,9779,10508"; a="393519840" X-IronPort-AV: E=Sophos;i="5.95,205,1661842800"; d="scan'208";a="393519840" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Oct 2022 12:22:06 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10508"; a="805907439" X-IronPort-AV: E=Sophos;i="5.95,205,1661842800"; d="scan'208";a="805907439" Received: from adixit-mobl.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.209.42.156]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Oct 2022 12:22:05 -0700 Date: Sat, 22 Oct 2022 12:22:05 -0700 Message-ID: <87tu3vpste.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: "Belgaumkar, Vinay" In-Reply-To: <102c7cfd-c7b0-48b4-8fa6-7719f5529783@intel.com> References: <20221022002452.36716-1-vinay.belgaumkar@intel.com> <87wn8sppyp.wl-ashutosh.dixit@intel.com> <102c7cfd-c7b0-48b4-8fa6-7719f5529783@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [Intel-gfx] [PATCH v4] drm/i915/slpc: Optmize waitboost for SLPC X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Sat, 22 Oct 2022 10:56:03 -0700, Belgaumkar, Vinay wrote: > Hi Vinay, > >> diff --git a/drivers/gpu/drm/i915/gt/intel_rps.c b/drivers/gpu/drm/i915/gt/intel_rps.c > >> index fc23c562d9b2..32e1f5dde5bb 100644 > >> --- a/drivers/gpu/drm/i915/gt/intel_rps.c > >> +++ b/drivers/gpu/drm/i915/gt/intel_rps.c > >> @@ -1016,9 +1016,15 @@ void intel_rps_boost(struct i915_request *rq) > >> if (rps_uses_slpc(rps)) { > >> slpc = rps_to_slpc(rps); > >> > >> + if (slpc->min_freq_softlimit == slpc->boost_freq) > >> + return; > > nit but is it possible that 'slpc->min_freq_softlimit > slpc->boost_freq' > > (looks possible to me from the code though we might not have intended it)? > > Then we can change this to: > > > > if (slpc->min_freq_softlimit >= slpc->boost_freq) > > return; Any comment about this? It looks clearly possible to me from the code. So with the above change this is: Reviewed-by: Ashutosh Dixit