From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9AB36C433EF for ; Tue, 19 Jul 2022 04:03:00 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E3EE510EADC; Tue, 19 Jul 2022 04:02:59 +0000 (UTC) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6AC3A10F362 for ; Tue, 19 Jul 2022 04:02:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1658203378; x=1689739378; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=mw0sQZ/CsEqI23aga8lAEk/kxEYvWVF5CyniWmg4ghE=; b=NiVjTWEKHew1T83iMq9QvFZJMX8wQLgjMEEdgWqdC39WrAfejU9Qv4Xs O33aZY0zYXCekbXjDZs95HEei6TSfuEeqtatkfxYWmzIftbh2500pihTt 8BOx3HC2mG6eNFykWgiF5klpDI6gqYGrsdKjdbeNcUlWYxBF8wx07xBu1 jVIAQa/Wi7LjoDtbhn0nvihQUxzvnt1Oag7j8sGa0meekuDGg5Z2fTrus hqgPwvVA9G6+odHrxwLwmJYLuX/1e+WwwJX3xiqRK6yd6NfCAO7cF65FY dW7pzWzX5xavqPcZx1LaTjnmDm4MjS9A2gzE4rThibsqjgvlSQQU43QJm g==; X-IronPort-AV: E=McAfee;i="6400,9594,10412"; a="287532251" X-IronPort-AV: E=Sophos;i="5.92,282,1650956400"; d="scan'208";a="287532251" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jul 2022 20:58:52 -0700 X-IronPort-AV: E=Sophos;i="5.92,282,1650956400"; d="scan'208";a="724105608" Received: from adixit-mobl.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.255.229.53]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jul 2022 20:58:52 -0700 Date: Mon, 18 Jul 2022 20:58:52 -0700 Message-ID: <87tu7dbvnn.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Alan Previn In-Reply-To: <20220509210151.1843173-2-alan.previn.teres.alexis@intel.com> References: <20220509210151.1843173-1-alan.previn.teres.alexis@intel.com> <20220509210151.1843173-2-alan.previn.teres.alexis@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [Intel-gfx] [Intel-gfx 1/6] drm/i915/guc: Fix GuC relay log debugfs failing open X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, 09 May 2022 14:01:46 -0700, Alan Previn wrote: > > When GuC-Error-Capture was introduced, we created > buf_in_use as a way to identify if relay logging > had started. It is meant to replace the previous > method where a mmap of the GuC log buffer was Let's change mmap to something else since mmap refers to something different. > the indicator but not since GuC Error Capture > shares that mapping throughout operation. > > However, that method of checking was not updated > when the debugfs guc_log_relay_ctl_open was called. OK guc_log_relay_ctl_open introduced in this series... The code change itself lgtm, though in general I prefer count's to bool's. After tweaking the commit message above this is: Reviewed-by: Ashutosh Dixit > Fix that check. > > Fixes: > drm/i915/guc: Add capture region into intel_guc_log > (daff407a083d). > > Signed-off-by: Alan Previn > Link: https://patchwork.freedesktop.org/patch/479021/?series=101603&rev=1 > --- > drivers/gpu/drm/i915/gt/uc/intel_guc_log.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c > index 78d2989fe917..09f4d5fbca82 100644 > --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c > +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c > @@ -568,7 +568,7 @@ int intel_guc_log_set_level(struct intel_guc_log *log, u32 level) > > bool intel_guc_log_relay_created(const struct intel_guc_log *log) > { > - return log->buf_addr; > + return log->relay.buf_in_use; > } > > int intel_guc_log_relay_open(struct intel_guc_log *log) > -- > 2.25.1 >